[PATCH] very cosmetic patch for PerlIO test file

given crlf+PerlIO recent discussion, I dare suggesting very cosmetic change
to my few lines of code - comment in a test file is a tiny bit incorrect

--- crlf.t.orig Sat Jun 26 02:17:46 2004
+++ crlf.t      Tue Sep 27 16:49:40 2005
@@ -40,7 +40,7 @@
   open my $fh, "<:crlf", \$fcontents;
   local $/ = "xxx";
   local $_ = <$fh>;
-  my $pos = tell $fh; # pos must be behind "xxx", before "\nyyy\n"
+  my $pos = tell $fh; # pos must be behind "xxx", before "\nxxy\n"
   seek $fh, $pos, 0;
   $/ = "\n";
   $s = <$fh>.<$fh>;
0
vkonovalov
9/27/2005 12:54:49 PM
perl.perl5.porters 48287 articles. 1 followers. Follow

1 Replies
398 Views

Similar Articles

[PageSpeed] 44
Get it on Google Play
Get it on Apple App Store

On 9/27/05, Konovalov, Vadim <vkonovalov@spb.lucent.com> wrote:
> given crlf+PerlIO recent discussion, I dare suggesting very cosmetic chan=
ge
> to my few lines of code - comment in a test file is a tiny bit incorrect
>
> --- crlf.t.orig Sat Jun 26 02:17:46 2004
> +++ crlf.t      Tue Sep 27 16:49:40 2005

Thanks, applied as #25625.
0
rgarciasuarez
9/27/2005 8:34:11 PM
Reply:

Similar Artilces:

Patches, patches, patches...
To forestall potential incidents of Warnock's Dillemma... I'm about to apply a whole heap 'o patches to Parrot. (With appropriate [APPLIED] responses, I hope) If, at the end of the day, I have *not* applied or commented on a patch you've sent, it means I've Officially Missed It, so give another try. Sorry 'bout this. Too much mail in the mailbox, and going back in time is tricky, as it can miss subsequent discussions on patches 'n stuff. -- Dan --------------------------------------"it's like th...

Patches, patches, patches... #2
OK, this is advance warning that I'm about to be reposting a bunch of patches of mine which appear to have succumbed to Warnock's Dilemma. The first three should be uncontroversial: there's a documentation fix-up for core.ops, and new tests for strings and stacks. The last one is rather larger, and consists of a greatly expanded set of tests for PerlString's, plus a bunch of bug-fixes. I'd be grateful if Jeff or Dan could take a look at this, as I have the feeling that a lot of the scalar PMCs are going to need similar fixes. Simon ...

[PATCH] Patch to patch for callbacks in core
I should have tested this better before submitting it. This patch is to Perl 11722 after applying my previous patch. Now callbacks will actually work. :-) - D <dmlloyd@tds.net> --- mg.c-old Tue Aug 21 13:26:52 2001 +++ perl-devel/mg.c Tue Aug 21 15:09:16 2001 @@ -1068,7 +1068,18 @@ void Perl_despatch_signals(pTHX) { - PL_event_pending = 0; + if (PL_callback_head != NULL) { + CALLBACK *cur, *next; + + for (cur = PL_callback_head; cur != NULL; cur = next) { + next = cur->next; + (*cur->callback)(cur->data); + ...

[PATCH] Convert File::Basename tests to Test::More
--xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Attached is a cleanup of the File::Basename tests to use Test::More instead of ad-hockery. I also fixed a warning generated by the taint detection method by replacing it with the new one in perlsec. This is in preparation of additional tests. -- Michael G Schwern schwern@pobox.com http://www.pobox.com/~schwern Reality is that which, when you stop believing in it, doesn't go away. -- Phillip K. Dick --xHFwDpU9dbj6ez1V-- --GID0FwUMdk1T2AWN Content-Type: text/plain; cha...

[PATCH] Cleanup File::Temp test file
------=_Part_34733_22058077.1199467983477 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline The test file lib/File/Temp/t/fork.t improperly tries to use an automatic cleanup option with tempfile() (which does not support such an option). The temp file must be "manually" unlinked. Attached patch corrects this. ------=_Part_34733_22058077.1199467983477 Content-Type: application/octet-stream; name=file_temp.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fb109g0r0 Content-Disposition: attachment; filenam...

[PATCH] Really ignore .patch files
--------------030708030005060005040501 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit G'day p5p, Having now created a few .patch files, it appears the current .gitignore in blead is reporting them as untracked, rather than simply ignoring them. The attached patch adjusts the .gitignore file to really ignore .patch files. Many thanks to Abigail for super-fast application of my other patches. Cheerio, Paul -- Paul Fenwick <pjf@perltraining.com.au> | http://perltraining.com.au/ Director of Training | Ph: +61 ...

[PATCH] Cleanup File::Temp test file (revised)
Jerry D. Hedden wrote: > The test file lib/File/Temp/t/fork.t improperly tries to use an > automatic cleanup option with tempfile() (which does not support such > an option). The temp file must be "manually" unlinked. Attached > patch corrects this. Patch revised to remove extraneous debug statement. ------=_Part_34758_16559436.1199468375828 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Jerry D. Hedden wrote: > The test file lib/File/Temp/t/fork.t improperly tries to use an > automatic cle...

[PATCH] vms/test.com, File::Find tests
Before this change, C<chdir sys> (performed in various places in the File::Find tests) would set default to the system library directory. Ouch. The logical name SYS is defined in the description file (Makefile) to help out the C compiler, but it would also cause the tests lib/File/Find/t/taint.t and lib/File/Find/t/find.t to mysteriously fail when run as part of "MMK test", but not when run via any other method. Since these tests also do quite a bit of deleting in order to clean up after themselves, it's a bit scary how easily they can end up in the wrong...

[BUG] and [PATCH]: Failures in 5 tests during 'make test'; partially patched
--Apple-Mail-24--179573517 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed I got errors in 5 different tests running 'make test' this morning on a tree freshly updated from trunk. An excerpt from 'make test' output is attached. Set aside the failure in t/perl/Parrot_Distribution.t; that's well known. Here's the output of 'prove -v' on the other 4 files: [parrot] 526 $ prove -v t/codingstd/cuddled_else.t \ > t/codingstd/trailing_space.t \ > t/pmc/metaclass.t \ > t/pmc/...

[PATCH perlio.h] (was RE: [PATCH] %_ (was Re: [PATCH] operation o n `PL_na' may be undefined))
This should fix the original problem (patch below) Robin > > I can't offer any great insight, as I did not really understand the > original problem. > > "%_" or "%"SVf should give the same behaviour, as noone (except me) does > -DCHECK_FORMAT. > The original problem might have arisen because a function had managed to > gain a FORMAT > attribute. These are added in proto.h, but only #ifdef CHECK_FORMAT. > > Perhaps I could recreate the problem with the sources, but I can't > resync through my > firewall s...

[PATCH lib/Test/Harness.pm] (was Re: Patch 7989 breaks the Schwern style of testing)
--nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline While I throughly enjoy being a pathological case, is my test output broken, or did Test::Harness break? The 1.1604 man page defines /^(not\s+)?ok\b/ as the regex for determining if something is test output (shouldn't that be /i?), but doesn't clearly define what is a successful test and what is a failed one. I find having stuff after the "ok 3" very useful. My motivation was that "not ok 35" caused me to have to scan through my test counting "ok" call...

RE: [PATCH perlio.h] (was RE: [PATCH] %_ (was Re: [PATCH] operati on o n `PL_na' may be undefined))
The "audit" should reveal no cases in the 5.8.0 sources, because (a) I wrote a little script to check, (b) GCC would have spotted it. As Nick says, there are two possible solutions 1. Ban %_ in these functions, undo my patch, and gcc -Wall will find any transgressions. Any post-5.8.0 use of %_ in these functions would have to be reworked. 2. Allow %_ in these functions, and trawl through the #define spaghetti to ensure that these functions will always be defined (non-circularly) in terms of functions that implement %_. Robin -----Original Message...

[PATCH File::Spec::*] a bunch of untested patches
I patched the other File::Spec::* modules to be consistent with the latest modification on File::Spec::Unix. There's no patch for File::Spec::Mac because it doesn't fall back to a non-tainted default location : it uses $ENV{TMPDIR} or cwd. Beware. I didn't test those patches : I only have access to various Unix machines. --- lib/File/Spec/VMS.pm.orig Wed Oct 10 18:57:43 2001 +++ lib/File/Spec/VMS.pm Tue Nov 6 21:29:14 2001 @@ -269,12 +269,23 @@ sys$scratch: $ENV{TMPDIR} +Since perl 5.8.0, if running under taint mode, and if $ENV{TMPDIR} +is tainted...

[PATCH] Test patch for version 0.97
--------------000506000301030505000606 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit I had some isolated test failures with 0.96 from BSDish systems with limited locales installed. The attached patch brings bleadperl in line with the CPAN 0.97 release. I'd like to see it get into 5.16 if possible, so that we don't have needless test failures. Thanks John --------------000506000301030505000606 Content-Type: text/x-patch; name="version-0.97.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachm...

Web resources about - [PATCH] very cosmetic patch for PerlIO test file - perl.perl5.porters

Cosmetics - Wikipedia, the free encyclopedia
Cosmetics (colloquially known as makeup or make-up ) are care substances used to enhance the appearance or odor of the human body . They are ...

Cosmetics - Wikipedia, the free encyclopedia
Cosmetics (colloquially known as makeup or make-up ) are care substances used to enhance the appearance or odor of the human body . They are ...

Cosmetics - Wikipedia, the free encyclopedia
In the U.S., the Food and Drug Administration (FDA), which regulates cosmetics, defines cosmetics as "intended to be applied to the human body ...

Naperville Cosmetic (@NapCosmeticDent) on Twitter
Sign in Sign up To bring you Twitter, we and our partners use cookies on our and other websites. Cookies help personalize Twitter content, tailor ...

NYX Cosmetics Mobile on the App Store on iTunes
Get NYX Cosmetics Mobile on the App Store. See screenshots and ratings, and read customer reviews.

mac cosmetics rainbow eyeshadow fake eyelashes on a green eye - Flickr - Photo Sharing!
rainbow eyeshadow with long fake eyelashes Eyes: Corn s/s, Sea Me s/s, loreal hip duo in Flamboyant, Sushi Flower e/s, Sunsposion e/s, Lily White ...

The Benefit Cosmetics Flawless Friends Network - YouTube
Hello, babies! It's Miss Cleo, back for the Benefit Cosmetics Flawless Friends Network! I'm here to make you feel gorgeous. Advice about a new ...

Target left wearing fake cosmetics as US supplier vanishes
The mysterious US company that supplied allegedly counterfeit MAC cosmetics to Target in Australia has vanished, leaving behind several questions ...

Cosmetic retailer Sephora set to shake up local stores
It's going to be lipsticks at 10 paces when the giant cosmetics retailer Sephora opens in Australia, with the new entrant tipped to have more ...

Woman undergoing cosmetic surgery has heart attack
A YOUNG Sydney woman was last night recovering in hospital after going into cardiac&#173; arrest during routine cosmetic surgery.

Resources last updated: 12/7/2015 8:53:53 PM