superreview cancelled: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 180129] Cleaned up patch, moving review requestsMike Pinkerton <pinkerton@aol.net> has cancelled Torben
<torben@despammed.com>'s request for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 180129: Cleaned up patch, moving review requests
https://bugzilla.mozilla.org/attachment.cgi?id=180129&action=edit
...
superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 181275] patch with pinkerton's comments addresedTorben <torben@despammed.com> has asked Simon Fraser (on vacation)
<sfraser_bugs@smfr.org> for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 181275: patch with pinkerton's comments addresed
https://bugzilla.mozilla.org/attachment.cgi?id=181275&action=edit
------- Additional Comments from Torben <torben@despammed.com>
> does this only happen when dragging files?
> what about when downloading them via normal means?
...
superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 183947] Patch w/o LocalFile2Torben <torben@despammed.com> has asked Simon Fraser <sfraser_bugs@smfr.org>
for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 183947: Patch w/o LocalFile2
https://bugzilla.mozilla.org/attachment.cgi?id=183947&action=edit
------- Additional Comments from Torben <torben@despammed.com>
Removed all traces of nsILocalFile2 (sorry timeless/biesi), moved the
declaration of SetComment to nsILocalFileMac else as the last patch. Oth...
superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 179991] Saves the URL as a Finder comment for drag and dropstimeless@myrealbox.com (working) <timeless@bemail.org> has asked Simon Fraser
<sfraser_bugs@smfr.org> for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 179991: Saves the URL as a Finder comment for drag and drops
https://bugzilla.mozilla.org/attachment.cgi?id=179991&action=edit
...
superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 182858] Patch ver. 4, correcting errorTorben <torben@despammed.com> has asked Simon Fraser <sfraser_bugs@smfr.org>
for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 182858: Patch ver. 4, correcting error
https://bugzilla.mozilla.org/attachment.cgi?id=182858&action=edit
------- Additional Comments from Torben <torben@despammed.com>
asking sfraser for sr and doug for r/sr? for the LocalFile2 change.
...
superreview cancelled: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 181275] patch with pinkerton's comments addresedTorben <torben@despammed.com> has cancelled Torben <torben@despammed.com>'s
request for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 181275: patch with pinkerton's comments addresed
https://bugzilla.mozilla.org/attachment.cgi?id=181275&action=edit
...
superreview cancelled: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 183947] Patch w/o LocalFile2Torben <torben@despammed.com> has cancelled Torben <torben@despammed.com>'s
request for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 183947: Patch w/o LocalFile2
https://bugzilla.mozilla.org/attachment.cgi?id=183947&action=edit
...
superreview cancelled: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 179991] Saves the URL as a Finder comment for drag and dropsTorben <torben@despammed.com> has cancelled timeless@myrealbox.com (working)
<timeless@bemail.org>'s request for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 179991: Saves the URL as a Finder comment for drag and drops
https://bugzilla.mozilla.org/attachment.cgi?id=179991&action=edit
...
superreview cancelled: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 182858] Patch ver. 4, correcting errorTorben <torben@despammed.com> has cancelled Torben <torben@despammed.com>'s
request for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 182858: Patch ver. 4, correcting error
https://bugzilla.mozilla.org/attachment.cgi?id=182858&action=edit
...
superreview requested: [Bug 239984] [OSX] "Minimize Window", "Bring All to Front", and "Zoom Window" in the "Window" menu, cannot be chosen. : [Attachment 162779] Minimize & zoom frontend patchAsaf Romano <bugs.mano@mail-central.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 239984: [OSX] "Minimize Window", "Bring All to Front", and "Zoom Window" in
the "Window" menu, cannot be chosen.
https://bugzilla.mozilla.org/show_bug.cgi?id=239984
Attachment 162779: Minimize & zoom frontend patch
https://bugzilla.mozilla.org/attachment.cgi?id=162779&action=edit
...
superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173080] updated patch file to reflect Mike's commentsolivier@umich.edu has asked Mike Pinkerton <pinkerton@aol.net> for superreview:
Bug 263336: Add keyboard searching of "stored cookies" and "site permissions"
lists.
https://bugzilla.mozilla.org/show_bug.cgi?id=263336
Attachment 173080: updated patch file to reflect Mike's comments
https://bugzilla.mozilla.org/attachment.cgi?id=173080&action=edit
...
superreview requested: [Bug 300149] [SM v1.0a++, Windows] In "Add/Remove Programs", version is "1.0" instead of "1.0a" : [Attachment 189975] patchChristian Biesinger (:bi) <cbiesinger@gmx.at> has asked Daniel Veditz
<dveditz@cruzio.com> for superreview:
Bug 300149: [SM v1.0a++, Windows] In "Add/Remove Programs", version is "1.0"
instead of "1.0a"
https://bugzilla.mozilla.org/show_bug.cgi?id=300149
Attachment 189975: patch
https://bugzilla.mozilla.org/attachment.cgi?id=189975&action=edit
------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at>
this should do it.
kairo: note that this would not have been an issue had version.txt a new line
at the end...
superreview requested: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patchChristian Biesinger <cbiesinger@gmx.at> has asked Darin Fisher (IBM)
<darin@meer.net> for superreview:
Bug 241209: "Show File Location" and "Launch File" buttons (on download
progress dialog) don't work
http://bugzilla.mozilla.org/show_bug.cgi?id=241209
Attachment 147465: patch
http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit
...
superreview requested: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1Edward Lee (Mardak) <edilee@gmail.com> has asked Christian :Biesinger
<cbiesinger@gmx.at> for superreview:
Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't
show completion
https://bugzilla.mozilla.org/show_bug.cgi?id=418961
Attachment 305432: v1
https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit
------- Additional Comments from Edward Lee (Mardak) <edilee@gmail.com>
Similar to what we needed to do for exthandler.. set the NETWORK bit. All
places in webbrowserpersist that have a STATE_START ...