superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #2Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked for
superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206229: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit
...
superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] PatchMasayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 201159: Patch rv1.0
https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit
------- Additional Comments from Masayuki Nakano (Mozilla Japan)
<masayuki@d-toybox.com>
This fix this bug.
aDocum...
superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch rneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted Masayuki
Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206229: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com>
> v...
superreview cancelled: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] PatchChristian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> has
cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for
superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 201159: Patch rv1.0
https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit
------- Additional Comments from Christian Biesinger (:bi) (reviews slower than
usual) &l...
superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206517] Patch fMasayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted Masayuki
Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206517: Patch for check-in
https://bugzilla.mozilla.org/attachment.cgi?id=206517&action=edit
...
superreview requested: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patchChristian Biesinger (:bi) <cbiesinger@gmx.at> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the
link itself displays file size on download (FTP)
https://bugzilla.mozilla.org/show_bug.cgi?id=284276
Attachment 177385: patch
https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit
------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at>
might that ever change? if not, I'll remove the comment before checking in,
then.
...
superreview granted: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patchBoris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi)
<cbiesinger@gmx.at>'s request for superreview:
Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the
link itself displays file size on download (FTP)
https://bugzilla.mozilla.org/show_bug.cgi?id=284276
Attachment 177385: patch
https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
Seems reasonable
...
superreview requested: [Bug 290381] "Save Link As..." doubles the extension if the link contains an escaped hash/pound (#) sign encoded as %23 : [Attachment 191332] xpfe patch v1.4Caleb <bugs.caleb@gmail.com> has asked Christian Biesinger (:bi)
<cbiesinger@gmx.at> for superreview:
Bug 290381: "Save Link As..." doubles the extension if the link contains an
escaped hash/pound (#) sign encoded as %23
https://bugzilla.mozilla.org/show_bug.cgi?id=290381
Attachment 191332: xpfe patch v1.4
https://bugzilla.mozilla.org/attachment.cgi?id=191332&action=edit
...
superreview requested: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 176098] Simpler patchSimon Fraser <sfraser_bugs@smfr.org> has asked Darin Fisher <darin@meer.net>
for superreview:
Bug 281648: "Download Link Target" results in bad download for large MP3 file.
https://bugzilla.mozilla.org/show_bug.cgi?id=281648
Attachment 176098: Simpler patch
https://bugzilla.mozilla.org/attachment.cgi?id=176098&action=edit
...
superreview requested: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 176098] Simpler patch #2Josh Aas <joshmoz@gmail.com> has asked Mike Pinkerton <pinkerton@aol.net> for
superreview:
Bug 281648: "Download Link Target" results in bad download for large MP3 file.
https://bugzilla.mozilla.org/show_bug.cgi?id=281648
Attachment 176098: Simpler patch
https://bugzilla.mozilla.org/attachment.cgi?id=176098&action=edit
...
superreview cancelled: [Bug 290381] "Save Link As..." doubles the extension if the link contains an escaped hash/pound (#) sign encoded as %23 : [Attachment 191332] xpfe patch v1.4Christian Biesinger (:bi) <cbiesinger@gmx.at> has cancelled Caleb
<bugs.caleb@gmail.com>'s request for superreview:
Bug 290381: "Save Link As..." doubles the extension if the link contains an
escaped hash/pound (#) sign encoded as %23
https://bugzilla.mozilla.org/show_bug.cgi?id=290381
Attachment 191332: xpfe patch v1.4
https://bugzilla.mozilla.org/attachment.cgi?id=191332&action=edit
------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at>
sorry, I'm not a super-reviewer...
...
superreview granted: [Bug 290381] "Save Link As..." doubles the extension if the link contains an escaped hash/pound (#) sign encoded as %23 : [Attachment 191332] xpfe patch v1.4neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for
superreview:
Bug 290381: "Save Link As..." doubles the extension if the link contains an
escaped hash/pound (#) sign encoded as %23
https://bugzilla.mozilla.org/show_bug.cgi?id=290381
Attachment 191332: xpfe patch v1.4
https://bugzilla.mozilla.org/attachment.cgi?id=191332&action=edit
...
superreview requested: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save #3Dan Mosedale <dmose@mozilla.org> has asked Christian :Biesinger
<cbiesinger@gmx.at> for superreview:
Bug 299372: Content-Disposition headers no longer looked at for Save Link As
filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of
the attachment; Save Page As works fine
https://bugzilla.mozilla.org/show_bug.cgi?id=299372
Attachment 293766: "Save Link As..." patch, v1
https://bugzilla.mozilla.org/attachment.cgi?id=293766&action=edit
------- Additional Comments from Dan Mosedale <dmose@mozilla.org>
This patch changes...
superreview requested: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 169230] v2 patchDarin Fisher (IBM) <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu>
for superreview:
Bug 261929: Consider sending urls in UTF-8 by default (images/links with
non-ASCII chacters not displayed)
https://bugzilla.mozilla.org/show_bug.cgi?id=261929
Attachment 169230: v2 patch
https://bugzilla.mozilla.org/attachment.cgi?id=169230&action=edit
...