superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #2Aaron Leventhal (vacation: mostly gone until Oct 17)
<aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for
superreview:
Bug 312788: Crash exposing invisible plugins
https://bugzilla.mozilla.org/show_bug.cgi?id=312788
Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at
it, make absolutely sure we don't ever try to create children for native
accessibles (make native accessibles inherit from the leaf class)
https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit
...
superreview granted: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to creBrian Ryner <bryner@brianryner.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 312788: Crash exposing invisible plugins
https://bugzilla.mozilla.org/show_bug.cgi?id=312788
Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at
it, make absolutely sure we don't ever try to create children for native
accessibles (make native accessibles inherit from the leaf class)
https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit
...
superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 264442: plugin finder can't find anything for windows media.
https://bugzilla.mozilla.org/show_bug.cgi?id=264442
Attachment 162212: Don't assume we don't have a plugin before getting a
responce from the network.
https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit
...
superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 264442: plugin finder can't find anything for windows media.
https://bugzilla.mozilla.org/show_bug.cgi?id=264442
Attachment 162212: Don't assume we don't have a plugin before getting a
responce from the network.
https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
r+sr=bzbarsky, I guess..
Is ther a reason mIsBrokenPlugin is write-only?
...
superreview requested: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sensetimeless@myrealbox.com <timeless@bemail.org> has asked Johnny Stenback
<jst@netscape.com> for superreview:
Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in
GlobalWindowImpl::Unescape
http://bugzilla.mozilla.org/show_bug.cgi?id=217896
Attachment 130691: don't do silly things that don't make sense
http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit
...
superreview requested: [Bug 451234] don't stop plugins from loading just because they don't have a resource file : [Attachment 334535] fix v1.0Josh Aas <joshmoz@gmail.com> has asked Robert O'Callahan (:roc) (Mozilla
Corporation) <roc@ocallahan.org> for superreview:
Bug 451234: don't stop plugins from loading just because they don't have a
resource file
https://bugzilla.mozilla.org/show_bug.cgi?id=451234
Attachment 334535: fix v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=334535&action=edit
...
superreview requested: [Bug 300779] Support multiple selection for xul:tree : [Attachment 190476] Expose via a11y events. We don't need DOMItemSelected after all, they aren't fired for tree. We'll g #3Aaron Leventhal <aaronleventhal@moonset.net> has asked Robert O'Callahan
(Novell) <roc@ocallahan.org> for superreview:
Bug 300779: Support multiple selection for xul:tree
https://bugzilla.mozilla.org/show_bug.cgi?id=300779
Attachment 190476: Expose via a11y events. We don't need DOMItemSelected after
all, they aren't fired for tree. We'll go off of "select" DOM events later for
the add/remove a11y events.
https://bugzilla.mozilla.org/attachment.cgi?id=190476&action=edit
...
superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make senseJohnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com
<timeless@bemail.org>'s request for superreview:
Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in
GlobalWindowImpl::Unescape
http://bugzilla.mozilla.org/show_bug.cgi?id=217896
Attachment 130691: don't do silly things that don't make sense
http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit
------- Additional Comments from Johnny Stenback <jst@netscape.com>
sr=jst
...
superreview granted: [Bug 451234] don't stop plugins from loading just because they don't have a resource file : [Attachment 334535] fix v1.0Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted
Josh Aas <joshmoz@gmail.com>'s request for superreview:
Bug 451234: don't stop plugins from loading just because they don't have a
resource file
https://bugzilla.mozilla.org/show_bug.cgi?id=451234
Attachment 334535: fix v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=334535&action=edit
...
superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nondRobert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview:
Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title
in defs
https://bugzilla.mozilla.org/show_bug.cgi?id=340083
Attachment 224205: don't create frames for content we don't handle, don't
invalidate nondisplay content
https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit
...
superreview requested: [Bug 284364] Plugins don't work in window where midas has been enabled. : [Attachment 175986] Turn on plugins when we're done editing.Johnny Stenback <jst@mozilla.org> has asked Boris Zbarsky <bzbarsky@mit.edu>
for superreview:
Bug 284364: Plugins don't work in window where midas has been enabled.
https://bugzilla.mozilla.org/show_bug.cgi?id=284364
Attachment 175986: Turn on plugins when we're done editing.
https://bugzilla.mozilla.org/attachment.cgi?id=175986&action=edit
...
superreview requested: [Bug 288532] OOM crash [@ XPCConvert::JSErrorToXPCException] : [Attachment 179228] don't leak and don't crashtimeless@myrealbox.com (working) <timeless@bemail.org> has asked
rbs@maths.uq.edu.au for superreview:
Bug 288532: OOM crash [@ XPCConvert::JSErrorToXPCException]
https://bugzilla.mozilla.org/show_bug.cgi?id=288532
Attachment 179228: don't leak and don't crash
https://bugzilla.mozilla.org/attachment.cgi?id=179228&action=edit
...
superreview requested: [Bug 333579] Firefox crash with Window-Eyes and DHTML/AJAX : [Attachment 228812] Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y treAaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 333579: Firefox crash with Window-Eyes and DHTML/AJAX
https://bugzilla.mozilla.org/show_bug.cgi?id=333579
Attachment 228812: Two fixes for image map a11y: 1) Don't walk into maps so
that areas don't show twice in a11y tree, 2) Don't refer to |this| in area
constructor, Init() from outside as other accessibles do
https://bugzilla.mozilla.org/attachment.cgi?id=228812&action=edit
...
superreview requested: [Bug 300779] Support multiple selection for xul:tree : [Attachment 190476] Expose via a11y events. We don't need DOMItemSelected after all, they aren't fired for tree. We'll g #2Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner
<bryner@brianryner.com> for superreview:
Bug 300779: Support multiple selection for xul:tree
https://bugzilla.mozilla.org/show_bug.cgi?id=300779
Attachment 190476: Expose via a11y events. We don't need DOMItemSelected after
all, they aren't fired for tree. We'll go off of "select" DOM events later for
the add/remove a11y events.
https://bugzilla.mozilla.org/attachment.cgi?id=190476&action=edit
...