superreview denied: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 193985] Updated changes to files based on review feedback from Wan-TehWan-Teh Chang <wtchang@redhat.com> has denied Sandeep Konchady
<Sandeep.Konchady@Sun.COM>'s request for superreview:
Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=302550
Attachment 193985: Updated changes to files based on review feedback from
Wan-Teh
https://bugzilla.mozilla.org/attachment.cgi?id=193985&action=edit
------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com>
Sandeep,
Some of the changes in this patch are wrong.
1. coreconf/import.pl
Just remove the $var{ZI...
superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 195812] Modifications as per Wan-Teh's suggestionsSandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang
<wtchang@redhat.com> for superreview:
Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=302550
Attachment 195812: Modifications as per Wan-Teh's suggestions
https://bugzilla.mozilla.org/attachment.cgi?id=195812&action=edit
------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM>
1. coreconf/import.pl
Just remove the $var{ZIP} assignment because $var{ZIP}
is not used. Don't replace the assignment by ...
superreview granted: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 195812] Modifications as per Wan-Teh's suggestionsWan-Teh Chang <wtchang@redhat.com> has granted Sandeep Konchady
<Sandeep.Konchady@Sun.COM>'s request for superreview:
Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=302550
Attachment 195812: Modifications as per Wan-Teh's suggestions
https://bugzilla.mozilla.org/attachment.cgi?id=195812&action=edit
------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com>
r=wtc.
>@@ -241,16 +243,21 @@
>
> # (3) specify "linker" information
> JAVA_CPU = i386
>-...
superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 192550] Modifications to release.pl and import.pl to comply with original layoutSandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang
<wtchang@redhat.com> for superreview:
Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=302550
Attachment 192550: Modifications to release.pl and import.pl to comply with
original layout
https://bugzilla.mozilla.org/attachment.cgi?id=192550&action=edit
------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM>
Updated coreconf/release.pl and coreconf/import.pl to comply with original
layout structure.
...
superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 192522] Modified coreconf/jdk.mk, build_all.pl and all.sh to switch to 64 bit compilation foSandeep Konchady <Sandeep.Konchady@Sun.COM> has asked glen beasley
<glen.beasley@sun.com> for superreview:
Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=302550
Attachment 192522: Modified coreconf/jdk.mk, build_all.pl and all.sh to switch
to 64 bit compilation for AMD64
https://bugzilla.mozilla.org/attachment.cgi?id=192522&action=edit
------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM>
Two modifications are included in this bug.
[1] Based on Glen's finding that co...
superreview denied: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 192550] Modifications to release.pl and import.pl to comply with original layoutWan-Teh Chang <wtchang@redhat.com> has denied Sandeep Konchady
<Sandeep.Konchady@Sun.COM>'s request for superreview:
Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=302550
Attachment 192550: Modifications to release.pl and import.pl to comply with
original layout
https://bugzilla.mozilla.org/attachment.cgi?id=192550&action=edit
------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com>
This patch has some problems. Most are minor, but one or two
are serious, hence the review-.
...
superreview cancelled: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 192522] Modified coreconf/jdk.mk, build_all.pl and all.sh to switch to 64 bit compilation foglen beasley <glen.beasley@sun.com> has cancelled Sandeep Konchady
<Sandeep.Konchady@Sun.COM>'s request for superreview:
Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=302550
Attachment 192522: Modified coreconf/jdk.mk, build_all.pl and all.sh to switch
to 64 bit compilation for AMD64
https://bugzilla.mozilla.org/attachment.cgi?id=192522&action=edit
...
superreview requested: [Bug 313176] allow JSS to enable more options on SSLSockets such as SSL_BYPASS_PKCS11 : [Attachment 201764] applied Wan-Teh review changesglen beasley <glen.beasley@sun.com> has asked for superreview:
Bug 313176: allow JSS to enable more options on SSLSockets such as
SSL_BYPASS_PKCS11
https://bugzilla.mozilla.org/show_bug.cgi?id=313176
Attachment 201764: applied Wan-Teh review changes
https://bugzilla.mozilla.org/attachment.cgi?id=201764&action=edit
...
superreview requested: [Bug 313176] allow JSS to enable more options on SSLSockets such as SSL_BYPASS_PKCS11 : [Attachment 201764] applied Wan-Teh review changes #2glen beasley <glen.beasley@sun.com> has asked Nelson Bolyard
<nelson@bolyard.com> for superreview:
Bug 313176: allow JSS to enable more options on SSLSockets such as
SSL_BYPASS_PKCS11
https://bugzilla.mozilla.org/show_bug.cgi?id=313176
Attachment 201764: applied Wan-Teh review changes
https://bugzilla.mozilla.org/attachment.cgi?id=201764&action=edit
...
superreview requested: [Bug 172077] Need a way for embedders to disable all plugins : [Attachment 151288] updated patch with change requested by the reviewerChristian Persch <chpe@gnome.org> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 172077: Need a way for embedders to disable all plugins
http://bugzilla.mozilla.org/show_bug.cgi?id=172077
Attachment 151288: updated patch with change requested by the reviewer
http://bugzilla.mozilla.org/attachment.cgi?id=151288&action=edit
------- Additional Comments from Christian Persch <chpe@gnome.org>
carrying forward bzbarsky's r+, and asking for sr
...
superreview requested: [Bug 314098] getProvider().toString() returns "Mozilla-JSS version 3.3" in JSS 4.x : [Attachment 203558] Modified the computation of JSS_VERSION based on Wan-Teh's suggestionSandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang
<wtchang@redhat.com> for superreview:
Bug 314098: getProvider().toString() returns "Mozilla-JSS version 3.3" in JSS
4.x
https://bugzilla.mozilla.org/show_bug.cgi?id=314098
Attachment 203558: Modified the computation of JSS_VERSION based on Wan-Teh's
suggestion
https://bugzilla.mozilla.org/attachment.cgi?id=203558&action=edit
------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM>
Modified the computation of JSS_VERSION based on Wan-Teh's suggestion. This...
superreview requested: [Bug 285932] Need faster SHA1 implementation, especially for AMD64 : [Attachment 191918] Address most review feedbackNelson Bolyard <nelson@bolyard.com> has asked Wan-Teh Chang
<wtchang@redhat.com> for superreview:
Bug 285932: Need faster SHA1 implementation, especially for AMD64
https://bugzilla.mozilla.org/show_bug.cgi?id=285932
Attachment 191918: Address most review feedback
https://bugzilla.mozilla.org/attachment.cgi?id=191918&action=edit
------- Additional Comments from Nelson Bolyard <nelson@bolyard.com>
This patch addresses all the review feedback except bob's comment about
the tmp variable being needed by both ROTL and HTONL. If we find any
platform on which i...
superreview granted: [Bug 172077] Need a way for embedders to disable all plugins : [Attachment 151288] updated patch with change requested by the reviewerScott MacGregor <mscott@mozilla.org> has granted Christian Persch
<chpe@gnome.org>'s request for superreview:
Bug 172077: Need a way for embedders to disable all plugins
http://bugzilla.mozilla.org/show_bug.cgi?id=172077
Attachment 151288: updated patch with change requested by the reviewer
http://bugzilla.mozilla.org/attachment.cgi?id=151288&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
plussing since bz said this is ok :)
...
superreview cancelled: [Bug 313176] allow JSS to enable more options on SSLSockets such as SSL_BYPASS_PKCS11 : [Attachment 201764] applied Wan-Teh review changesNelson Bolyard <nelson@bolyard.com> has cancelled glen beasley
<glen.beasley@sun.com>'s request for superreview:
Bug 313176: allow JSS to enable more options on SSLSockets such as
SSL_BYPASS_PKCS11
https://bugzilla.mozilla.org/show_bug.cgi?id=313176
Attachment 201764: applied Wan-Teh review changes
https://bugzilla.mozilla.org/attachment.cgi?id=201764&action=edit
------- Additional Comments from Nelson Bolyard <nelson@bolyard.com>
1) Minor stylistic inconsistency:
Some java comments begin with a capital letter, like this one:
> /**
>+ ...