superreview requested: [Bug 301367] Tag Files with Source URL : [Attachment 204417] revised patch to tag files with source url

Peter Weilbacher <mozilla@Weilbacher.org> has asked Darin Fisher
<darin@meer.net> for superreview:
Bug 301367: Tag Files with Source URL
https://bugzilla.mozilla.org/show_bug.cgi?id=301367

Attachment 204417: revised patch to tag files with source url
https://bugzilla.mozilla.org/attachment.cgi?id=204417&action=edit

------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org>
As the cross-platform coordination in bug 90918 has failed I think it makes
sense to try the OS/2 only approach again, hence I ask for reviews again.

This patch attends to darin's comments about the first version.
0
bugzilla
12/4/2005 10:22:03 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
688 Views

Similar Articles

[PageSpeed] 14
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 301367] Tag Files with Source URL : [Attachment 204417] revised patch to tag files with source url
Darin Fisher <darin@meer.net> has granted Peter Weilbacher <mozilla@Weilbacher.org>'s request for superreview: Bug 301367: Tag Files with Source URL https://bugzilla.mozilla.org/show_bug.cgi?id=301367 Attachment 204417: revised patch to tag files with source url https://bugzilla.mozilla.org/attachment.cgi?id=204417&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> I don't really like the ifdef'ing in cross-platform code, but ok. sr=darin assuming mkaply is okay with the stuff inside the ifdefs ;-) ...

superreview requested: [Bug 301367] Tag Files with Source URL : [Attachment 189829] patch to tag files with source url
Michael Kaply (IBM) (mkaply) <mozilla@kaply.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 301367: Tag Files with Source URL https://bugzilla.mozilla.org/show_bug.cgi?id=301367 Attachment 189829: patch to tag files with source url https://bugzilla.mozilla.org/attachment.cgi?id=189829&action=edit ------- Additional Comments from Michael Kaply (IBM) (mkaply) <mozilla@kaply.com> r=mkaply ...

superreview denied: [Bug 301367] Tag Files with Source URL : [Attachment 189829] patch to tag files with source url
Darin Fisher <darin@meer.net> has denied Michael Kaply (IBM) (mkaply) <mozilla@kaply.com>'s request for superreview: Bug 301367: Tag Files with Source URL https://bugzilla.mozilla.org/show_bug.cgi?id=301367 Attachment 189829: patch to tag files with source url https://bugzilla.mozilla.org/attachment.cgi?id=189829&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Whenever you change an interface definition, you MUST change the corresponding "uuid" property of the interface. Otherwise, existing XPCOM components may crash ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4
Christian Biesinger <cbiesinger@gmx.at> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143792: patch v4 http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit ------- Additional Comments from Christian Biesinger <cbiesinger@gmx.at> I'll change nsIFileProtocolHandler's uuid before checking in ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2
Christian Biesinger <cbiesinger@gmx.at> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143888: patch for callers, v2 http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit ------- Additional Comments from Christian Biesinger <cbiesinger@gmx.at> I'll make those changes ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4 #2
Christian Biesinger <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143792: patch v4 http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2 #2
Christian Biesinger <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143888: patch for callers, v2 http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit ...

superreview requested: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> Asking for sr on this 7-char patch in case we need to take it ...

superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 180129] Cleaned up patch, moving review requests
Torben <torben@despammed.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 90918: RFE: Add url in "comments" field of the "get info" window when download file. https://bugzilla.mozilla.org/show_bug.cgi?id=90918 Attachment 180129: Cleaned up patch, moving review requests https://bugzilla.mozilla.org/attachment.cgi?id=180129&action=edit ...

superreview requested: [Bug 253405] Warning for document.all doesn't list source file or line number : [Attachment 155287] get the source file and line number
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 253405: Warning for document.all doesn't list source file or line number http://bugzilla.mozilla.org/show_bug.cgi?id=253405 Attachment 155287: get the source file and line number http://bugzilla.mozilla.org/attachment.cgi?id=155287&action=edit ...

superreview requested: [Bug 253405] Warning for document.all doesn't list source file or line number : [Attachment 155287] get the source file and line number #2
Boris Zbarsky <bzbarsky@mit.edu> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 253405: Warning for document.all doesn't list source file or line number http://bugzilla.mozilla.org/show_bug.cgi?id=253405 Attachment 155287: get the source file and line number http://bugzilla.mozilla.org/attachment.cgi?id=155287&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Brendan would be a much more reasonable sr for this than I (especially given that note on reviewers.html). ...

superreview requested: [Bug 278161] make file URLs always be in (escaped) UTF-8 regardless of the file system encoding : [Attachment 178951] patch
Jungshik Shin <jshin1987@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 278161: make file URLs always be in (escaped) UTF-8 regardless of the file system encoding https://bugzilla.mozilla.org/show_bug.cgi?id=278161 Attachment 178951: patch https://bugzilla.mozilla.org/attachment.cgi?id=178951&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> Asking for review. ...

superreview requested: [Bug 408138] File URL incorrect when file path is not in filesystem encoding : [Attachment 331472] patch changed according to comment #2
Michal Novotny <michal@allpeers.com> has asked Darin Fisher <darin.moz@gmail.com> for superreview: Bug 408138: File URL incorrect when file path is not in filesystem encoding https://bugzilla.mozilla.org/show_bug.cgi?id=408138 Attachment 331472: patch changed according to comment #2 https://bugzilla.mozilla.org/attachment.cgi?id=331472&action=edit ...

superreview requested: [Bug 408138] File URL incorrect when file path is not in filesystem encoding : [Attachment 331472] patch changed according to comment #2 #2
Michal Novotny <michal@allpeers.com> has asked Boris Zbarsky (todo: 200+ items) [gone 8/9--8/17] <bzbarsky@mit.edu> for superreview: Bug 408138: File URL incorrect when file path is not in filesystem encoding https://bugzilla.mozilla.org/show_bug.cgi?id=408138 Attachment 331472: patch changed according to comment #2 https://bugzilla.mozilla.org/attachment.cgi?id=331472&action=edit ...

Web resources about - superreview requested: [Bug 301367] Tag Files with Source URL : [Attachment 204417] revised patch to tag files with source url - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/17/2016 11:17:00 AM