superreview cancelled: [Bug 300183] Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode : [Attachment 188762] Patch rv1.0
Scott MacGregor <mscott@mozilla.org> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 300183: Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode https://bugzilla.mozilla.org/show_bug.cgi?id=300183 Attachment 188762: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=188762&action=edit ...

superreview granted: [Bug 300183] Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode : [Attachment 188763] Patch rv1.0 -u8pw
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 300183: Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode https://bugzilla.mozilla.org/show_bug.cgi?id=300183 Attachment 188763: Patch rv1.0 -u8pw https://bugzilla.mozilla.org/attachment.cgi?id=188763&action=edit ...

superreview requested: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 171508] patch
Jungshik Shin <jshin1987@gmail.com> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding https://bugzilla.mozilla.org/show_bug.cgi?id=229548 Attachment 171508: patch https://bugzilla.mozilla.org/attachment.cgi?id=171508&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> asking for review ...

superreview requested: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 171515] patch with more context
Jungshik Shin <jshin1987@gmail.com> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding https://bugzilla.mozilla.org/show_bug.cgi?id=229548 Attachment 171515: patch with more context https://bugzilla.mozilla.org/attachment.cgi?id=171515&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> thanks for r and sorry for too little context. I was just too lazy to get rid of another patch nearby (for bug 24...

superreview requested: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 173054] patch that generates nsIURI
Jungshik Shin <jshin1987@gmail.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding https://bugzilla.mozilla.org/show_bug.cgi?id=229548 Attachment 173054: patch that generates nsIURI https://bugzilla.mozilla.org/attachment.cgi?id=173054&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> With standard-url.encode-utf8 set to true, this patch is not necessary for most uris (except for file url). However...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] Patch
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 201159: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> This fix this bug. aDocum...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #2
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #3
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ...

superreview cancelled: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 171508] patch
Jungshik Shin <jshin1987@gmail.com> has cancelled Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding https://bugzilla.mozilla.org/show_bug.cgi?id=229548 Attachment 171508: patch https://bugzilla.mozilla.org/attachment.cgi?id=171508&action=edit ...

superreview denied: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 171515] patch with more context
Darin Fisher <darin@meer.net> has denied Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding https://bugzilla.mozilla.org/show_bug.cgi?id=229548 Attachment 171515: patch with more context https://bugzilla.mozilla.org/attachment.cgi?id=171515&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> >Index: intl/uconv/src/nsTextToSubURI.cpp >+ nsCOMPtr<nsIURLParser> urlParser; >+ // shoul...

superreview cancelled: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 173054] patch that generates nsIURI
Jungshik Shin <jshin1987@gmail.com> has cancelled Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding https://bugzilla.mozilla.org/show_bug.cgi?id=229548 Attachment 173054: patch that generates nsIURI https://bugzilla.mozilla.org/attachment.cgi?id=173054&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> Phew... This patch creates an infinite loop for 'javascript:.....' url (I hadn'...

superreview requested: [Bug 244754] URL is not shown in the status bar when I point at a link on a page encoded as 8-bit Unicode : [Attachment 173138] patch
Jungshik Shin <jshin1987@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 244754: URL is not shown in the status bar when I point at a link on a page encoded as 8-bit Unicode https://bugzilla.mozilla.org/show_bug.cgi?id=244754 Attachment 173138: patch https://bugzilla.mozilla.org/attachment.cgi?id=173138&action=edit ...

superreview requested: [Bug 278161] make file URLs always be in (escaped) UTF-8 regardless of the file system encoding : [Attachment 178951] patch
Jungshik Shin <jshin1987@gmail.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 278161: make file URLs always be in (escaped) UTF-8 regardless of the file system encoding https://bugzilla.mozilla.org/show_bug.cgi?id=278161 Attachment 178951: patch https://bugzilla.mozilla.org/attachment.cgi?id=178951&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> Asking for review. ...

superreview cancelled: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] Patch
Christian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 201159: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit ------- Additional Comments from Christian Biesinger (:bi) (reviews slower than usual) &l...