superreview requested: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control r
Mark Mentovai <mark@moxienet.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> By the time the validate happens, it's too late for us to really care. Might as well leave the rect alone, so the system can paint. Simon thinks that validating is a relic from the days of native form controls.
|
0 |
|
bugzilla
7/20/2005 4:15:30 AM
netscape.mozilla.reviewers
29156 articles. 
0 followers.
0 Replies
1068 Views
Similar Artilces:
superreview granted: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control rec
Simon Fraser <sfraser_bugs@smfr.org> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ...
superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
Asaf Romano <bugs.mano@mail-central.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from Asaf Romano <bugs.mano@mail-central.com> requesting r/sr for your patch. ...
superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank l
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Same as the Firefox imple...
superreview denied: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
jag (Peter Annema) <jag@tty.nl> has denied Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Erh, you shouldn't have to check the autohide pref, if that is set to true, with onl...
superreview requested: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content area
Simon B�nzli <zeniko@gmail.com> has asked Aaron Leventhal <aaronleventhal@moonset.net> for superreview: Bug 342432: After Undo Close Tab, content area of newly-opened page isn't focused https://bugzilla.mozilla.org/show_bug.cgi?id=342432 Attachment 236968: always focus the reopened tab's content area https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit ------- Additional Comments from Simon B�nzli <zeniko@gmail.com> Like this? ...
superreview granted: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank las
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This will cause me dataloss, because I...
superreview requested: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way
Seth Spitzer [:ss] <sspitzer@mozilla.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 342105: Close button not shown if there is only one tab https://bugzilla.mozilla.org/show_bug.cgi?id=342105 Attachment 229158: don't treat a single tab in a special way https://bugzilla.mozilla.org/attachment.cgi?id=229158&action=edit ------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com> r=sspitzer, seeking sr= from mconnor. ...
superreview requested: [Bug 243379] mozilla hangs when doing Shift+Tab over an input field : [Attachment 149381] Don't mess with focus changes done by the page when tabbing around.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 243379: mozilla hangs when doing Shift+Tab over an input field http://bugzilla.mozilla.org/show_bug.cgi?id=243379 Attachment 149381: Don't mess with focus changes done by the page when tabbing around. http://bugzilla.mozilla.org/attachment.cgi?id=149381&action=edit ...
superreview cancelled: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content area
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Simon B�nzli <zeniko@gmail.com>'s request for superreview: Bug 342432: After Undo Close Tab, content area of newly-opened page isn't focused https://bugzilla.mozilla.org/show_bug.cgi?id=342432 Attachment 236968: always focus the reopened tab's content area https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> I can't do superreviews and anyway you don't need them for chrome. You need a toolkit...
superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> If you show the tab bar: Ctrl+F4 => close tab ...
superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...
superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224127] revised patch, with two additional changes per gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224127: revised patch, with two additional changes per gavin https://bugzilla.mozilla.org/attachment.cgi?id=224127&action=edit ...
superreview requested: [Bug 193011] Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 : [Attachment 129377] Updated patch for review
Randell Jesup <rjesup@wgate.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 193011: Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 http://bugzilla.mozilla.org/show_bug.cgi?id=193011 Attachment 129377: Updated patch for review http://bugzilla.mozilla.org/attachment.cgi?id=129377&action=edit ...
superreview requested: [Bug 285445] bottom of vertical scroll bar is cut when opening a second tab (new tab causes tab bar to shift page down) : [Attachment 190893] patch
David Baron <dbaron@mozillafoundation.org> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 285445: bottom of vertical scroll bar is cut when opening a second tab (new tab causes tab bar to shift page down) https://bugzilla.mozilla.org/show_bug.cgi?id=285445 Attachment 190893: patch https://bugzilla.mozilla.org/attachment.cgi?id=190893&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> This assumes that an UpdateView call on the root view of the viewmanager or any of its ancestors subsumes ...
Simon Fraser <sfraser_bugs@smfr.org> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ...
superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
Asaf Romano <bugs.mano@mail-central.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from Asaf Romano <bugs.mano@mail-central.com> requesting r/sr for your patch. ...
superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank l
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Same as the Firefox imple...
superreview denied: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
jag (Peter Annema) <jag@tty.nl> has denied Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Erh, you shouldn't have to check the autohide pref, if that is set to true, with onl...
superreview requested: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content area
Simon B�nzli <zeniko@gmail.com> has asked Aaron Leventhal <aaronleventhal@moonset.net> for superreview: Bug 342432: After Undo Close Tab, content area of newly-opened page isn't focused https://bugzilla.mozilla.org/show_bug.cgi?id=342432 Attachment 236968: always focus the reopened tab's content area https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit ------- Additional Comments from Simon B�nzli <zeniko@gmail.com> Like this? ...
superreview granted: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank las
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This will cause me dataloss, because I...
superreview requested: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way
Seth Spitzer [:ss] <sspitzer@mozilla.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 342105: Close button not shown if there is only one tab https://bugzilla.mozilla.org/show_bug.cgi?id=342105 Attachment 229158: don't treat a single tab in a special way https://bugzilla.mozilla.org/attachment.cgi?id=229158&action=edit ------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com> r=sspitzer, seeking sr= from mconnor. ...
superreview requested: [Bug 243379] mozilla hangs when doing Shift+Tab over an input field : [Attachment 149381] Don't mess with focus changes done by the page when tabbing around.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 243379: mozilla hangs when doing Shift+Tab over an input field http://bugzilla.mozilla.org/show_bug.cgi?id=243379 Attachment 149381: Don't mess with focus changes done by the page when tabbing around. http://bugzilla.mozilla.org/attachment.cgi?id=149381&action=edit ...
superreview cancelled: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content area
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Simon B�nzli <zeniko@gmail.com>'s request for superreview: Bug 342432: After Undo Close Tab, content area of newly-opened page isn't focused https://bugzilla.mozilla.org/show_bug.cgi?id=342432 Attachment 236968: always focus the reopened tab's content area https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> I can't do superreviews and anyway you don't need them for chrome. You need a toolkit...
superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> If you show the tab bar: Ctrl+F4 => close tab ...
superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...
superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224127] revised patch, with two additional changes per gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224127: revised patch, with two additional changes per gavin https://bugzilla.mozilla.org/attachment.cgi?id=224127&action=edit ...
superreview requested: [Bug 193011] Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 : [Attachment 129377] Updated patch for review
Randell Jesup <rjesup@wgate.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 193011: Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 http://bugzilla.mozilla.org/show_bug.cgi?id=193011 Attachment 129377: Updated patch for review http://bugzilla.mozilla.org/attachment.cgi?id=129377&action=edit ...
superreview requested: [Bug 285445] bottom of vertical scroll bar is cut when opening a second tab (new tab causes tab bar to shift page down) : [Attachment 190893] patch
David Baron <dbaron@mozillafoundation.org> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 285445: bottom of vertical scroll bar is cut when opening a second tab (new tab causes tab bar to shift page down) https://bugzilla.mozilla.org/show_bug.cgi?id=285445 Attachment 190893: patch https://bugzilla.mozilla.org/attachment.cgi?id=190893&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> This assumes that an UpdateView call on the root view of the viewmanager or any of its ancestors subsumes ...
Web resources about - superreview requested: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control r - netscape.mozilla.reviewers Biz & Finance Magazines
Australian magazine subscriptions price comparison.
Australian magazine subscriptions price comparison.
Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...
Resources last updated: 12/3/2015 3:17:15 PM