superreview granted: [Bug 285445] bottom of vertical scroll bar is cut when opening a second tab (new tab causes tab bar to shift page down) : [Attachment 190893] patchRobert O'Callahan (Novell) <roc@ocallahan.org> has granted David Baron
<dbaron@mozillafoundation.org>'s request for superreview:
Bug 285445: bottom of vertical scroll bar is cut when opening a second tab (new
tab causes tab bar to shift page down)
https://bugzilla.mozilla.org/show_bug.cgi?id=285445
Attachment 190893: patch
https://bugzilla.mozilla.org/attachment.cgi?id=190893&action=edit
------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org>
that is correct.
...
superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patchChris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked
neil@parkwaycc.co.uk <neil@httl.net> for superreview:
Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab
bar when only one tab is open"] pref is ignored)
https://bugzilla.mozilla.org/show_bug.cgi?id=351289
Attachment 236765: patch
https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit
------- Additional Comments from Chris Thomas (CTho) [formerly
cst@andrew.cmu.edu] <cst@yecc.com>
If you show the tab bar:
Ctrl+F4 => close tab
...
superreview requested: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 167118] Patch v0.1aIan Neal <bugzilla@arlen.demon.co.uk> has asked jag (Peter Annema) <jag@tty.nl>
for superreview:
Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows
https://bugzilla.mozilla.org/show_bug.cgi?id=143866
Attachment 167118: Patch v0.1a - tidier patch to show tabstrip only when more
than one tab is open with toolbar=no
https://bugzilla.mozilla.org/attachment.cgi?id=167118&action=edit
...
superreview requested: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control rMark Mentovai <mark@moxienet.com> has asked Simon Fraser
<sfraser_bugs@smfr.org> for superreview:
Bug 300095: regression: Tab close button draws over top of scroll bar of first
tab after closing second tab, when page has focus
https://bugzilla.mozilla.org/show_bug.cgi?id=300095
Attachment 189863: Don't validate control rects
https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit
------- Additional Comments from Mark Mentovai <mark@moxienet.com>
By the time the validate happens, it's too late for us to really care. Might
as well leave the re...
superreview requested: [Bug 297155] opening a new tab while loading first page in new window breaks throbber / status bar : [Attachment 186923] Tabbed mode with cleanupneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked jag (Peter
Annema) <jag@tty.nl> for superreview:
Bug 297155: opening a new tab while loading first page in new window breaks
throbber / status bar
https://bugzilla.mozilla.org/show_bug.cgi?id=297155
Attachment 186923: Tabbed mode with cleanup
https://bugzilla.mozilla.org/attachment.cgi?id=186923&action=edit
...
superreview requested: [Bug 297155] opening a new tab while loading first page in new window breaks throbber / status bar : [Attachment 186479] Does forcing tabbed mode hurt perf?neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked jag (Peter
Annema) <jag@tty.nl> for superreview:
Bug 297155: opening a new tab while loading first page in new window breaks
throbber / status bar
https://bugzilla.mozilla.org/show_bug.cgi?id=297155
Attachment 186479: Does forcing tabbed mode hurt perf?
https://bugzilla.mozilla.org/attachment.cgi?id=186479&action=edit
...
superreview denied: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patchneil@parkwaycc.co.uk <neil@httl.net> has denied Chris Thomas (CTho) [formerly
cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview:
Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab
bar when only one tab is open"] pref is ignored)
https://bugzilla.mozilla.org/show_bug.cgi?id=351289
Attachment 236765: patch
https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
1. You shouldn't early return, you should reverse your conditi...
superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank lChris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked
neil@parkwaycc.co.uk <neil@httl.net> for superreview:
Bug 156082: Don't hide the tab bar when clicking the close box (pref for
showing single tab ["Hide tab bar when only one tab is open"] is ignored)
https://bugzilla.mozilla.org/show_bug.cgi?id=156082
Attachment 233414: blank last tab
https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit
------- Additional Comments from Chris Thomas (CTho) [formerly
cst@andrew.cmu.edu] <cst@yecc.com>
Same as the Firefox imple...
superreview cancelled: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 167118] Patch v0.1aIan Neal <bugzilla@arlen.demon.co.uk> has cancelled Ian Neal
<bugzilla@arlen.demon.co.uk>'s request for superreview:
Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows
https://bugzilla.mozilla.org/show_bug.cgi?id=143866
Attachment 167118: Patch v0.1a - tidier patch to show tabstrip only when more
than one tab is open with toolbar=no
https://bugzilla.mozilla.org/attachment.cgi?id=167118&action=edit
...
superreview requested: [Bug 343098] Single Window Mode and Tab Bar should be capitalized in Tabs preference page : [Attachment 227977] New Tabs.nibSmokey Ardisson (gone-ish) <alqahira@mindspring.com> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 343098: Single Window Mode and Tab Bar should be capitalized in Tabs
preference page
https://bugzilla.mozilla.org/show_bug.cgi?id=343098
Attachment 227977: New Tabs.nib
https://bugzilla.mozilla.org/attachment.cgi?id=227977&action=edit
------- Additional Comments from Smokey Ardisson (gone-ish)
<alqahira@mindspring.com>
r=me
Mike, just more nib consistency fixes here.
...
superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is untickedAsaf Romano <bugs.mano@mail-central.com> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 156082: Don't hide the tab bar when clicking the close box
https://bugzilla.mozilla.org/show_bug.cgi?id=156082
Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab
Bar" option is unticked
https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit
------- Additional Comments from Asaf Romano <bugs.mano@mail-central.com>
requesting r/sr for your patch.
...
superreview requested: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 188996] no autohide var patch v0.1gIan Neal <bugzilla@arlen.demon.co.uk> has asked jag (Peter Annema) <jag@tty.nl>
for superreview:
Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows
https://bugzilla.mozilla.org/show_bug.cgi?id=143866
Attachment 188996: no autohide var patch v0.1g
https://bugzilla.mozilla.org/attachment.cgi?id=188996&action=edit
------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk>
Changes since v0.1f
* Removed autohide var completely as not really needed
Carrying forward r= and requesting sr=
...
superreview granted: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control recSimon Fraser <sfraser_bugs@smfr.org> has granted Mark Mentovai
<mark@moxienet.com>'s request for superreview:
Bug 300095: regression: Tab close button draws over top of scroll bar of first
tab after closing second tab, when page has focus
https://bugzilla.mozilla.org/show_bug.cgi?id=300095
Attachment 189863: Don't validate control rects
https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit
...
superreview granted: [Bug 297155] opening a new tab while loading first page in new window breaks throbber / status bar : [Attachment 186923] Tabbed mode with cleanupjag (Peter Annema) <jag@tty.nl> has granted neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview:
Bug 297155: opening a new tab while loading first page in new window breaks
throbber / status bar
https://bugzilla.mozilla.org/show_bug.cgi?id=297155
Attachment 186923: Tabbed mode with cleanup
https://bugzilla.mozilla.org/attachment.cgi?id=186923&action=edit
------- Additional Comments from jag (Peter Annema) <jag@tty.nl>
>Index: tabbrowser.xml
>===================================================================
>@@...