superreview granted: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patchBoris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi)
<cbiesinger@gmx.at>'s request for superreview:
Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the
link itself displays file size on download (FTP)
https://bugzilla.mozilla.org/show_bug.cgi?id=284276
Attachment 177385: patch
https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
Seems reasonable
...
superreview requested: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1Edward Lee (Mardak) <edilee@gmail.com> has asked Christian :Biesinger
<cbiesinger@gmx.at> for superreview:
Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't
show completion
https://bugzilla.mozilla.org/show_bug.cgi?id=418961
Attachment 305432: v1
https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit
------- Additional Comments from Edward Lee (Mardak) <edilee@gmail.com>
Similar to what we needed to do for exthandler.. set the NETWORK bit. All
places in webbrowserpersist that have a STATE_START ...
superreview granted: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak)
<edilee@gmail.com>'s request for superreview:
Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't
show completion
https://bugzilla.mozilla.org/show_bug.cgi?id=418961
Attachment 305432: v1
https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit
...
superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] PatchMasayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 201159: Patch rv1.0
https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit
------- Additional Comments from Masayuki Nakano (Mozilla Japan)
<masayuki@d-toybox.com>
This fix this bug.
aDocum...
superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #3Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206229: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit
...
superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #2Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked for
superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206229: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit
...
superreview requested: [Bug 342321] nsIncrementalDownload doesn't create 0-sized file when downloading a 0-sized file : [Attachment 226514] Always create/truncate the dest. file during the channel's oJeff Walden (remove +bmo to email) <jwalden+bmo@mit.edu> has asked Darin Fisher
(Google) <darin@meer.net> for superreview:
Bug 342321: nsIncrementalDownload doesn't create 0-sized file when downloading
a 0-sized file
https://bugzilla.mozilla.org/show_bug.cgi?id=342321
Attachment 226514: Always create/truncate the dest. file during the channel's
onStartRequest
https://bugzilla.mozilla.org/attachment.cgi?id=226514&action=edit
...
superreview requested: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patchChristian Biesinger <cbiesinger@gmx.at> has asked Darin Fisher (IBM)
<darin@meer.net> for superreview:
Bug 241209: "Show File Location" and "Launch File" buttons (on download
progress dialog) don't work
http://bugzilla.mozilla.org/show_bug.cgi?id=241209
Attachment 147465: patch
http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit
...
superreview requested: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patchDavid Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc@ocallahan.org>
for superreview:
Bug 248606: "arrow" doesn't change to hand over links, links don't get bold
font-weight inside frame
http://bugzilla.mozilla.org/show_bug.cgi?id=248606
Attachment 151705: patch
http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit
------- Additional Comments from David Baron <dbaron@dbaron.org>
This patch separates the two coordinate transformations (so they're more like
they used to be before bug 20022), and restores the baseV...
superreview requested: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 176098] Simpler patchSimon Fraser <sfraser_bugs@smfr.org> has asked Darin Fisher <darin@meer.net>
for superreview:
Bug 281648: "Download Link Target" results in bad download for large MP3 file.
https://bugzilla.mozilla.org/show_bug.cgi?id=281648
Attachment 176098: Simpler patch
https://bugzilla.mozilla.org/attachment.cgi?id=176098&action=edit
...
superreview requested: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 176098] Simpler patch #2Josh Aas <joshmoz@gmail.com> has asked Mike Pinkerton <pinkerton@aol.net> for
superreview:
Bug 281648: "Download Link Target" results in bad download for large MP3 file.
https://bugzilla.mozilla.org/show_bug.cgi?id=281648
Attachment 176098: Simpler patch
https://bugzilla.mozilla.org/attachment.cgi?id=176098&action=edit
...
superreview cancelled: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] PatchChristian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> has
cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for
superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 201159: Patch rv1.0
https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit
------- Additional Comments from Christian Biesinger (:bi) (reviews slower than
usual) &l...
superreview requested: [Bug 217147] "View Saved Passwords..." window doesn't remember its size and position : [Attachment 131839] patch to fix bug 205176 as wellSteffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner
<bryner@brianryner.com> for superreview:
Bug 217147: "View Saved Passwords..." window doesn't remember its size and
position
http://bugzilla.mozilla.org/show_bug.cgi?id=217147
Attachment 131839: patch to fix bug 205176 as well
http://bugzilla.mozilla.org/attachment.cgi?id=131839&action=edit
------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de>
Brian, I just realized that you've got the full cvs blame for both files. Can
you review this please?
...
superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206517] Patch fMasayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted Masayuki
Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206517: Patch for check-in
https://bugzilla.mozilla.org/attachment.cgi?id=206517&action=edit
...