superreview requested: [Bug 280470] input type="image" .src property doesn't resolve relative URIs : [Attachment 173705] Patch

Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org>
for superreview:
Bug 280470: input type="image" .src property doesn't resolve relative URIs
https://bugzilla.mozilla.org/show_bug.cgi?id=280470

Attachment 173705: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=173705&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
This is the right thing, I think.
0
bugzilla
2/8/2005 4:54:33 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
563 Views

Similar Articles

[PageSpeed] 16

Reply:

Similar Artilces:

superreview granted: [Bug 280470] input type="image" .src property doesn't resolve relative URIs : [Attachment 173705] Patch
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 280470: input type="image" .src property doesn't resolve relative URIs https://bugzilla.mozilla.org/show_bug.cgi?id=280470 Attachment 173705: Patch https://bugzilla.mozilla.org/attachment.cgi?id=173705&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview requested: [Bug 219662] "OK" button doesn't activate in "Link Properties" dialog : [Attachment 236543] patch
Andrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 219662: "OK" button doesn't activate in "Link Properties" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=219662 Attachment 236543: patch https://bugzilla.mozilla.org/attachment.cgi?id=236543&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> The autocomplete part has worked because typing in the textbox to active autocomplete enables the button ...

superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Andrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ------- Additional Comments from Andrew Schultz <ajschult@mindspring.com> note that with bug 240929 and bug 236294 fixed, only the ErrorHandler part here is relevant. ...

superreview requested: [Bug 343599] "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> : [Attachment 228282] patch that doesn't work
Christian Biesinger (:bi) (CA) <cbiesinger@gmx.at> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 343599: "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> https://bugzilla.mozilla.org/show_bug.cgi?id=343599 Attachment 228282: patch that doesn't work https://bugzilla.mozilla.org/attachment.cgi?id=228282&action=edit ------- Additional Comments from Christian Biesinger (:bi) (CA) <cbiesinger@gmx.at> while this doesn't fix the bug, it's probably still a good thing to ...

superreview requested: [Bug 67873] [FILE]onchange for input type="file" doesn't behave correctly : [Attachment 141215] This fixes both testcases and the various tests I've tried with it
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 67873: [FILE]onchange for input type="file" doesn't behave correctly http://bugzilla.mozilla.org/show_bug.cgi?id=67873 Attachment 141215: This fixes both testcases and the various tests I've tried with it http://bugzilla.mozilla.org/attachment.cgi?id=141215&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> peterv, I choose you! ...

superreview granted: [Bug 307616] <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" : [Attachment 207080] patch
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu>'s request for superreview: Bug 307616: <input type="image"> with missing image gives "ASSERTION: Form control has a frame, but it's not a form frame" https://bugzilla.mozilla.org/show_bug.cgi?id=307616 Attachment 207080: patch https://bugzilla.mozilla.org/attachment.cgi?id=207080&action=edit ------- Additional Comments from Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> Yep...

superreview requested: [Bug 250198] "find as you type" doesn't work : [Attachment 152618] patch
Christian Biesinger <cbiesinger@gmx.at> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 250198: "find as you type" doesn't work http://bugzilla.mozilla.org/show_bug.cgi?id=250198 Attachment 152618: patch http://bugzilla.mozilla.org/attachment.cgi?id=152618&action=edit ...

superreview requested: [Bug 131106] Make 'default browser' shouldn't steal image file associations from image programs : [Attachment 139348] only take "default browser" types for Seamonkey/Firebird
Mike Connor <mconnor@myrealbox.com> has asked Ben Goodger (I don't read bugmail) <bugs@bengoodger.com> for superreview: Bug 131106: Make 'default browser' shouldn't steal image file associations from image programs http://bugzilla.mozilla.org/show_bug.cgi?id=131106 Attachment 139348: only take "default browser" types for Seamonkey/Firebird by default http://bugzilla.mozilla.org/attachment.cgi?id=139348&action=edit ------- Additional Comments from Mike Connor <mconnor@myrealbox.com> http://lxr.mozilla.org/mozilla/source/xpfe/componen...

superreview requested: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Simon Montagu <smontagu@smontagu.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Simon Montagu <smontagu@smontagu.org> This is a port of Neil's patch to xpfe in bug 252317. It had r=doron, sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit. ...

superreview denied: [Bug 219662] "OK" button doesn't activate in "Link Properties" dialog : [Attachment 236543] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 219662: "OK" button doesn't activate in "Link Properties" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=219662 Attachment 236543: patch https://bugzilla.mozilla.org/attachment.cgi?id=236543&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> > <textbox id="hrefInput" type="autocomplete" > searchSessions="history" timeout="50" m...

superreview requested: [Bug 206376] accesskey doesn't work when field type is "file" : [Attachment 150900] patch v2
Nian Liu <neo.liu@sun.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 206376: accesskey doesn't work when field type is "file" http://bugzilla.mozilla.org/show_bug.cgi?id=206376 Attachment 150900: patch v2 http://bugzilla.mozilla.org/attachment.cgi?id=150900&action=edit ...

superreview requested: [Bug 206376] accesskey doesn't work when field type is "file" : [Attachment 150902] final patch
Nian Liu <neo.liu@sun.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 206376: accesskey doesn't work when field type is "file" http://bugzilla.mozilla.org/show_bug.cgi?id=206376 Attachment 150902: final patch http://bugzilla.mozilla.org/attachment.cgi?id=150902&action=edit ...