superreview requested: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] Patch

Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback
<jst@mozilla.jstenback.com> for superreview:
Bug 279495: A link with an URL and additional javascript open shows a popup and
an unwanted new window [link with TARGET and onClick=window.open]
https://bugzilla.mozilla.org/show_bug.cgi?id=279495

Attachment 172585: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=172585&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
This basically backs out the "fix" for bug 135811.  Now I can't figure out how
finding targets outside our window for subframes _ever_ worked after the fix
for that bug.... jst, any idea?

In any case, what happens is that the subframe asks its parent to look, the
parent doesn't find the target amongst its kids, but has the same tree owner as
aRequestor (the kid), so doesn't ask the treeowner either.  So the named target
is never found.  Before the patch for bug 103638, we had basically the same
code here, which is why I don't understand how it worked... :(	I'd really like
to, if someone can explain it to me.

In any case, this patch also adds code to our treeowners to ensure the
invariant that the treeowner is the requestor only for calls to the root
docshell of type. This should make sure bug 135811 does not reappear.

I didn't change nsDocShellTreeOwner.cpp because I'm still trying to figure out
how that one works, exactly.  It'll probably be the subject of bug 278916.
0
bugzilla
1/27/2005 7:16:10 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
1235 Views

Similar Articles

[PageSpeed] 11
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] Patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 279495: A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] https://bugzilla.mozilla.org/show_bug.cgi?id=279495 Attachment 172585: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172585&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> Ugh, I can't explain how this worked... not w/o digging through old code I ...

superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

superreview granted: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

superreview requested: [Bug 310395] Open Link in New Window
froodiantherapy (mostly gone until June 4) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 223629: Last Patch before sr? https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit ------- Additional Comments from froodiantherapy (mostly gone until June 4) <stridey@gmail.com> Assuming that this has cl+ too. ;) ...

superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177878] Patch to make externally-launched links open in new tab (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177878: Patch to make externally-launched links open in new tab (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177878&action=edit ...

superreview requested: [Bug 174266] links opening blank new window but content showing in current window if browser.block.target_new_window : [Attachment 152987] Proposed patch
Boris Zbarsky <bzbarsky@mit.edu> has asked for superreview: Bug 174266: links opening blank new window but content showing in current window if browser.block.target_new_window http://bugzilla.mozilla.org/show_bug.cgi?id=174266 Attachment 152987: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=152987&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> jst, would you sr? ...

superreview requested: [Bug 174266] links opening blank new window but content showing in current window if browser.block.target_new_window : [Attachment 152987] Proposed patch #2
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 174266: links opening blank new window but content showing in current window if browser.block.target_new_window http://bugzilla.mozilla.org/show_bug.cgi?id=174266 Attachment 152987: Proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=152987&action=edit ...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 159443] optional addition to divert window.open to a new tab
Dan M <danm.moz@gmail.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 159443: optional addition to divert window.open to a new tab https://bugzilla.mozilla.org/attachment.cgi?id=159443&action=edit ...

superreview requested: [Bug 310395] Open Link in New Window
froodiantherapy <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 227974: Unbitrots it https://bugzilla.mozilla.org/attachment.cgi?id=227974&action=edit ------- Additional Comments from froodiantherapy <stridey@gmail.com> This patch unbitrots the previous one. It touches all the high-traffic files, and took a long time to get back up to date, so lets try to get this review...

superreview cancelled: [Bug 310395] Open Link in New Window
froodiantherapy <stridey@gmail.com> has cancelled froodiantherapy <stridey@gmail.com>'s request for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 223629: Last Patch before sr? https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit ------- Additional Comments from froodiantherapy <stridey@gmail.com> This patch unbitrots the previous one. It touches all the high-traffic files, and took a long time to get back up to date, so let...

superreview cancelled: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177878] Patch to make externally-launched links open in new tab (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has cancelled Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177878: Patch to make externally-launched links open in new tab (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177878&action=edit ...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 158459] base code to control where external links are opened
Dan M <danm.moz@gmail.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) http://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 158459: base code to control where external links are opened http://bugzilla.mozilla.org/attachment.cgi?id=158459&action=edit ...

superreview requested: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 241641] tested patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 355657: window.open()ed links fail in a new tab, same window https://bugzilla.mozilla.org/show_bug.cgi?id=355657 Attachment 241641: tested patch https://bugzilla.mozilla.org/attachment.cgi?id=241641&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Neil seemed to think this might be a better way to do it. This works, and does reasonable things even after undoing the cl...

superreview requested: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 241578] untested patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 355657: window.open()ed links fail in a new tab, same window https://bugzilla.mozilla.org/show_bug.cgi?id=355657 Attachment 241578: untested patch https://bugzilla.mozilla.org/attachment.cgi?id=241578&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Can't test this. tabbrowser.xml changes don't get picked up in my build. ...

Web resources about - superreview requested: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] Patch - netscape.mozilla.reviewers

Resources last updated: 11/21/2015 6:05:33 AM