superreview granted: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the selneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron
Leventhal <aaronleventhal@moonset.net>'s request for superreview:
Bug 269318: TAB doesn't start from selection text after mouse click
https://bugzilla.mozilla.org/show_bug.cgi?id=269318
Attachment 166255: If element gets focused, move selection to focus if focus
isn't already inside the selection. mLastFocusedWith is no longer needed for
making tab not move relative to selection after a mouse click
https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit
------- Addition...
superreview requested: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content areaSimon B�nzli <zeniko@gmail.com> has asked Aaron Leventhal
<aaronleventhal@moonset.net> for superreview:
Bug 342432: After Undo Close Tab, content area of newly-opened page isn't
focused
https://bugzilla.mozilla.org/show_bug.cgi?id=342432
Attachment 236968: always focus the reopened tab's content area
https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit
------- Additional Comments from Simon B�nzli <zeniko@gmail.com>
Like this?
...
superreview cancelled: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content areaAaron Leventhal <aaronleventhal@moonset.net> has cancelled Simon B�nzli
<zeniko@gmail.com>'s request for superreview:
Bug 342432: After Undo Close Tab, content area of newly-opened page isn't
focused
https://bugzilla.mozilla.org/show_bug.cgi?id=342432
Attachment 236968: always focus the reopened tab's content area
https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit
------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net>
I can't do superreviews and anyway you don't need them for chrome. You need a
toolkit...
superreview requested: [Bug 244761] Pressing Esc while on <select> that's not dropped down shouldn't change which option is selected : [Attachment 149525] Work around focus issueneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Richard
Suitor <rsuitor@acm.org> for superreview:
Bug 244761: Pressing Esc while on <select> that's not dropped down shouldn't
change which option is selected
http://bugzilla.mozilla.org/show_bug.cgi?id=244761
Attachment 149525: Work around focus issue
http://bugzilla.mozilla.org/attachment.cgi?id=149525&action=edit
...
superreview requested: [Bug 252984] Cannot type in any of the fieldsAaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 252984: Cannot type in any of the fields - forms don't get focus on
left-click
http://bugzilla.mozilla.org/show_bug.cgi?id=252984
Attachment 154483: We actually don't need either nsIFrame::FocusableAncestor()
or nsGenericHTMLElement::HandleDOMEvent() anymore
http://bugzilla.mozilla.org/attachment.cgi?id=154483&action=edit
...
superreview requested: [Bug 390178] Can't focus elements within panel popup with the mouse if noautohide attribute is set to true : [Attachment 313421] This seems to work. Don't activate anything whenNeil Deakin <enndeakin@gmail.com> has asked Robert O'Callahan (:roc) (reduced
activity March 18 to April 9) <roc@ocallahan.org> for superreview:
Bug 390178: Can't focus elements within panel popup with the mouse if
noautohide attribute is set to true
https://bugzilla.mozilla.org/show_bug.cgi?id=390178
Attachment 313421: This seems to work. Don't activate anything when clicking
with the mouse
https://bugzilla.mozilla.org/attachment.cgi?id=313421&action=edit
...
superreview requested: [Bug 421810] Tab can't move focus back to webcontent after focus is in browser chrome : [Attachment 308623] seems that the tabfocusmodel should only be checked for controlsNeil Deakin <enndeakin@gmail.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 421810: Tab can't move focus back to webcontent after focus is in browser
chrome
https://bugzilla.mozilla.org/show_bug.cgi?id=421810
Attachment 308623: seems that the tabfocusmodel should only be checked for
controls
https://bugzilla.mozilla.org/attachment.cgi?id=308623&action=edit
------- Additional Comments from Neil Deakin <enndeakin@gmail.com>
Otherwise, <browser> can't receive the focus.
Let's get this fix in and I'll see if I ca...
superreview requested: [Bug 283703] Focus events not being fired for radio buttons : [Attachment 175603] Fix regression. Send focus events to selected item, but don't do it for menulist which is handAaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 283703: Focus events not being fired for radio buttons
https://bugzilla.mozilla.org/show_bug.cgi?id=283703
Attachment 175603: Fix regression. Send focus events to selected item, but
don't do it for menulist which is handled separately.
https://bugzilla.mozilla.org/attachment.cgi?id=175603&action=edit
...
superreview granted: [Bug 250169] <textarea>s have a focus rectangle now : [Attachment 152513] Remember to include textarea in css rule for what doesn't get focus outlineMike Shaver <shaver@mozilla.org> has granted Mike Shaver <shaver@mozilla.org>'s
request for superreview:
Bug 250169: <textarea>s have a focus rectangle now
http://bugzilla.mozilla.org/show_bug.cgi?id=250169
Attachment 152513: Remember to include textarea in css rule for what doesn't
get focus outline
http://bugzilla.mozilla.org/attachment.cgi?id=152513&action=edit
------- Additional Comments from Mike Shaver <shaver@mozilla.org>
r+sr=shaver on trivial regression fix. Requesting 1.8a2 approval.
...
superreview requested: [Bug 261715] Alt+click sometimes focuses menubar (keyrepeated Alt shouldn't trigger menubar focusing behavior) : [Attachment 169403] 1) set flag when mouse activity occurs and Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 261715: Alt+click sometimes focuses menubar (keyrepeated Alt shouldn't
trigger menubar focusing behavior)
https://bugzilla.mozilla.org/show_bug.cgi?id=261715
Attachment 169403: 1) set flag when mouse activity occurs and alt is pressed,
2) don't let another alt key press clear that flag, 3) check the flag before
activating the menu.
https://bugzilla.mozilla.org/attachment.cgi?id=169403&action=edit
...
superreview granted: [Bug 120148] Tabs don't remember which element [frame, textfield, etc] was focused when switching tabs : [Attachment 132485] Remember where focus is when switching tabs (updatedBrian Ryner <bryner@brianryner.com> has granted hn <tryandguessit@yahoo.com>'s
request for superreview:
Bug 120148: Tabs don't remember which element [frame, textfield, etc] was
focused when switching tabs
http://bugzilla.mozilla.org/show_bug.cgi?id=120148
Attachment 132485: Remember where focus is when switching tabs (updated)
http://bugzilla.mozilla.org/attachment.cgi?id=132485&action=edit
...
superreview requested: [Bug 214843] Space doesn't scroll when link's child has focus : [Attachment 147204] patch for 214843Nian Liu <neo.liu@sun.com> has asked Johnny Stenback
<jst@mozilla.jstenback.com> for superreview:
Bug 214843: Space doesn't scroll when link's child has focus
http://bugzilla.mozilla.org/show_bug.cgi?id=214843
Attachment 147204: patch for 214843
http://bugzilla.mozilla.org/attachment.cgi?id=147204&action=edit
...
superreview requested: [Bug 224251] Bookmarks panel doesn't focus bookmarks tree when selected : [Attachment 134537] Proposed patchneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Alec Flett
<alecf@flett.org> for superreview:
Bug 224251: Bookmarks panel doesn't focus bookmarks tree when selected
http://bugzilla.mozilla.org/show_bug.cgi?id=224251
Attachment 134537: Proposed patch
http://bugzilla.mozilla.org/attachment.cgi?id=134537&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
pch, I don't think that this is dependent, because bug 50223 already works for
the history sidebar.
...
superreview granted: [Bug 252984] Cannot type in any of the fieldsBoris Zbarsky <bzbarsky@mit.edu> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 252984: Cannot type in any of the fields - forms don't get focus on
left-click
http://bugzilla.mozilla.org/show_bug.cgi?id=252984
Attachment 154483: We actually don't need either nsIFrame::FocusableAncestor()
or nsGenericHTMLElement::HandleDOMEvent() anymore
http://bugzilla.mozilla.org/attachment.cgi?id=154483&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
If things still work right and someone who...