superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 264442: plugin finder can't find anything for windows media.
https://bugzilla.mozilla.org/show_bug.cgi?id=264442
Attachment 162212: Don't assume we don't have a plugin before getting a
responce from the network.
https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
r+sr=bzbarsky, I guess..
Is ther a reason mIsBrokenPlugin is write-only?
...
superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #3Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 312788: Crash exposing invisible plugins
https://bugzilla.mozilla.org/show_bug.cgi?id=312788
Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at
it, make absolutely sure we don't ever try to create children for native
accessibles (make native accessibles inherit from the leaf class)
https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit
...
superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #2Aaron Leventhal (vacation: mostly gone until Oct 17)
<aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for
superreview:
Bug 312788: Crash exposing invisible plugins
https://bugzilla.mozilla.org/show_bug.cgi?id=312788
Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at
it, make absolutely sure we don't ever try to create children for native
accessibles (make native accessibles inherit from the leaf class)
https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit
...
superreview granted: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to creBrian Ryner <bryner@brianryner.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 312788: Crash exposing invisible plugins
https://bugzilla.mozilla.org/show_bug.cgi?id=312788
Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at
it, make absolutely sure we don't ever try to create children for native
accessibles (make native accessibles inherit from the leaf class)
https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit
...
superreview requested: [Bug 451234] don't stop plugins from loading just because they don't have a resource file : [Attachment 334535] fix v1.0Josh Aas <joshmoz@gmail.com> has asked Robert O'Callahan (:roc) (Mozilla
Corporation) <roc@ocallahan.org> for superreview:
Bug 451234: don't stop plugins from loading just because they don't have a
resource file
https://bugzilla.mozilla.org/show_bug.cgi?id=451234
Attachment 334535: fix v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=334535&action=edit
...
superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string ifJohnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich
<brendan@mozilla.org> for superreview:
Bug 245619: Don't bother converting result of scripts into a string when the
caller doesn't care about the value.
http://bugzilla.mozilla.org/show_bug.cgi?id=245619
Attachment 150056: Don't convert the result to a string if the caller doesn't
care about the return value.
http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit
...
superreview requested: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sensetimeless@myrealbox.com <timeless@bemail.org> has asked Johnny Stenback
<jst@netscape.com> for superreview:
Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in
GlobalWindowImpl::Unescape
http://bugzilla.mozilla.org/show_bug.cgi?id=217896
Attachment 130691: don't do silly things that don't make sense
http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit
...
superreview requested: [Bug 284364] Plugins don't work in window where midas has been enabled. : [Attachment 175986] Turn on plugins when we're done editing.Johnny Stenback <jst@mozilla.org> has asked Boris Zbarsky <bzbarsky@mit.edu>
for superreview:
Bug 284364: Plugins don't work in window where midas has been enabled.
https://bugzilla.mozilla.org/show_bug.cgi?id=284364
Attachment 175986: Turn on plugins when we're done editing.
https://bugzilla.mozilla.org/attachment.cgi?id=175986&action=edit
...
superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nondRobert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview:
Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title
in defs
https://bugzilla.mozilla.org/show_bug.cgi?id=340083
Attachment 224205: don't create frames for content we don't handle, don't
invalidate nondisplay content
https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit
...
superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if tBrendan Eich <brendan@mozilla.org> has granted Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 245619: Don't bother converting result of scripts into a string when the
caller doesn't care about the value.
http://bugzilla.mozilla.org/show_bug.cgi?id=245619
Attachment 150056: Don't convert the result to a string if the caller doesn't
care about the return value.
http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit
------- Additional Comments from Brendan Eich <brendan@mozilla.org>
Duh, thanks. r+sr=me....
superreview requested: [Bug 359392] Very slow rendering of the top bar on mozilla.org : [Attachment 246745] Don't tile when we don't have toBoris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell)
<roc@ocallahan.org> for superreview:
Bug 359392: Very slow rendering of the top bar on mozilla.org
https://bugzilla.mozilla.org/show_bug.cgi?id=359392
Attachment 246745: Don't tile when we don't have to
https://bugzilla.mozilla.org/attachment.cgi?id=246745&action=edit
...
superreview granted: [Bug 451234] don't stop plugins from loading just because they don't have a resource file : [Attachment 334535] fix v1.0Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted
Josh Aas <joshmoz@gmail.com>'s request for superreview:
Bug 451234: don't stop plugins from loading just because they don't have a
resource file
https://bugzilla.mozilla.org/show_bug.cgi?id=451234
Attachment 334535: fix v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=334535&action=edit
...
superreview requested: [Bug 252984] Cannot type in any of the fieldsAaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 252984: Cannot type in any of the fields - forms don't get focus on
left-click
http://bugzilla.mozilla.org/show_bug.cgi?id=252984
Attachment 154483: We actually don't need either nsIFrame::FocusableAncestor()
or nsGenericHTMLElement::HandleDOMEvent() anymore
http://bugzilla.mozilla.org/attachment.cgi?id=154483&action=edit
...
superreview requested: [Bug 331614] window.open unnecessarily escapes all URLs (can't handle IDN/extended domain-names) : [Attachment 217983] don't escapeGavin Sharp <gavin.sharp@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 331614: window.open unnecessarily escapes all URLs (can't handle
IDN/extended domain-names)
https://bugzilla.mozilla.org/show_bug.cgi?id=331614
Attachment 217983: don't escape
https://bugzilla.mozilla.org/attachment.cgi?id=217983&action=edit
...