superreview granted: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 169230] v2 patchBoris Zbarsky <bzbarsky@mit.edu> has granted Darin Fisher (IBM)
<darin@meer.net>'s request for superreview:
Bug 261929: Consider sending urls in UTF-8 by default (images/links with
non-ASCII chacters not displayed)
https://bugzilla.mozilla.org/show_bug.cgi?id=261929
Attachment 169230: v2 patch
https://bugzilla.mozilla.org/attachment.cgi?id=169230&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
sr=bzbarsky
...
superreview requested: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 216631] resolved points of comment #42Masatoshi Kimura (emk) <VYV03354@nifty.ne.jp> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 261929: Consider sending urls in UTF-8 by default (images/links with
non-ASCII chacters not displayed)
https://bugzilla.mozilla.org/show_bug.cgi?id=261929
Attachment 216631: resolved points of comment #42
https://bugzilla.mozilla.org/attachment.cgi?id=216631&action=edit
------- Additional Comments from Masatoshi Kimura (emk) <VYV03354@nifty.ne.jp>
> what about mozilla code that unescapes URIs? like nsTextToSubURI.cpp? doesn't
> that ...
superreview granted: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 216631] resolved points of comment #42Darin Fisher (Google) <darin@meer.net> has granted Masatoshi Kimura (emk)
<VYV03354@nifty.ne.jp>'s request for superreview:
Bug 261929: Consider sending urls in UTF-8 by default (images/links with
non-ASCII chacters not displayed)
https://bugzilla.mozilla.org/show_bug.cgi?id=261929
Attachment 216631: resolved points of comment #42
https://bugzilla.mozilla.org/attachment.cgi?id=216631&action=edit
------- Additional Comments from Darin Fisher (Google) <darin@meer.net>
>Index: netwerk/base/src/nsStandardURL.cpp
> #define GET_SEGMENT_ENCODER(name) \
...
superreview granted: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 218073] resolved darin's commentMasatoshi Kimura (emk) <VYV03354@nifty.ne.jp> has granted superreview:
Bug 261929: Consider sending urls in UTF-8 by default (images/links with
non-ASCII chacters not displayed)
https://bugzilla.mozilla.org/show_bug.cgi?id=261929
Attachment 218073: resolved darin's comment
https://bugzilla.mozilla.org/attachment.cgi?id=218073&action=edit
------- Additional Comments from Masatoshi Kimura (emk) <VYV03354@nifty.ne.jp>
Thank you.
Carring over r+sr.
...
superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] PatchMasayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 201159: Patch rv1.0
https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit
------- Additional Comments from Masayuki Nakano (Mozilla Japan)
<masayuki@d-toybox.com>
This fix this bug.
aDocum...
superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #2Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked for
superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206229: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit
...
superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #3Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206229: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit
...
superreview requested: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 171508] patchJungshik Shin <jshin1987@gmail.com> has asked Darin Fisher (IBM)
<darin@meer.net> for superreview:
Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has
non-ASCII characters in non-UTF-8 encoding
https://bugzilla.mozilla.org/show_bug.cgi?id=229548
Attachment 171508: patch
https://bugzilla.mozilla.org/attachment.cgi?id=171508&action=edit
------- Additional Comments from Jungshik Shin <jshin1987@gmail.com>
asking for review
...
superreview requested: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 171515] patch with more contextJungshik Shin <jshin1987@gmail.com> has asked Darin Fisher (IBM)
<darin@meer.net> for superreview:
Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has
non-ASCII characters in non-UTF-8 encoding
https://bugzilla.mozilla.org/show_bug.cgi?id=229548
Attachment 171515: patch with more context
https://bugzilla.mozilla.org/attachment.cgi?id=171515&action=edit
------- Additional Comments from Jungshik Shin <jshin1987@gmail.com>
thanks for r and sorry for too little context. I was just too lazy to get rid
of another patch nearby (for bug 24...
superreview requested: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 173054] patch that generates nsIURIJungshik Shin <jshin1987@gmail.com> has asked Darin Fisher <darin@meer.net> for
superreview:
Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has
non-ASCII characters in non-UTF-8 encoding
https://bugzilla.mozilla.org/show_bug.cgi?id=229548
Attachment 173054: patch that generates nsIURI
https://bugzilla.mozilla.org/attachment.cgi?id=173054&action=edit
------- Additional Comments from Jungshik Shin <jshin1987@gmail.com>
With standard-url.encode-utf8 set to true, this patch is not necessary for most
uris (except for file url). However...
superreview cancelled: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] PatchChristian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> has
cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for
superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 201159: Patch rv1.0
https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit
------- Additional Comments from Christian Biesinger (:bi) (reviews slower than
usual) &l...
superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206517] Patch fMasayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted Masayuki
Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206517: Patch for check-in
https://bugzilla.mozilla.org/attachment.cgi?id=206517&action=edit
...
superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch rneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted Masayuki
Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206229: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com>
> v...
superreview cancelled: [Bug 229548] IDN: URL in status bar is displayed as garbage if the path part has non-ASCII characters in non-UTF-8 encoding : [Attachment 171508] patchJungshik Shin <jshin1987@gmail.com> has cancelled Jungshik Shin
<jshin1987@gmail.com>'s request for superreview:
Bug 229548: IDN: URL in status bar is displayed as garbage if the path part has
non-ASCII characters in non-UTF-8 encoding
https://bugzilla.mozilla.org/show_bug.cgi?id=229548
Attachment 171508: patch
https://bugzilla.mozilla.org/attachment.cgi?id=171508&action=edit
...