superreview cancelled: [Bug 251589] XUL tab focus indication should appear inside the tab : [Attachment 154022] Addresses some of Neil's comments. Questions on others.Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 251589: XUL tab focus indication should appear inside the tab
http://bugzilla.mozilla.org/show_bug.cgi?id=251589
Attachment 154022: Addresses some of Neil's comments. Questions on others.
http://bugzilla.mozilla.org/attachment.cgi?id=154022&action=edit
...
superreview requested: [Bug 251589] XUL tab focus indication should appear inside the tab : [Attachment 153312] Use hbox to surround tab's anonymous image and label, put outline on thatAaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 251589: XUL tab focus indication should appear inside the tab
http://bugzilla.mozilla.org/show_bug.cgi?id=251589
Attachment 153312: Use hbox to surround tab's anonymous image and label, put
outline on that
http://bugzilla.mozilla.org/attachment.cgi?id=153312&action=edit
------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net>
Will need similar patch for seamonkey.
...
superreview requested: [Bug 251589] XUL tab focus indication should appear inside the tab : [Attachment 154221] Patch with sdwalker's correctionsAaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 251589: XUL tab focus indication should appear inside the tab
http://bugzilla.mozilla.org/show_bug.cgi?id=251589
Attachment 154221: Patch with sdwalker's corrections
http://bugzilla.mozilla.org/attachment.cgi?id=154221&action=edit
------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net>
Carrying sdwalker's r= forward
...
superreview cancelled: [Bug 251589] XUL tab focus indication should appear inside the tab : [Attachment 153312] Use hbox to surround tab's anonymous image and label, put outline on thatMike Connor <mconnor@myrealbox.com> has cancelled Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 251589: XUL tab focus indication should appear inside the tab
http://bugzilla.mozilla.org/show_bug.cgi?id=251589
Attachment 153312: Use hbox to surround tab's anonymous image and label, put
outline on that
http://bugzilla.mozilla.org/attachment.cgi?id=153312&action=edit
------- Additional Comments from Mike Connor <mconnor@myrealbox.com>
r=me, no sr needed
...
superreview granted: [Bug 251589] XUL tab focus indication should appear inside the tab : [Attachment 154221] Patch with sdwalker's correctionsneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron
Leventhal <aaronleventhal@moonset.net>'s request for superreview:
Bug 251589: XUL tab focus indication should appear inside the tab
http://bugzilla.mozilla.org/show_bug.cgi?id=251589
Attachment 154221: Patch with sdwalker's corrections
http://bugzilla.mozilla.org/attachment.cgi?id=154221&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
sr=me if you ensure that someone has filed a bug to make linux tabs less ugly
in general....
superreview requested: [Bug 251589] XUL tab focus indication should appear inside the tab : [Attachment 153423] Same fix for SeamonkeyAaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 251589: XUL tab focus indication should appear inside the tab
http://bugzilla.mozilla.org/show_bug.cgi?id=251589
Attachment 153423: Same fix for Seamonkey
http://bugzilla.mozilla.org/attachment.cgi?id=153423&action=edit
...
superreview requested: [Bug 251589] XUL tab focus indication should appear inside the tab : [Attachment 154094] Removes min-widthAaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 251589: XUL tab focus indication should appear inside the tab
http://bugzilla.mozilla.org/show_bug.cgi?id=251589
Attachment 154094: Removes min-width
http://bugzilla.mozilla.org/attachment.cgi?id=154094&action=edit
...
superreview cancelled: [Bug 251589] XUL tab focus indication should appear inside the tab : [Attachment 153423] Same fix for Seamonkeyneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has cancelled Aaron
Leventhal <aaronleventhal@moonset.net>'s request for superreview:
Bug 251589: XUL tab focus indication should appear inside the tab
http://bugzilla.mozilla.org/show_bug.cgi?id=251589
Attachment 153423: Same fix for Seamonkey
http://bugzilla.mozilla.org/attachment.cgi?id=153423&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
You need class="box-inherit" and various xbl:inherits in case someone wants to
e.g. swap the...
superreview cancelled: [Bug 251589] XUL tab focus indication should appear inside the tab : [Attachment 154094] Removes min-widthAaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 251589: XUL tab focus indication should appear inside the tab
http://bugzilla.mozilla.org/show_bug.cgi?id=251589
Attachment 154094: Removes min-width
http://bugzilla.mozilla.org/attachment.cgi?id=154094&action=edit
...
superreview requested: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's commentsScott MacGregor <mscott@mozilla.org> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 231034: Tab doesn't scroll though address list
http://bugzilla.mozilla.org/show_bug.cgi?id=231034
Attachment 140245: updated patch with neil's comments
http://bugzilla.mozilla.org/attachment.cgi?id=140245&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
moving forward the r, requesting sr.
...
superreview requested: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the sAaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 269318: TAB doesn't start from selection text after mouse click
https://bugzilla.mozilla.org/show_bug.cgi?id=269318
Attachment 166255: If element gets focused, move selection to focus if focus
isn't already inside the selection. mLastFocusedWith is no longer needed for
making tab not move relative to selection after a mouse click
https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit
...
superreview requested: [Bug 136659] Use shading or color to differentiate the active tab more clearly from the other three tabs. : [Attachment 131460] Patch with Neil's commentsR.J. Keller <rlk@trfenv.com> has asked jag (Peter Annema) <jag@tty.nl> for
superreview:
Bug 136659: Use shading or color to differentiate the active tab more clearly
from the other three tabs.
http://bugzilla.mozilla.org/show_bug.cgi?id=136659
Attachment 131460: Patch with Neil's comments
http://bugzilla.mozilla.org/attachment.cgi?id=131460&action=edit
...
superreview requested: [Bug 229737] [RFE] Favicons for XUL error pages : [Attachment 193389] address Neil's comments, fix seamonkey's checkMike Connor <mconnor@steelgryphon.com> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 229737: [RFE] Favicons for XUL error pages
https://bugzilla.mozilla.org/show_bug.cgi?id=229737
Attachment 193389: address Neil's comments, fix seamonkey's check
https://bugzilla.mozilla.org/attachment.cgi?id=193389&action=edit
------- Additional Comments from Mike Connor <mconnor@steelgryphon.com>
this addresses all but the 256 color-safe issue, which is an edge case
...
superreview requested: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content areaSimon B�nzli <zeniko@gmail.com> has asked Aaron Leventhal
<aaronleventhal@moonset.net> for superreview:
Bug 342432: After Undo Close Tab, content area of newly-opened page isn't
focused
https://bugzilla.mozilla.org/show_bug.cgi?id=342432
Attachment 236968: always focus the reopened tab's content area
https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit
------- Additional Comments from Simon B�nzli <zeniko@gmail.com>
Like this?
...