superreview granted: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@dbaron.org>'s request for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> d'oh! I should have caught that. Leave the debug code in. ...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) : [Attachment 19
Florian QUEZE <f.qu@laposte.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=40838 Attachment 196055: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=196055&action=edit ...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) : [Attachment 20 #2
Florian Qu�ze <f.qu@queze.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=40838 Attachment 201286: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=201286&action=edit ------- Additional Comments from Florian Qu�ze <f.qu@queze.net> New patch following the idea "set the status bar text before the event is ...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) : [Attachment 20 #3
Florian Qu�ze <f.qu@queze.net> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=40838 Attachment 201286: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=201286&action=edit ...

superreview requested: [Bug 214463] "Get New Themes" doesn't have link appearance : [Attachment 128882] patch
Boris Zbarsky (on vacation until end of September) <bz-vacation@mit.edu> has asked rbs@maths.uq.edu.au for superreview: Bug 214463: "Get New Themes" doesn't have link appearance http://bugzilla.mozilla.org/show_bug.cgi?id=214463 Attachment 128882: patch http://bugzilla.mozilla.org/attachment.cgi?id=128882&action=edit ------- Additional Comments from Boris Zbarsky (on vacation until end of September) <bz-vacation@mit.edu> I won't be able to check this in after tonight, so if it gets reviews after that, someone please check it in. ...

superreview requested: [Bug 219662] "OK" button doesn't activate in "Link Properties" dialog : [Attachment 236543] patch
Andrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 219662: "OK" button doesn't activate in "Link Properties" dialog https://bugzilla.mozilla.org/show_bug.cgi?id=219662 Attachment 236543: patch https://bugzilla.mozilla.org/attachment.cgi?id=236543&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> The autocomplete part has worked because typing in the textbox to active autocomplete enables the button ...

superreview requested: [Bug 331745] "Email This Link" doesn't appear for links whose "content" is an image : [Attachment 243857] New BrowserWindow.nib
Smokey Ardisson (unreliable; no bugmail) <alqahira@mindspring.com> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 331745: "Email This Link�" doesn't appear for links whose "content" is an image https://bugzilla.mozilla.org/show_bug.cgi?id=331745 Attachment 243857: New BrowserWindow.nib https://bugzilla.mozilla.org/attachment.cgi?id=243857&action=edit ------- Additional Comments from Smokey Ardisson (unreliable; no bugmail) <alqahira@mindspring.com> Well, it would help if my testcase didn't have a typo ...

superreview requested: [Bug 347211] Jumpback doesn't work with "Open link in new tab" from link contextual menu : [Attachment 232279] Patch
froodian <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 347211: Jumpback doesn't work with "Open link in new tab" from link contextual menu https://bugzilla.mozilla.org/show_bug.cgi?id=347211 Attachment 232279: Patch https://bugzilla.mozilla.org/attachment.cgi?id=232279&action=edit ------- Additional Comments from froodian <stridey@gmail.com> Best. Patch. Ever. ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Andrew Schultz <ajschult@mindspring.com> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ------- Additional Comments from Andrew Schultz <ajschult@mindspring.com> note that with bug 240929 and bug 236294 fixed, only the ErrorHandler part here is relevant. ...

superreview requested: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) https://bugzilla.mozilla.org/show_bug.cgi?id=284276 Attachment 177385: patch https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> might that ever change? if not, I'll remove the comment before checking in, then. ...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true; " --> status bar doesn't show url for links)
Florian Qu=C3=A8ze <f.qu@queze.net> has asked Boris Zbarsky <bzbarsky@mit.e= du> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar emp= ty for links (onmouseover=3D"return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=3D40838 Attachment 262435: patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D262435&action=3Dedit= ...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true; " --> status bar doesn't show url for links) #2
Florian Qu=C3=A8ze <f.qu@queze.net> has asked Boris Zbarsky <bzbarsky@mit.e= du> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar emp= ty for links (onmouseover=3D"return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=3D40838 Attachment 262459: patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=3D262459&action=3Dedit= ...

superreview denied: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) : [Attachment 19605
Boris Zbarsky <bzbarsky@mit.edu> has denied Florian QUEZE <f.qu@laposte.net>'s request for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=40838 Attachment 196055: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=196055&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Fair enough. Let's do that, then. I like that better t...