superreview requested: [Bug 246115] Add support for launching calendar to xremote : [Attachment 150389] Proposed fix to add calendar support to xremote

Mike Shaver <shaver@mozilla.org> has asked Christopher Blizzard
<blizzard@mozilla.org> for superreview:
Bug 246115: Add support for launching calendar to xremote
http://bugzilla.mozilla.org/show_bug.cgi?id=246115

Attachment 150389: Proposed fix to add calendar support to xremote
http://bugzilla.mozilla.org/attachment.cgi?id=150389&action=edit

------- Additional Comments from Mike Shaver <shaver@mozilla.org>
>+nsresult
>+XRemoteService::GetCalendarLocation(const char **_retval)
>+{
>+  // get the Compose chrome URL
>+  *_retval = "chrome://calendar/content/calendar.xul";

Should this be based on a pref, like GetBrowser and GetMailLocation?

>+  else if (aArgument.EqualsIgnoreCase("opencalendar")) {
>+    const char * calendarLocation;
>+    rv = GetCalendarLocation(&calendarLocation);
>+    if ( rv != NS_OK)

Bonus whitespace should be removed:
 if (rv != NS_OK)
but it seems like |if (NS_FAILED(rv))| would be better still.

>+    nsCOMPtr<nsIDOMWindow> newWindow;
>+    rv = OpenChromeWindow(0, calendarLocation, "chrome,all,dialog=no",
>+			    arg, getter_AddRefs(newWindow));
>+  }

Do we want to try to find an existing window if it's open, like Mail does?

I think the pref basing and window reuse can go in later, I just wanted to
capture them here.  Please fix the NS_FAILED thing before checking in, though.
0
bugzilla
6/10/2004 3:10:10 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
1378 Views

Similar Articles

[PageSpeed] 5

Reply:

Similar Artilces:

superreview cancelled: [Bug 246115] Add support for launching calendar to xremote : [Attachment 150389] Proposed fix to add calendar support to xremote
Mostafa Hosseini <mostafah@oeone.com> has cancelled Mike Shaver <shaver@mozilla.org>'s request for superreview: Bug 246115: Add support for launching calendar to xremote https://bugzilla.mozilla.org/show_bug.cgi?id=246115 Attachment 150389: Proposed fix to add calendar support to xremote https://bugzilla.mozilla.org/attachment.cgi?id=150389&action=edit ------- Additional Comments from Mostafa Hosseini <mostafah@oeone.com> Removing request on obsolete patch ...

superreview granted: [Bug 246115] Add support for launching calendar to xremote : [Attachment 173764] Proposed fix to add calendar support to remote (Ver 2)
Mike Shaver <shaver@mozilla.org> has granted Mike Shaver <shaver@mozilla.org>'s request for superreview: Bug 246115: Add support for launching calendar to xremote https://bugzilla.mozilla.org/show_bug.cgi?id=246115 Attachment 173764: Proposed fix to add calendar support to remote (Ver 2) https://bugzilla.mozilla.org/attachment.cgi?id=173764&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> r+sr=shaver, thanks! ...

superreview requested: [Bug 207803] [PATCH] Add FreeBSD Sparc64 support to Mozilla : [Attachment 135668] New fix for transformiix on FreeBSD
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 207803: [PATCH] Add FreeBSD Sparc64 support to Mozilla https://bugzilla.mozilla.org/show_bug.cgi?id=207803 Attachment 135668: New fix for transformiix on FreeBSD https://bugzilla.mozilla.org/attachment.cgi?id=135668&action=edit ------- Additional Comments from timeless@myrealbox.com (working) <timeless@bemail.org> this patch is better, although brendan mentioned there's more that should be swiped from jsnum.[ch] ...

superreview requested: [Bug 227651] [calendar] [mozilla 1.x] if native calendar app is available, and mozilla calendar is not there, show chrome to launch a native calendar, if specified by a pref :
timeless@myrealbox.com - traveling <timeless@bemail.org> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 227651: [calendar] [mozilla 1.x] if native calendar app is available, and mozilla calendar is not there, show chrome to launch a native calendar, if specified by a pref http://bugzilla.mozilla.org/show_bug.cgi?id=227651 Attachment 137333: bulletproofing http://bugzilla.mozilla.org/attachment.cgi?id=137333&action=edit ...

superreview requested: [Bug 253570] Add NPP arguments to some of the new NPP_ npruntime functions : [Attachment 154668] Add NPP arguments, and make use of them. Also add initial support for exception
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 253570: Add NPP arguments to some of the new NPP_ npruntime functions http://bugzilla.mozilla.org/show_bug.cgi?id=253570 Attachment 154668: Add NPP arguments, and make use of them. Also add initial support for exception throwing from plugins. http://bugzilla.mozilla.org/attachment.cgi?id=154668&action=edit ...

superreview requested: [Bug 420872] Support -profile : [Attachment 307487] add -profile support
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> for superreview: Bug 420872: Support -profile https://bugzilla.mozilla.org/show_bug.cgi?id=420872 Attachment 307487: add -profile support https://bugzilla.mozilla.org/attachment.cgi?id=307487&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Hopefully bugzilla will take it this time... This supports absolute paths only, per irc discussion. ...

superreview requested: [Bug 248549] Add undetected document.all support : [Attachment 153433] Support document.all.tags too!
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 248549: Add undetected document.all support http://bugzilla.mozilla.org/show_bug.cgi?id=248549 Attachment 153433: Support document.all.tags too! http://bugzilla.mozilla.org/attachment.cgi?id=153433&action=edit ...

superreview requested: [Bug 282174] Add Podcasting Support : [Attachment 174326] the fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 282174: Add Podcasting Support https://bugzilla.mozilla.org/show_bug.cgi?id=282174 Attachment 174326: the fix https://bugzilla.mozilla.org/attachment.cgi?id=174326&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Adds support for RSS enclosures to Thunderbird. Currently, we just send the URL to the OS and let it figure it out by altering: function openAttachment(aAttachment) { if (aAttachment.isExternalAttachme...

superreview requested: [Bug 174164] enhancements to xremoteservice (add adressbook) : [Attachment 102701] adds support for xfeDoCommand(openAddressBook)
Andrew Schultz <ajschult@eos.ncsu.edu> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 174164: enhancements to xremoteservice (add adressbook) http://bugzilla.mozilla.org/show_bug.cgi?id=174164 Attachment 102701: adds support for xfeDoCommand(openAddressBook) http://bugzilla.mozilla.org/attachment.cgi?id=102701&action=edit ...

superreview requested: [Bug 362557] Add Support For Editing Tags : [Attachment 247236] the fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 362557: Add Support For Editing Tags https://bugzilla.mozilla.org/show_bug.cgi?id=362557 Attachment 247236: the fix https://bugzilla.mozilla.org/attachment.cgi?id=247236&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> David, see comment 2 for details. ...

superreview requested: [Bug 283216] Add CRL and OCSP Support To Thunderbird : [Attachment 175245] the fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 283216: Add CRL and OCSP Support To Thunderbird https://bugzilla.mozilla.org/show_bug.cgi?id=283216 Attachment 175245: the fix https://bugzilla.mozilla.org/attachment.cgi?id=175245&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> This is a bit kludgy but will do for now and for the aviary 1.0 branch. This code will change quiet a bit once the Options dialog re-write happens (after the firefox options dialog landing). ...

superreview requested: [Bug 302284] add xpi hash support to InstallTrigger.install() : [Attachment 192478] Support optional crypto hashes
Daniel Veditz <dveditz@cruzio.com> has asked Mike Connor <mconnor@steelgryphon.com> for superreview: Bug 302284: add xpi hash support to InstallTrigger.install() https://bugzilla.mozilla.org/show_bug.cgi?id=302284 Attachment 192478: Support optional crypto hashes https://bugzilla.mozilla.org/attachment.cgi?id=192478&action=edit ...

superreview requested: [Bug 219282] add support for CAPA command : [Attachment 131503] proposed patch
Christian Eyrich <ch.ey@gmx.net> has asked Scott MacGregor <scott@scott-macgregor.org> for superreview: Bug 219282: add support for CAPA command http://bugzilla.mozilla.org/show_bug.cgi?id=219282 Attachment 131503: proposed patch http://bugzilla.mozilla.org/attachment.cgi?id=131503&action=edit ...

superreview requested: [Bug 182076] Build with --enable-calendar by default. : [Attachment 146140] Add the calendar component to xpinstall/packager/packages-unix
Steve Wardell <okapi@codeboy.net> has asked for superreview: Bug 182076: Build with --enable-calendar by default. http://bugzilla.mozilla.org/show_bug.cgi?id=182076 Attachment 146140: Add the calendar component to xpinstall/packager/packages-unix http://bugzilla.mozilla.org/attachment.cgi?id=146140&action=edit ...

Web resources about - superreview requested: [Bug 246115] Add support for launching calendar to xremote : [Attachment 150389] Proposed fix to add calendar support to xremote - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/7/2016 12:54:28 AM