superreview granted: [Bug 232503] Start using Empty[C]String() : [Attachment 140140] Use Empty[C]String()
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 232503: Start using Empty[C]String() http://bugzilla.mozilla.org/show_bug.cgi?id=232503 Attachment 140140: Use Empty[C]String() http://bugzilla.mozilla.org/attachment.cgi?id=140140&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> > Index: editor/libeditor/html/Makefile.in > =================================================================== > @@ -58,19 +58,18 @@ CPPSRCS =...

superreview requested: [Bug 334189] nsSHistory::PrintHistory should use a string class : [Attachment 218648] reindent file and use string class
timeless <timeless@bemail.org> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 334189: nsSHistory::PrintHistory should use a string class https://bugzilla.mozilla.org/show_bug.cgi?id=334189 Attachment 218648: reindent file and use string class https://bugzilla.mozilla.org/attachment.cgi?id=218648&action=edit ...

superreview requested: [Bug 261798] crash if CSSStyleSheet::insertRule is used with an empty string : [Attachment 160375] Aviary patch
Daniel Veditz <dveditz@cruzio.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 261798: crash if CSSStyleSheet::insertRule is used with an empty string https://bugzilla.mozilla.org/show_bug.cgi?id=261798 Attachment 160375: Aviary patch https://bugzilla.mozilla.org/attachment.cgi?id=160375&action=edit ...

superreview requested: [Bug 261798] crash if CSSStyleSheet::insertRule is used with an empty string : [Attachment 160436] Patch with the InsertElementsAt() change that dveditz caught
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 261798: crash if CSSStyleSheet::insertRule is used with an empty string https://bugzilla.mozilla.org/show_bug.cgi?id=261798 Attachment 160436: Patch with the InsertElementsAt() change that dveditz caught https://bugzilla.mozilla.org/attachment.cgi?id=160436&action=edit ...

superreview requested: [Bug 267426] an empty file when dragging images (files) out of the browser to the Windows desktop or Explorer or drives other than C: : [Attachment 225689] patch using IStream a
Yuri Kovalchuk <kovalchuk77@list.ru> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 267426: an empty file when dragging images (files) out of the browser to the Windows desktop or Explorer or drives other than C: https://bugzilla.mozilla.org/show_bug.cgi?id=267426 Attachment 225689: patch using IStream and IAsyncOperation https://bugzilla.mozilla.org/attachment.cgi?id=225689&action=edit ------- Additional Comments from Yuri Kovalchuk <kovalchuk77@list.ru> This is a working version of the patch, it can go unchanged to the Fire...

superreview requested: [Bug 289053] ###!!! ASSERTION: |First()| called on an empty string: 'mLength > 0', file r:\mozilla\all-i686-pc-cygwin\dist\include\string\nsTSubstring.h, line 201 : [Attachment
Jonas Sicking <bugmail@sicking.cc> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 289053: ###!!! ASSERTION: |First()| called on an empty string: 'mLength > 0', file r:\mozilla\all-i686-pc-cygwin\dist\include\string\nsTSubstring.h, line 201 https://bugzilla.mozilla.org/show_bug.cgi?id=289053 Attachment 179790: patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=179790&action=edit ------- Additional Comments from Jonas Sicking <bugmail@sicking.cc> I also made us at least properly render ridiculous relative fontsizes properly....

superreview granted: [Bug 334189] nsSHistory::PrintHistory should use a string class : [Attachment 218648] reindent file and use string class
jag (Peter Annema) <jag@tty.nl> has granted superreview: Bug 334189: nsSHistory::PrintHistory should use a string class https://bugzilla.mozilla.org/show_bug.cgi?id=334189 Attachment 218648: reindent file and use string class https://bugzilla.mozilla.org/attachment.cgi?id=218648&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Are you re-indenting the whole file, or just that section? ...

superreview requested: [Bug 220093] inCSSValueSearch incorrectly uses strings : [Attachment 132002] use nsString instead
timeless@myrealbox.com <timeless@bemail.org> has asked Boris Zbarsky (on vacation until end of September) <bz-vacation@mit.edu> for superreview: Bug 220093: inCSSValueSearch incorrectly uses strings http://bugzilla.mozilla.org/show_bug.cgi?id=220093 Attachment 132002: use nsString instead http://bugzilla.mozilla.org/attachment.cgi?id=132002&action=edit ...

superreview requested: [Bug 341436] ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 : [Attachment 225493] Don't pass nu
Alex Vincent <ajvincent@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 341436: ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 https://bugzilla.mozilla.org/show_bug.cgi?id=341436 Attachment 225493: Don't pass null in. https://bugzilla.mozilla.org/attachment.cgi?id=225493&action=edit ...

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 136051] as described
Robert O'Callahan <roc@ocallahan.org> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 136051: as described http://bugzilla.mozilla.org/attachment.cgi?id=136051&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> Something to try in 1.7a, but I may as well get it in the queue so I don't forget about it :-). ...

superreview requested: [Bug 298807] nsIBookmarksService::ResolveKeyword can make a better use of strings : [Attachment 188012] patch (use AString)
Jungshik Shin <jshin1987@gmail.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 298807: nsIBookmarksService::ResolveKeyword can make a better use of strings https://bugzilla.mozilla.org/show_bug.cgi?id=298807 Attachment 188012: patch (use AString) https://bugzilla.mozilla.org/attachment.cgi?id=188012&action=edit ------- Additional Comments from Jungshik Shin <jshin1987@gmail.com> now I use AString as suggested. ...

superreview requested: [Bug 131867] Our use of setlocale() is not threadsafe : [Attachment 141891] Use a Private string class for floating point numbers
Kenneth Herron (kherron) <kjh-5727@comcast.net> has asked Darin Fisher <darin@meer.net> for superreview: Bug 131867: Our use of setlocale() is not threadsafe http://bugzilla.mozilla.org/show_bug.cgi?id=131867 Attachment 141891: Use a Private string class for floating point numbers http://bugzilla.mozilla.org/attachment.cgi?id=141891&action=edit ------- Additional Comments from Kenneth Herron (kherron) <kjh-5727@comcast.net> Darin, could you sr this? This patch involves a private subclass of nsAutoCString. Regarding the %3.2f question, AppendFloat() always ...

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 150174] tada!
Robert O'Callahan <roc@ocallahan.org> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 150174: tada! http://bugzilla.mozilla.org/attachment.cgi?id=150174&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> here you go. by my count, 2252 call sites were changed. You may wish to just review the script :-) ...

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 145975] revised^2
Robert O'Callahan <roc@ocallahan.org> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 145975: revised^2 http://bugzilla.mozilla.org/attachment.cgi?id=145975&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> Carrying forward darin's r+. David, if you're OK with this code then I think we can go ahead and check it in on an otherwise quiet evening and see what ha...