superreview requested: [Bug 227633] (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR : [Attachment 154285] (Av1a-Bw) <mailnews/*> (review only) #2

Serge GAUTHERIE <gautheri@noos.fr> has asked Dan Mosedale <dmose@mozilla.org>
for superreview:
Bug 227633: (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by
nsCRT::CR
https://bugzilla.mozilla.org/show_bug.cgi?id=227633

Attachment 154285: (Av1a-Bw) <mailnews/*> (review only)
https://bugzilla.mozilla.org/attachment.cgi?id=154285&action=edit

------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr>
No super-review from <sspitzer@mozilla.org> since "2004-07-25" :-(

DanM:
DanW suggests giving 'rs' would be appropriate: proceed as you see fit...
0
bugzilla
2/2/2005 12:09:38 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
647 Views

Similar Articles

[PageSpeed] 0
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 227633] (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR : [Attachment 154285] (Av1a-Bw) <mailnews/*> (review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 227633: (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR http://bugzilla.mozilla.org/show_bug.cgi?id=227633 Attachment 154285: (Av1a-Bw) <mailnews/*> (review only) http://bugzilla.mozilla.org/attachment.cgi?id=154285&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> Keeping {{ (Av1_Bw) Fixes most '/mailnews/' '0x0?' occurences (review only) patch 2003-12-06 07:58...

superreview granted: [Bug 227633] (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR : [Attachment 154285] (Av1a-Bw) <mailnews/*> (review only)
Dan Mosedale <dmose@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 227633: (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR https://bugzilla.mozilla.org/show_bug.cgi?id=227633 Attachment 154285: (Av1a-Bw) <mailnews/*> (review only) https://bugzilla.mozilla.org/attachment.cgi?id=154285&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Nice work, and sorry for the delay. rs=dmose@mozilla.org. ...

superreview granted: [Bug 227633] (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR : [Attachment 191128] (Av1b) <mailnews/*> (full diff)
Serge GAUTHERIE <gautheri@noos.fr> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 227633: (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR https://bugzilla.mozilla.org/show_bug.cgi?id=227633 Attachment 191128: (Av1b) <mailnews/*> (full diff) https://bugzilla.mozilla.org/attachment.cgi?id=191128&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #4
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since '2004-04-26' :-( ...

superreview cancelled: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Brendan Eich <brendan@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> rs=me, I'm trusting you guys, patch looks ok from the context di...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 139060] (Bv1b) </mailnews/addrbook/src/ns*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 139060: (Bv1b) </mailnews/addrbook/src/ns*.*> http://bugzilla.mozilla.org/attachment.cgi?id=139060&action=edit ...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 139060] (Bv1b) </mailnews/addrbook/src/ns*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 139060: (Bv1b) </mailnews/addrbook/src/ns*.*> http://bugzilla.mozilla.org/attachment.cgi?id=139060&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> { (Bv1) </mailnews/addrbook/src/ns*.*> patch 2003-12-29 15:10:42 neil.parkwaycc.co.uk: review+ } ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 146705] (Ov1) </mailnews/*> additional #2
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 146705: (Ov1) </mailnews/*> additional http://bugzilla.mozilla.org/attachment.cgi?id=146705&action=edit ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 163726] (Sv1a) </mailnews/*> 3rd #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") https://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 163726: (Sv1a) </mailnews/*> 3rd https://bugzilla.mozilla.org/attachment.cgi?id=163726&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since "2004-10-28" :-( I have no compi...

superreview requested: [Bug 228448] Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' : [Attachment 137404] (Av1) <nsInternetSearchService.cpp>
Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for superreview: Bug 228448: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE' http://bugzilla.mozilla.org/show_bug.cgi?id=228448 Attachment 137404: (Av1) <nsInternetSearchService.cpp> http://bugzilla.mozilla.org/attachment.cgi?id=137404&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'r=?': (see comment 2) Can you (super-)review, compile, test, check it in ? ...

Web resources about - superreview requested: [Bug 227633] (Code cleanup) Replace 0x0a/'\n' by nsCRT::LF, and 0x0d/'\r' by nsCRT::CR : [Attachment 154285] (Av1a-Bw) <mailnews/*> (review only) #2 - netscape.mozilla.reviewers

Resources last updated: 12/20/2015 5:05:36 AM