Wan-Teh Chang <firstname.lastname@example.org> has asked Brendan Eich <email@example.com> for superreview: Bug 225859: port NSPR to Windows XP / Server 2003 64bit for AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=225859 Attachment 199357: Public interface and build system changes (for code review only) https://bugzilla.mozilla.org/attachment.cgi?id=199357&action=edit ------- Additional Comments from Wan-Teh Chang <firstname.lastname@example.org> These are the changes to NSPR's exported header files and build system for 64-bit Windows. You are welcome to review the full patch, but in the interest of saving your time, I'd like you to review the most important subset of that patch. If you don't have time to review this patch, feel free to cancel my review request. 64-bit Windows breaks two assumptions NSPR's code makes: 1. long is large enough to hold a pointer. 2. PRInt32 is large enough to hold an "OS fd" (Unix file descriptors, Winsock SOCKET, Windows HANDLE, etc.). So I have to redefine PRUptrdiff, PRWord, and PRUword for 64-bit Windows. Note that I did not touch the definitions of these types for the other platforms because I need to maintain backward compatibility. I also added a new type called PROsfd for the "OS fd", and it is defined as __int64 on 64-bit Windows so it can hold HANDLE (which is a void *), and as PRInt32 on all other platforms (to be backward compatible). Thanks.