superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
Johnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #3
Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #2
Aaron Leventhal (vacation: mostly gone until Oct 17) <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview granted: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to cre
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview requested: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Katakai-san, please hurry up to review this, if you can.=0D =0D Roc: Would you r+sr for this? Even if we...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview requested: [Bug 341436] ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 : [Attachment 225493] Don't pass nu
Alex Vincent <ajvincent@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 341436: ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 https://bugzilla.mozilla.org/show_bug.cgi?id=341436 Attachment 225493: Don't pass null in. https://bugzilla.mozilla.org/attachment.cgi?id=225493&action=edit ...

superreview requested: [Bug 359392] Very slow rendering of the top bar on mozilla.org : [Attachment 246745] Don't tile when we don't have to
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 359392: Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246745: Don't tile when we don't have to https://bugzilla.mozilla.org/attachment.cgi?id=246745&action=edit ...

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview requested: [Bug 451234] don't stop plugins from loading just because they don't have a resource file : [Attachment 334535] fix v1.0
Josh Aas <joshmoz@gmail.com> has asked Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> for superreview: Bug 451234: don't stop plugins from loading just because they don't have a resource file https://bugzilla.mozilla.org/show_bug.cgi?id=451234 Attachment 334535: fix v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=334535&action=edit ...

superreview requested: [Bug 448281] font-size sometimes gets calculated wrong : [Attachment 332497] patch 1: don't rebuild rule cascades if they're aren't currently any
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky (todo: 200+ items) <bzbarsky@mit.edu> for superreview: Bug 448281: font-size sometimes gets calculated wrong https://bugzilla.mozilla.org/show_bug.cgi?id=448281 Attachment 332497: patch 1: don't rebuild rule cascades if they're aren't currently any https://bugzilla.mozilla.org/attachment.cgi?id=332497&action=edit ...