superreview granted: [Bug 217147] [pwd-mngr] "View Saved Passwords..." window doesn't remember its size and position : [Attachment 131839] patch to fix bug 205176 as wellBrian Ryner <bryner@brianryner.com> has granted Steffen Wilberg
<steffen.wilberg@web.de>'s request for superreview:
Bug 217147: [pwd-mngr] "View Saved Passwords..." window doesn't remember its
size and position
http://bugzilla.mozilla.org/show_bug.cgi?id=217147
Attachment 131839: patch to fix bug 205176 as well
http://bugzilla.mozilla.org/attachment.cgi?id=131839&action=edit
------- Additional Comments from Brian Ryner <bryner@brianryner.com>
r+sr=bryner
...
superreview requested: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fixStuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton (not
reading bugmail) <mikepinkerton@mac.com> for superreview:
Bug 416063: "Save this password?" dialog has "Never Save" focused instead of
"Don't Save" with FKA on (again!)
https://bugzilla.mozilla.org/show_bug.cgi?id=416063
Attachment 304041: fix
https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit
...
superreview requested: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] PatchSimon Montagu <smontagu@smontagu.org> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 350693: "Character Encoding" in "View Source" window doesn't work
https://bugzilla.mozilla.org/show_bug.cgi?id=350693
Attachment 236818: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit
------- Additional Comments from Simon Montagu <smontagu@smontagu.org>
This is a port of Neil's patch to xpfe in bug 252317. It had r=doron,
sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit.
...
superreview requested: [Bug 242346] "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts : [Attachment 147494] PatchStefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked jag (Peter Annema)
<jag@tty.nl> for superreview:
Bug 242346: "Customize Character Encoding" dialog doesn't remember its size and
position and is opened to small when using larger fonts
http://bugzilla.mozilla.org/show_bug.cgi?id=242346
Attachment 147494: Patch
http://bugzilla.mozilla.org/attachment.cgi?id=147494&action=edit
------- Additional Comments from Stefan Borggraefe <Stefan.Borggraefe@gmx.de>
I can change the order of the attributes before the checkin.
...
superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292022] patch v1: fixes mentioned problemAnant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until
spring) <bzbarsky@mit.edu> for superreview:
Bug 393002: "Server not found" message for view-source window doesn't display
server name
https://bugzilla.mozilla.org/show_bug.cgi?id=393002
Attachment 292022: patch v1: fixes mentioned problem
https://bugzilla.mozilla.org/attachment.cgi?id=292022&action=edit
...
superreview requested: [Bug 242346] "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts : [Attachment 147494] Patch #2Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked Alec Flett
<alecf@flett.org> for superreview:
Bug 242346: "Customize Character Encoding" dialog doesn't remember its size and
position and is opened to small when using larger fonts
http://bugzilla.mozilla.org/show_bug.cgi?id=242346
Attachment 147494: Patch
http://bugzilla.mozilla.org/attachment.cgi?id=147494&action=edit
...
superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-reviewAnant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until
spring) <bzbarsky@mit.edu> for superreview:
Bug 393002: "Server not found" message for view-source window doesn't display
server name
https://bugzilla.mozilla.org/show_bug.cgi?id=393002
Attachment 292031: patch v2: address issue raised by super-review
https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit
...
superreview requested: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1Edward Lee (Mardak) <edilee@gmail.com> has asked Christian :Biesinger
<cbiesinger@gmx.at> for superreview:
Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't
show completion
https://bugzilla.mozilla.org/show_bug.cgi?id=418961
Attachment 305432: v1
https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit
------- Additional Comments from Edward Lee (Mardak) <edilee@gmail.com>
Similar to what we needed to do for exthandler.. set the NETWORK bit. All
places in webbrowserpersist that have a STATE_START ...
superreview requested: [Bug 220451] Popup Manager's "Allowed Sites" dialog doesn't persist size and position : [Attachment 132310] PatchStefan Borggraefe <borggraefe@despammed.com> has asked Alec Flett
<alecf@flett.org> for superreview:
Bug 220451: Popup Manager's "Allowed Sites" dialog doesn't persist size and
position
http://bugzilla.mozilla.org/show_bug.cgi?id=220451
Attachment 132310: Patch
http://bugzilla.mozilla.org/attachment.cgi?id=132310&action=edit
...
superreview requested: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patchChristian Biesinger (:bi) <cbiesinger@gmx.at> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the
link itself displays file size on download (FTP)
https://bugzilla.mozilla.org/show_bug.cgi?id=284276
Attachment 177385: patch
https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit
------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at>
might that ever change? if not, I'll remove the comment before checking in,
then.
...
superreview granted: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fixMike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> has granted Stuart
Morgan <stuart.morgan@alumni.case.edu>'s request for superreview:
Bug 416063: "Save this password?" dialog has "Never Save" focused instead of
"Don't Save" with FKA on (again!)
https://bugzilla.mozilla.org/show_bug.cgi?id=416063
Attachment 304041: fix
https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit
------- Additional Comments from Mike Pinkerton (not reading bugmail)
<mikepinkerton@mac.com>
sr=pink
...
superreview granted: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] PatchScott MacGregor <mscott@mozilla.org> has granted Simon Montagu
<smontagu@smontagu.org>'s request for superreview:
Bug 350693: "Character Encoding" in "View Source" window doesn't work
https://bugzilla.mozilla.org/show_bug.cgi?id=350693
Attachment 236818: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
this needs a toolkit module owner review so I'll ask Benjamin for that.
David's on vacation, i'll do the sr.
...
superreview requested: [Bug 65596] "Manage Stored Passwords" window should be wider and remember previous size and position : [Attachment 131500] FixStefan Borggraefe <borggraefe@despammed.com> has asked jag (Peter Annema)
<jag@tty.nl> for superreview:
Bug 65596: "Manage Stored Passwords" window should be wider and remember
previous size and position
http://bugzilla.mozilla.org/show_bug.cgi?id=65596
Attachment 131500: Fix
http://bugzilla.mozilla.org/attachment.cgi?id=131500&action=edit
...
superreview requested: [Bug 216479] when saving drafts and templates, we don't save the "return receipts" and "attach vcard" info : [ Attachment 295016] proposed fixMagnus Melin <mkmelin+mozilla@iki.fi> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 216479: when saving drafts and templates, we don't save the "return
receipts" and "attach vcard" info
https://bugzilla.mozilla.org/show_bug.cgi?id=216479
Attachment 295016: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=295016&action=edit
------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi>
Everything else is in place, it's just that the parsed values were always
overridden by the identity prefs...