superreview requested: [Bug 174266] links opening blank new window but content showing in current window if browser.block.target_new_window : [Attachment 152987] Proposed patch #2Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback
<jst@mozilla.jstenback.com> for superreview:
Bug 174266: links opening blank new window but content showing in current
window if browser.block.target_new_window
http://bugzilla.mozilla.org/show_bug.cgi?id=174266
Attachment 152987: Proposed patch
http://bugzilla.mozilla.org/attachment.cgi?id=152987&action=edit
...
superreview granted: [Bug 174266] links opening blank new window but content showing in current window if browser.block.target_new_window : [Attachment 152987] Proposed patchJohnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 174266: links opening blank new window but content showing in current
window if browser.block.target_new_window
http://bugzilla.mozilla.org/show_bug.cgi?id=174266
Attachment 152987: Proposed patch
http://bugzilla.mozilla.org/attachment.cgi?id=152987&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
sr=jst
...
superreview requested: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] PatchBoris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback
<jst@mozilla.jstenback.com> for superreview:
Bug 279495: A link with an URL and additional javascript open shows a popup and
an unwanted new window [link with TARGET and onClick=window.open]
https://bugzilla.mozilla.org/show_bug.cgi?id=279495
Attachment 172585: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=172585&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
This basically backs out the "fix" for bug 135811. Now I can't figure out how
finding targe...
superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 286745: Open externally-launched links in a new tab or window
https://bugzilla.mozilla.org/show_bug.cgi?id=286745
Attachment 177879: Patch to make externally-launched links open in new window
(Seamonkey only)
https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit
...
superreview requested: [Bug 310395] Open Link in New Windowfroodiantherapy (mostly gone until June 4) <stridey@gmail.com> has asked Mike
Pinkerton <mikepinkerton@mac.com> for superreview:
Bug 310395: Open Link in New Window - new background windows open with Address
bar focused
https://bugzilla.mozilla.org/show_bug.cgi?id=310395
Attachment 223629: Last Patch before sr?
https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit
------- Additional Comments from froodiantherapy (mostly gone until June 4)
<stridey@gmail.com>
Assuming that this has cl+ too. ;)
...
superreview granted: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] PatchJohnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 279495: A link with an URL and additional javascript open shows a popup and
an unwanted new window [link with TARGET and onClick=window.open]
https://bugzilla.mozilla.org/show_bug.cgi?id=279495
Attachment 172585: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=172585&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
Ugh, I can't explain how this worked... not w/o digging through old code I
...
superreview requested: [Bug 278916] link launches blank popup window and new page with the desired content : [Attachment 173190] Proposed patchBoris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org>
for superreview:
Bug 278916: link launches blank popup window and new page with the desired
content
https://bugzilla.mozilla.org/show_bug.cgi?id=278916
Attachment 173190: Proposed patch
https://bugzilla.mozilla.org/attachment.cgi?id=173190&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
OK, I think this should fix it, assuming that Camino uses nsWebBrowser. I did
test this in TestGtkEmbed (which was also showing this bug).
The basic issue is that the...
superreview requested: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 316692] BrowserOpenTab() even when no windows are openStefan <stefanh@bluebottle.com> has asked neil@parkwaycc.co.uk <neil@httl.net>
for superreview:
Bug 429926: Make Cmd+T open a new window when no browser windows are open
https://bugzilla.mozilla.org/show_bug.cgi?id=429926
Attachment 316692: BrowserOpenTab() even when no windows are open
https://bugzilla.mozilla.org/attachment.cgi?id=316692&action=edit
...
superreview granted: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jeremy
Morton <bugzilla@game-point.net>'s request for superreview:
Bug 286745: Open externally-launched links in a new tab or window
https://bugzilla.mozilla.org/show_bug.cgi?id=286745
Attachment 177879: Patch to make externally-launched links open in new window
(Seamonkey only)
https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit
...
superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177878] Patch to make externally-launched links open in new tab (Seamonkey only)Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 286745: Open externally-launched links in a new tab or window
https://bugzilla.mozilla.org/show_bug.cgi?id=286745
Attachment 177878: Patch to make externally-launched links open in new tab
(Seamonkey only)
https://bugzilla.mozilla.org/attachment.cgi?id=177878&action=edit
...
superreview requested: [Bug 200006] cannot dismiss alert when accessing a bogus url via open web location (target=current window or new tab, new window works fine) : [Attachment 136615] proposed fixBrendan Eich <brendan@mozilla.org> has asked Darin Fisher <darin@meer.net> for
superreview:
Bug 200006: cannot dismiss alert when accessing a bogus url via open web
location (target=current window or new tab, new window works fine)
http://bugzilla.mozilla.org/show_bug.cgi?id=200006
Attachment 136615: proposed fix, plus comment cleanup
http://bugzilla.mozilla.org/attachment.cgi?id=136615&action=edit
------- Additional Comments from Brendan Eich <brendan@mozilla.org>
Thanks to sfraser for the analysis.
/be
...
superreview requested: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 231671] protect againsMarria Nazif <marria@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 344808: Canceling a [download whose link tries to open a new window] causes
current tab to close, when browser.link.open_newwindow is 1
https://bugzilla.mozilla.org/show_bug.cgi?id=344808
Attachment 231671: protect against opened window being the same as the original
window
https://bugzilla.mozilla.org/attachment.cgi?id=231671&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
Darin and I discussed this approach and agree that it is ...
superreview requested: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 231343] use owner-checSimon B�nzli <zeniko@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 344808: Canceling a [download whose link tries to open a new window] causes
current tab to close, when browser.link.open_newwindow is 1
https://bugzilla.mozilla.org/show_bug.cgi?id=344808
Attachment 231343: use owner-check instead
https://bugzilla.mozilla.org/attachment.cgi?id=231343&action=edit
------- Additional Comments from Simon B�nzli <zeniko@gmail.com>
This patch makes sure that the opening window is in fact the opener of the new
window before marking ...
superreview requested: [Bug 429926] Make Cmd+T open a new window when no browser windows are open : [Attachment 317598] New versionjag (Peter Annema) <jag@tty.nl> has asked neil@parkwaycc.co.uk <neil@httl.n=
et>
for superreview:
Bug 429926: Make Cmd+T open a new window when no browser windows are open
https://bugzilla.mozilla.org/show_bug.cgi?id=3D429926
Attachment 317598: New version
https://bugzilla.mozilla.org/attachment.cgi?id=3D317598&action=3Dedit
------- Additional Comments from jag (Peter Annema) <jag@tty.nl>
I was thinking we could just check gBrowser at the beginning of this functi=
on
and call OpenBrowserWindow(), but that would use the "new window" pref sett=
ing
...