superreview requested: [Bug 157004] Use original URL in history and URL bar when an error page is generated (show failed url) : [Attachment 172943] nsIDOMLocation patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 157004: Use original URL in history and URL bar when an error page is generated (show failed url) https://bugzilla.mozilla.org/show_bug.cgi?id=157004 Attachment 172943: nsIDOMLocation patch https://bugzilla.mozilla.org/attachment.cgi?id=172943&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> this patch changes nsIDOMLocation.idl as requested by bz in comment 77; also note comment 80
|
0 |
|
bugzilla
1/31/2005 11:29:22 AM
netscape.mozilla.reviewers
29156 articles. 
0 followers.
0 Replies
841 Views
Similar Artilces:
superreview granted: [Bug 157004] Use original URL in history and URL bar when an error page is generated (show failed url) : [Attachment 172943] nsIDOMLocation patch
Johnny Stenback <jst@mozilla.org> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 157004: Use original URL in history and URL bar when an error page is generated (show failed url) https://bugzilla.mozilla.org/show_bug.cgi?id=157004 Attachment 172943: nsIDOMLocation patch https://bugzilla.mozilla.org/attachment.cgi?id=172943&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...
superreview granted: [Bug 157004] Use original URL in history and URL bar when an error page is generated (show failed url) : [Attachment 172838] patch v5
Darin Fisher <darin@meer.net> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 157004: Use original URL in history and URL bar when an error page is generated (show failed url) https://bugzilla.mozilla.org/show_bug.cgi?id=157004 Attachment 172838: patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=172838&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> sr=darin, but i'm not so sure about the comment in nsIDOMLocation. you should really run that by jst first. my concern: is nsIDOM...
superreview requested: [Bug 157004] Use original URL in history and URL bar when an error page is generated : [Attachment 172838] patch v5
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Darin Fisher <darin@meer.net> for superreview: Bug 157004: Use original URL in history and URL bar when an error page is generated https://bugzilla.mozilla.org/show_bug.cgi?id=157004 Attachment 172838: patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=172838&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> ok, made that change ...
superreview requested: [Bug 295279] provide origin charset of original URI to error page : [Attachment 184414] add charset parameter to error page URL
Christian Persch <chpe@gnome.org> has asked Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> for superreview: Bug 295279: provide origin charset of original URI to error page https://bugzilla.mozilla.org/show_bug.cgi?id=295279 Attachment 184414: add charset parameter to error page URL https://bugzilla.mozilla.org/attachment.cgi?id=184414&action=edit ------- Additional Comments from Christian Persch <chpe@gnome.org> Free the escaped charset after use. (Transferring biesi's r+) ...
superreview requested: [Bug 295279] provide origin charset of original URI to error page : [Attachment 184402] add charset parameter to error page URL
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> for superreview: Bug 295279: provide origin charset of original URI to error page https://bugzilla.mozilla.org/show_bug.cgi?id=295279 Attachment 184402: add charset parameter to error page URL https://bugzilla.mozilla.org/attachment.cgi?id=184402&action=edit ...
superreview requested: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202111] Patch rv1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202111: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=202111&action=edit ...
superreview requested: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202187] Patch rv1.2
Darin Fisher <darin@meer.net> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202187: Patch rv1.2 https://bugzilla.mozilla.org/attachment.cgi?id=202187&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> OK, here's a revised patch. I am falling back on ConvertUTF8toACE when Normalize fails. This seems to address the problems that I found with malformed bidi text...
superreview requested: [Bug 162791] PATCH: URL bar accepts Drag & Drop of strings/URLs : [Attachment 122076] doesn't load URL on drop
Simon Woodside <sbwoodside@yahoo.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 162791: PATCH: URL bar accepts Drag & Drop of strings/URLs http://bugzilla.mozilla.org/show_bug.cgi?id=162791 Attachment 122076: doesn't load URL on drop http://bugzilla.mozilla.org/attachment.cgi?id=122076&action=edit ------- Additional Comments from Simon Woodside <sbwoodside@yahoo.com> r+ ...
superreview requested: [Bug 300183] Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode : [Attachment 188762] Patch rv1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 300183: Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode https://bugzilla.mozilla.org/show_bug.cgi?id=300183 Attachment 188762: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=188762&action=edit ...
superreview requested: [Bug 286811] Invalid URLs get logged into global history when XUL error pages are enabled : [Attachment 190283] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Darin Fisher <darin@meer.net> for superreview: Bug 286811: Invalid URLs get logged into global history when XUL error pages are enabled https://bugzilla.mozilla.org/show_bug.cgi?id=286811 Attachment 190283: patch https://bugzilla.mozilla.org/attachment.cgi?id=190283&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> sorry about the part from bug 300863 in this patch (the OnNewURI part in hunk 1), but there was really no way to avoid it... ...
superreview requested: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ...
superreview requested: [Bug 157354] URL bar should not display passwords in URL : [Attachment 146329] patch nsIURIFixup::CreateExposableURI instead
Daniel Veditz <dveditz@cruzio.com> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 157354: URL bar should not display passwords in URL http://bugzilla.mozilla.org/show_bug.cgi?id=157354 Attachment 146329: patch nsIURIFixup::CreateExposableURI instead http://bugzilla.mozilla.org/attachment.cgi?id=146329&action=edit ...
superreview requested: [Bug 288460] link urls get replaced by urls appearing earlier in the page : [Attachment 183743] patch v1
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> for superreview: Bug 288460: link urls get replaced by urls appearing earlier in the page https://bugzilla.mozilla.org/show_bug.cgi?id=288460 Attachment 183743: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=183743&action=edit ...
superreview granted: [Bug 295279] provide origin charset of original URI to error page : [Attachment 184414] add charset parameter to error page URL
Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> has granted Christian Persch <chpe@gnome.org>'s request for superreview: Bug 295279: provide origin charset of original URI to error page https://bugzilla.mozilla.org/show_bug.cgi?id=295279 Attachment 184414: add charset parameter to error page URL https://bugzilla.mozilla.org/attachment.cgi?id=184414&action=edit ...
superreview denied: [Bug 295279] provide origin charset of original URI to error page : [Attachment 184402] add charset parameter to error page URL
Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> has denied Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 295279: provide origin charset of original URI to error page https://bugzilla.mozilla.org/show_bug.cgi?id=295279 Attachment 184402: add charset parameter to error page URL https://bugzilla.mozilla.org/attachment.cgi?id=184402&action=edit ------- Additional Comments from Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> This leaks; escapedCharset is never freed. ...
superreview cancelled: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202187] Patch rv1.2
Darin Fisher <darin@meer.net> has cancelled Darin Fisher <darin@meer.net>'s request for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202187: Patch rv1.2 https://bugzilla.mozilla.org/attachment.cgi?id=202187&action=edit ...
superreview granted: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202136] Patch rv1.1
Darin Fisher <darin@meer.net> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202136: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=202136&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Here's a slightly revised version of the patch. The main problem with the v1.0 patch was that it was passing |result| as both an in-param as well as an...
superreview cancelled: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202111] Patch rv1.0
Darin Fisher <darin@meer.net> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202111: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=202111&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Here's a slightly revised version of the patch. The main problem with the v1.0 patch was that it was passing |result| as bo...
superreview granted: [Bug 162791] PATCH: URL bar accepts Drag & Drop of strings/URLs : [Attachment 122076] doesn't load URL on drop
Mike Pinkerton <pinkerton@aol.net> has granted Simon Woodside <sbwoodside@yahoo.com>'s request for superreview: Bug 162791: PATCH: URL bar accepts Drag & Drop of strings/URLs http://bugzilla.mozilla.org/show_bug.cgi?id=162791 Attachment 122076: doesn't load URL on drop http://bugzilla.mozilla.org/attachment.cgi?id=122076&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...
superreview requested: [Bug 241320] Incorrect link URL generation on pages with a URL of the form 127.0.0.1:port# : [Attachment 146803] Smack the Oracle thing too
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 241320: Incorrect link URL generation on pages with a URL of the form 127.0.0.1:port# http://bugzilla.mozilla.org/show_bug.cgi?id=241320 Attachment 146803: Smack the Oracle thing too http://bugzilla.mozilla.org/attachment.cgi?id=146803&action=edit ...
superreview requested: [Bug 313027] Can't drag plain text url to tab bar : [Attachment 205462] Patch to make url parsing from text less strict
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked for superreview: Bug 313027: Can't drag plain text url to tab bar https://bugzilla.mozilla.org/show_bug.cgi?id=313027 Attachment 205462: Patch to make url parsing from text less strict https://bugzilla.mozilla.org/attachment.cgi?id=205462&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> This seems like the way to go, and works in my testing. r=me (although the commented out |&& ...| should be removed before checkin. ...
superreview requested: [Bug 313027] Can't drag plain text url to tab bar : [Attachment 205462] Patch to make url parsing from text less strict #2
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 313027: Can't drag plain text url to tab bar https://bugzilla.mozilla.org/show_bug.cgi?id=313027 Attachment 205462: Patch to make url parsing from text less strict https://bugzilla.mozilla.org/attachment.cgi?id=205462&action=edit ...
superreview requested: [Bug 237803] Unhiding the url bar doesn't update url address field to the currently displayed page : [Attachment 158943] make sure the field editor is non-nill before comparing
Geoff Beier <me@mollyandgeoff.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 237803: Unhiding the url bar doesn't update url address field to the currently displayed page http://bugzilla.mozilla.org/show_bug.cgi?id=237803 Attachment 158943: make sure the field editor is non-nill before comparing it to the firstResponder, which may be nil http://bugzilla.mozilla.org/attachment.cgi?id=158943&action=edit ...
superreview cancelled: [Bug 300183] Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode : [Attachment 188762] Patch rv1.0
Scott MacGregor <mscott@mozilla.org> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 300183: Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode https://bugzilla.mozilla.org/show_bug.cgi?id=300183 Attachment 188762: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=188762&action=edit ...
Johnny Stenback <jst@mozilla.org> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 157004: Use original URL in history and URL bar when an error page is generated (show failed url) https://bugzilla.mozilla.org/show_bug.cgi?id=157004 Attachment 172943: nsIDOMLocation patch https://bugzilla.mozilla.org/attachment.cgi?id=172943&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...
superreview granted: [Bug 157004] Use original URL in history and URL bar when an error page is generated (show failed url) : [Attachment 172838] patch v5
Darin Fisher <darin@meer.net> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 157004: Use original URL in history and URL bar when an error page is generated (show failed url) https://bugzilla.mozilla.org/show_bug.cgi?id=157004 Attachment 172838: patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=172838&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> sr=darin, but i'm not so sure about the comment in nsIDOMLocation. you should really run that by jst first. my concern: is nsIDOM...
superreview requested: [Bug 157004] Use original URL in history and URL bar when an error page is generated : [Attachment 172838] patch v5
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Darin Fisher <darin@meer.net> for superreview: Bug 157004: Use original URL in history and URL bar when an error page is generated https://bugzilla.mozilla.org/show_bug.cgi?id=157004 Attachment 172838: patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=172838&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> ok, made that change ...
superreview requested: [Bug 295279] provide origin charset of original URI to error page : [Attachment 184414] add charset parameter to error page URL
Christian Persch <chpe@gnome.org> has asked Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> for superreview: Bug 295279: provide origin charset of original URI to error page https://bugzilla.mozilla.org/show_bug.cgi?id=295279 Attachment 184414: add charset parameter to error page URL https://bugzilla.mozilla.org/attachment.cgi?id=184414&action=edit ------- Additional Comments from Christian Persch <chpe@gnome.org> Free the escaped charset after use. (Transferring biesi's r+) ...
superreview requested: [Bug 295279] provide origin charset of original URI to error page : [Attachment 184402] add charset parameter to error page URL
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> for superreview: Bug 295279: provide origin charset of original URI to error page https://bugzilla.mozilla.org/show_bug.cgi?id=295279 Attachment 184402: add charset parameter to error page URL https://bugzilla.mozilla.org/attachment.cgi?id=184402&action=edit ...
superreview requested: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202111] Patch rv1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202111: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=202111&action=edit ...
superreview requested: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202187] Patch rv1.2
Darin Fisher <darin@meer.net> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202187: Patch rv1.2 https://bugzilla.mozilla.org/attachment.cgi?id=202187&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> OK, here's a revised patch. I am falling back on ConvertUTF8toACE when Normalize fails. This seems to address the problems that I found with malformed bidi text...
superreview requested: [Bug 162791] PATCH: URL bar accepts Drag & Drop of strings/URLs : [Attachment 122076] doesn't load URL on drop
Simon Woodside <sbwoodside@yahoo.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 162791: PATCH: URL bar accepts Drag & Drop of strings/URLs http://bugzilla.mozilla.org/show_bug.cgi?id=162791 Attachment 122076: doesn't load URL on drop http://bugzilla.mozilla.org/attachment.cgi?id=122076&action=edit ------- Additional Comments from Simon Woodside <sbwoodside@yahoo.com> r+ ...
superreview requested: [Bug 300183] Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode : [Attachment 188762] Patch rv1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 300183: Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode https://bugzilla.mozilla.org/show_bug.cgi?id=300183 Attachment 188762: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=188762&action=edit ...
superreview requested: [Bug 286811] Invalid URLs get logged into global history when XUL error pages are enabled : [Attachment 190283] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Darin Fisher <darin@meer.net> for superreview: Bug 286811: Invalid URLs get logged into global history when XUL error pages are enabled https://bugzilla.mozilla.org/show_bug.cgi?id=286811 Attachment 190283: patch https://bugzilla.mozilla.org/attachment.cgi?id=190283&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> sorry about the part from bug 300863 in this patch (the OnNewURI part in hunk 1), but there was really no way to avoid it... ...
superreview requested: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ...
superreview requested: [Bug 157354] URL bar should not display passwords in URL : [Attachment 146329] patch nsIURIFixup::CreateExposableURI instead
Daniel Veditz <dveditz@cruzio.com> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 157354: URL bar should not display passwords in URL http://bugzilla.mozilla.org/show_bug.cgi?id=157354 Attachment 146329: patch nsIURIFixup::CreateExposableURI instead http://bugzilla.mozilla.org/attachment.cgi?id=146329&action=edit ...
superreview requested: [Bug 288460] link urls get replaced by urls appearing earlier in the page : [Attachment 183743] patch v1
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> for superreview: Bug 288460: link urls get replaced by urls appearing earlier in the page https://bugzilla.mozilla.org/show_bug.cgi?id=288460 Attachment 183743: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=183743&action=edit ...
superreview granted: [Bug 295279] provide origin charset of original URI to error page : [Attachment 184414] add charset parameter to error page URL
Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> has granted Christian Persch <chpe@gnome.org>'s request for superreview: Bug 295279: provide origin charset of original URI to error page https://bugzilla.mozilla.org/show_bug.cgi?id=295279 Attachment 184414: add charset parameter to error page URL https://bugzilla.mozilla.org/attachment.cgi?id=184414&action=edit ...
superreview denied: [Bug 295279] provide origin charset of original URI to error page : [Attachment 184402] add charset parameter to error page URL
Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> has denied Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 295279: provide origin charset of original URI to error page https://bugzilla.mozilla.org/show_bug.cgi?id=295279 Attachment 184402: add charset parameter to error page URL https://bugzilla.mozilla.org/attachment.cgi?id=184402&action=edit ------- Additional Comments from Boris Zbarsky (gone June 3 -- June 30) <bzbarsky@mit.edu> This leaks; escapedCharset is never freed. ...
superreview cancelled: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202187] Patch rv1.2
Darin Fisher <darin@meer.net> has cancelled Darin Fisher <darin@meer.net>'s request for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202187: Patch rv1.2 https://bugzilla.mozilla.org/attachment.cgi?id=202187&action=edit ...
superreview granted: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202136] Patch rv1.1
Darin Fisher <darin@meer.net> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202136: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=202136&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Here's a slightly revised version of the patch. The main problem with the v1.0 patch was that it was passing |result| as both an in-param as well as an...
superreview cancelled: [Bug 315411] fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar : [Attachment 202111] Patch rv1.0
Darin Fisher <darin@meer.net> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 315411: fail to check the IDN is in whitelist if user inputs un-normalized URL in URL bar https://bugzilla.mozilla.org/show_bug.cgi?id=315411 Attachment 202111: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=202111&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Here's a slightly revised version of the patch. The main problem with the v1.0 patch was that it was passing |result| as bo...
superreview granted: [Bug 162791] PATCH: URL bar accepts Drag & Drop of strings/URLs : [Attachment 122076] doesn't load URL on drop
Mike Pinkerton <pinkerton@aol.net> has granted Simon Woodside <sbwoodside@yahoo.com>'s request for superreview: Bug 162791: PATCH: URL bar accepts Drag & Drop of strings/URLs http://bugzilla.mozilla.org/show_bug.cgi?id=162791 Attachment 122076: doesn't load URL on drop http://bugzilla.mozilla.org/attachment.cgi?id=122076&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...
superreview requested: [Bug 241320] Incorrect link URL generation on pages with a URL of the form 127.0.0.1:port# : [Attachment 146803] Smack the Oracle thing too
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 241320: Incorrect link URL generation on pages with a URL of the form 127.0.0.1:port# http://bugzilla.mozilla.org/show_bug.cgi?id=241320 Attachment 146803: Smack the Oracle thing too http://bugzilla.mozilla.org/attachment.cgi?id=146803&action=edit ...
superreview requested: [Bug 313027] Can't drag plain text url to tab bar : [Attachment 205462] Patch to make url parsing from text less strict
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked for superreview: Bug 313027: Can't drag plain text url to tab bar https://bugzilla.mozilla.org/show_bug.cgi?id=313027 Attachment 205462: Patch to make url parsing from text less strict https://bugzilla.mozilla.org/attachment.cgi?id=205462&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> This seems like the way to go, and works in my testing. r=me (although the commented out |&& ...| should be removed before checkin. ...
superreview requested: [Bug 313027] Can't drag plain text url to tab bar : [Attachment 205462] Patch to make url parsing from text less strict #2
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 313027: Can't drag plain text url to tab bar https://bugzilla.mozilla.org/show_bug.cgi?id=313027 Attachment 205462: Patch to make url parsing from text less strict https://bugzilla.mozilla.org/attachment.cgi?id=205462&action=edit ...
superreview requested: [Bug 237803] Unhiding the url bar doesn't update url address field to the currently displayed page : [Attachment 158943] make sure the field editor is non-nill before comparing
Geoff Beier <me@mollyandgeoff.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 237803: Unhiding the url bar doesn't update url address field to the currently displayed page http://bugzilla.mozilla.org/show_bug.cgi?id=237803 Attachment 158943: make sure the field editor is non-nill before comparing it to the firstResponder, which may be nil http://bugzilla.mozilla.org/attachment.cgi?id=158943&action=edit ...
superreview cancelled: [Bug 300183] Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode : [Attachment 188762] Patch rv1.0
Scott MacGregor <mscott@mozilla.org> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 300183: Cannot attach the web page that its URL is encoded by non-UTF-8 URL encode https://bugzilla.mozilla.org/show_bug.cgi?id=300183 Attachment 188762: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=188762&action=edit ...
Web resources about - superreview requested: [Bug 157004] Use original URL in history and URL bar when an error page is generated (show failed url) : [Attachment 172943] nsIDOMLocation patch - netscape.mozilla.reviewersResources last updated: 3/6/2016 3:36:20 PM