superreview requested: [Bug 90263] New account wizard uses "server name" and "hostname" : [Attachment 106602] quick patch that changes hostname to server nameHenrik Lynggaard Hansen <admin@mozillatranslator.org> has asked Scott MacGregor
(on holiday until 01/02/2004) <mscott@mozilla.org> for superreview:
Bug 90263: New account wizard uses "server name" and "hostname"
http://bugzilla.mozilla.org/show_bug.cgi?id=90263
Attachment 106602: quick patch that changes hostname to server name
http://bugzilla.mozilla.org/attachment.cgi?id=106602&action=edit
------- Additional Comments from Henrik Lynggaard Hansen
<admin@mozillatranslator.org>
review please
...
superreview granted: [Bug 102269] Cookie Manager: "Server Secure" should be "Secure Server" : [Attachment 143120] patch v2 including dialog updateAlec Flett <alecf@flett.org> has granted Mike Connor <mconnor@myrealbox.com>'s
request for superreview:
Bug 102269: Cookie Manager: "Server Secure" should be "Secure Server"
http://bugzilla.mozilla.org/show_bug.cgi?id=102269
Attachment 143120: patch v2 including dialog update
http://bugzilla.mozilla.org/attachment.cgi?id=143120&action=edit
------- Additional Comments from Alec Flett <alecf@flett.org>
sr=alecf
...
superreview granted: [Bug 216789] "Server Settings" tab in "Account Settings" is too big for preferences window : [Attachment 130981] Revised Patch v0.2aDavid Bienvenu <bienvenu@nventure.com> has granted Ian Neal
<bugzilla@arlen.demon.co.uk>'s request for superreview:
Bug 216789: "Server Settings" tab in "Account Settings" is too big for
preferences window
http://bugzilla.mozilla.org/show_bug.cgi?id=216789
Attachment 130981: Revised Patch v0.2a
http://bugzilla.mozilla.org/attachment.cgi?id=130981&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
sr=bienvenu
...
superreview granted: [Bug 220210] Bookmarks root is always English "Bookmarks" if using one profile named "default" : [Attachment 132103] Patch v1jag (Peter Annema) <jag@tty.nl> has granted Philip K. Warren <pkw@us.ibm.com>'s
request for superreview:
Bug 220210: Bookmarks root is always English "Bookmarks" if using one profile
named "default"
http://bugzilla.mozilla.org/show_bug.cgi?id=220210
Attachment 132103: Patch v1
http://bugzilla.mozilla.org/attachment.cgi?id=132103&action=edit
------- Additional Comments from jag (Peter Annema) <jag@tty.nl>
sr=jag
...
superreview granted: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292088] patch v3: remove unnecessary QueryInterfaceBoris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted
Anant Narayanan <anant@kix.in>'s request for superreview:
Bug 393002: "Server not found" message for view-source window doesn't display
server name
https://bugzilla.mozilla.org/show_bug.cgi?id=393002
Attachment 292088: patch v3: remove unnecessary QueryInterface
https://bugzilla.mozilla.org/attachment.cgi?id=292088&action=edit
------- Additional Comments from Boris Zbarsky (reviews very slow until spring)
<bzbarsky@mit.edu>
Excellent!
...
superreview denied: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-reviewBoris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has denied
Anant Narayanan <anant@kix.in>'s request for superreview:
Bug 393002: "Server not found" message for view-source window doesn't displ=
ay
server name
https://bugzilla.mozilla.org/show_bug.cgi?id=3D393002
Attachment 292031: patch v2: address issue raised by super-review
https://bugzilla.mozilla.org/attachment.cgi?id=3D292031&action=3Dedit
------- Additional Comments from Boris Zbarsky (reviews very slow until spr=
ing)
<bzbarsky@mit.edu>
You don't need the QI. ...
superreview requested: [Bug 393002] "Server not found" message for view-source window doesn't display server name : [ Attachment 292031] patch v2: address issue raised by super-reviewAnant Narayanan <anant@kix.in> has asked Boris Zbarsky (reviews very slow until
spring) <bzbarsky@mit.edu> for superreview:
Bug 393002: "Server not found" message for view-source window doesn't display
server name
https://bugzilla.mozilla.org/show_bug.cgi?id=393002
Attachment 292031: patch v2: address issue raised by super-review
https://bugzilla.mozilla.org/attachment.cgi?id=292031&action=edit
...
superreview granted: [Bug 240558] Message filters with action to move to folder with "@" or "!" in the name was corrupted again (Bug 229345 was regressed) : [Attachment 146567] patchScott MacGregor <mscott@mozilla.org> has granted Jungshik Shin
<jshin@mailaps.org>'s request for superreview:
Bug 240558: Message filters with action to move to folder with "@" or "!" in
the name was corrupted again (Bug 229345 was regressed)
http://bugzilla.mozilla.org/show_bug.cgi?id=240558
Attachment 146567: patch
http://bugzilla.mozilla.org/attachment.cgi?id=146567&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
ah thanks David
...
superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkinneil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow,
Mozilla.sk) <wladow@gmail.com>'s request for superreview:
Bug 93390: [RFE]"Block images from this server" should identify "this server"
https://bugzilla.mozilla.org/show_bug.cgi?id=93390
Attachment 327636: for checkin
https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit
...
superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow,
Mozilla.sk) <wladow@gmail.com>'s request for superreview:
Bug 93390: [RFE]"Block images from this server" should identify "this serve=
r"
https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390
Attachment 327455: v5
https://bugzilla.mozilla.org/attachment.cgi?id=3D327455&action=3Dedit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
Wow, that code looks much better now :-)=0D
=0D
>- gContextMenu.showItem=0D
>- ("context-blocki...
superreview granted: [Bug 250128] GOK expose "seperator" as "no name". : [Attachment 152489] patch v1Henry Jia <Henry.Jia@sun.com> has granted Louie Zhao <Louie.Zhao@sun.com>'s
request for superreview:
Bug 250128: GOK expose "seperator" as "no name".
http://bugzilla.mozilla.org/show_bug.cgi?id=250128
Attachment 152489: patch v1
http://bugzilla.mozilla.org/attachment.cgi?id=152489&action=edit
------- Additional Comments from Henry Jia <Henry.Jia@sun.com>
sr=Henry
...
ASP server attempt. Is it possible to implement, Session("name")="Damian"; Application("name")="test"I'm looking at modifing our www server embedded in our product with some ASP similar features. Will have 1 JS runtime, and a pool of JS contexts
First I thought 'Session' could be a property of the global object, but then you can't pass a arguement to a property. I was planning keeping the data in C++, when the user requested it, convert/copy it to a jsval.
Now I'm thinking Session is more like a global JS array. But then its entire contents will be stored against the global object. Which is ok, I don't need to know the infor from C++. Which means I would nee...
superreview requested: [Bug 102269] Cookie Manager: "Server Secure" should be "Secure Server" : [Attachment 143120] patch v2 including dialog updateMike Connor <mconnor@myrealbox.com> has asked Alec Flett <alecf@flett.org> for
superreview:
Bug 102269: Cookie Manager: "Server Secure" should be "Secure Server"
http://bugzilla.mozilla.org/show_bug.cgi?id=102269
Attachment 143120: patch v2 including dialog update
http://bugzilla.mozilla.org/attachment.cgi?id=143120&action=edit
------- Additional Comments from Mike Connor <mconnor@myrealbox.com>
alec, this one is pretty trivial if you have time before freeze...
...
superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 218487] updated patch ready for reviewDavid Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor
<mscott@mozilla.org>'s request for superreview:
Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings"
https://bugzilla.mozilla.org/show_bug.cgi?id=257990
Attachment 218487: updated patch ready for review
https://bugzilla.mozilla.org/attachment.cgi?id=218487&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
my one concern is about migration from the per-server prefs to the global
prefs. What happens in that scenar...