superreview granted: [Bug 318193] Input streams are not implemented consistently : [Attachment 207422] fix input stream pump assertion [fixed-on-trunk]

Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted
Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net>'s request for
superreview:
Bug 318193: Input streams are not implemented consistently
https://bugzilla.mozilla.org/show_bug.cgi?id=318193

Attachment 207422: fix input stream pump assertion [fixed-on-trunk]
https://bugzilla.mozilla.org/attachment.cgi?id=207422&action=edit

------- Additional Comments from Boris Zbarsky (out of town Dec 12 -- Jan 2)
<bzbarsky@mit.edu>
>Index: nsInputStreamPump.cpp
>+	      PRInt64 offsetBefore = 0;
>	      nsCOMPtr<nsISeekableStream> seekable =
do_QueryInterface(mAsyncStream);
>	      if (seekable)
>		  seekable->Tell(&offsetBefore);

So should we assert that this succeeds?  Or are we assuming that failure will
not modify the out param?  If the latter, I'd really rather we didn't (and set
it to 0 ourselves on failure).

With that nit picked, sr=bzbarsky
0
bugzilla
1/3/2006 9:37:11 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
490 Views

Similar Articles

[PageSpeed] 39
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 318193] Input streams are not implemented consistently : [Attachment 207422] fix input stream pump assertion
Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net> has asked Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> for superreview: Bug 318193: Input streams are not implemented consistently https://bugzilla.mozilla.org/show_bug.cgi?id=318193 Attachment 207422: fix input stream pump assertion https://bugzilla.mozilla.org/attachment.cgi?id=207422&action=edit ------- Additional Comments from Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net> This fixes the problem bclary reported. The solution I chose is to simply bypass the offset comparisi...

superreview granted: [Bug 318193] Input streams are not implemented consistently : [Attachment 207437] fixup nsInputStreamPump.cpp according to bz's review comments
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net>'s request for superreview: Bug 318193: Input streams are not implemented consistently https://bugzilla.mozilla.org/show_bug.cgi?id=318193 Attachment 207437: fixup nsInputStreamPump.cpp according to bz's review comments https://bugzilla.mozilla.org/attachment.cgi?id=207437&action=edit ...

superreview granted: [Bug 318193] Input streams are not implemented consistently : [Attachment 207309] v1.2 patch
Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> has granted Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net>'s request for superreview: Bug 318193: Input streams are not implemented consistently https://bugzilla.mozilla.org/show_bug.cgi?id=318193 Attachment 207309: v1.2 patch https://bugzilla.mozilla.org/attachment.cgi?id=207309&action=edit ------- Additional Comments from Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> >+++ extensions/Makefile.in 1 Jan 2006 19:13:23 >+DIRS = $(MOZ_EXTENSIONS) layout-debug I...

superreview requested: [Bug 318193] Input streams are not implemented consistently : [Attachment 207437] fixup nsInputStreamPump.cpp according to bz's review comments
Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net> has asked Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> for superreview: Bug 318193: Input streams are not implemented consistently https://bugzilla.mozilla.org/show_bug.cgi?id=318193 Attachment 207437: fixup nsInputStreamPump.cpp according to bz's review comments https://bugzilla.mozilla.org/attachment.cgi?id=207437&action=edit ------- Additional Comments from Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net> I also made some small benign changes to the way we get the current ...

superreview granted: [Bug 155957] [FIX]input:before { content: ...; } causes caret placement problems for text inputs : [Attachment 137174] This fixes this bug (well, if I could reprocuce it it shou
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky (not in town, no tree) <bz-vacation@mit.edu>'s request for superreview: Bug 155957: [FIX]input:before { content: ...; } causes caret placement problems for text inputs http://bugzilla.mozilla.org/show_bug.cgi?id=155957 Attachment 137174: This fixes this bug (well, if I could reprocuce it it should ;)) and the dependency... http://bugzilla.mozilla.org/attachment.cgi?id=137174&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> r+sr=dbaron, although this function should real...

superreview cancelled: [Bug 318193] Input streams are not implemented consistently : [Attachment 204500] v1 patch
Darin Fisher <darin@meer.net> has cancelled Darin Fisher <darin@meer.net>'s request for superreview: Bug 318193: Input streams are not implemented consistently https://bugzilla.mozilla.org/show_bug.cgi?id=318193 Attachment 204500: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=204500&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> To boris with love. ...

superreview requested: [Bug 318193] Input streams are not implemented consistently : [Attachment 204500] v1 patch
Darin Fisher <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 318193: Input streams are not implemented consistently https://bugzilla.mozilla.org/show_bug.cgi?id=318193 Attachment 204500: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=204500&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> (same as the v1 patch attached to bug 316372 minus the nsInputStreamChannel.cpp changes.) ...

superreview cancelled: [Bug 318193] Input streams are not implemented consistently : [Attachment 206530] v1.1 patch
Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net> has cancelled Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net>'s request for superreview: Bug 318193: Input streams are not implemented consistently https://bugzilla.mozilla.org/show_bug.cgi?id=318193 Attachment 206530: v1.1 patch https://bugzilla.mozilla.org/attachment.cgi?id=206530&action=edit ...

superreview requested: [Bug 318193] Input streams are not implemented consistently : [Attachment 207309] v1.2 patch
Darin Fisher (on vacation 12/23 - 1/8) <darin@meer.net> has asked Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> for superreview: Bug 318193: Input streams are not implemented consistently https://bugzilla.mozilla.org/show_bug.cgi?id=318193 Attachment 207309: v1.2 patch https://bugzilla.mozilla.org/attachment.cgi?id=207309&action=edit ...

superreview requested: [Bug 318193] Input streams are not implemented consistently : [Attachment 206530] v1.1 patch
Darin Fisher <darin@meer.net> has asked Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu> for superreview: Bug 318193: Input streams are not implemented consistently https://bugzilla.mozilla.org/show_bug.cgi?id=318193 Attachment 206530: v1.1 patch https://bugzilla.mozilla.org/attachment.cgi?id=206530&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> To boris with love. ...

superreview granted: [Bug 287409] loading xml documents from file input stream using nsIDOMParser::parseFromStream fails : [Attachment 178650] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 287409: loading xml documents from file input stream using nsIDOMParser::parseFromStream fails https://bugzilla.mozilla.org/show_bug.cgi?id=287409 Attachment 178650: Fix https://bugzilla.mozilla.org/attachment.cgi?id=178650&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst ...

superreview granted: [Bug 243733] Internally register to handle vCard attachment URLs : [Attachment 149241] the fix...create a vcard stream listener which can turn a stream into vCard UI
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 243733: Internally register to handle vCard attachment URLs http://bugzilla.mozilla.org/show_bug.cgi?id=243733 Attachment 149241: the fix...create a vcard stream listener which can turn a stream into vCard UI http://bugzilla.mozilla.org/attachment.cgi?id=149241&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> one nit: +nsMsgVCardStreamListener::~nsMsgVCardStreamListener() +{ + PR_FREEIF(m_dataBuffer...

superreview granted: [Bug 277482] [FIX]Input field does not get focus set by Javascript on load : [Attachment 173010] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 277482: [FIX]Input field does not get focus set by Javascript on load https://bugzilla.mozilla.org/show_bug.cgi?id=277482 Attachment 173010: Fix https://bugzilla.mozilla.org/attachment.cgi?id=173010&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview granted: [Bug 291078] [FIX]editable text of form input elements rendered outside of element object : [Attachment 245372] Fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 291078: [FIX]editable text of form input elements rendered outside of element object https://bugzilla.mozilla.org/show_bug.cgi?id=291078 Attachment 245372: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245372&action=edit ...

Web resources about - superreview granted: [Bug 318193] Input streams are not implemented consistently : [Attachment 207422] fix input stream pump assertion [fixed-on-trunk] - netscape.mozilla.reviewers

Resources last updated: 12/4/2015 11:44:01 PM