superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch r

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted Masayuki
Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231

Attachment 206229: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit

------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com>
>   var sourceURL = getContentFrameURI(focusedWindow);
>+  var sourceDocument = getContentFrameDocument(focusedWindow);
> 
>   try {
>-    return makeURI(sourceURL);
>+    return makeURI(sourceURL, sourceDocument.characterSet);
Nit: you could replace sourceURL with sourceDocument.location.href thus saving
you the call to getContentFrameURI

>+    var charset = aDocument ? aDocument.characterSet : null;
>+    if (!aDocument && aReferrer)
>+	charset = aReferrer.originCharset;
This is clumsy... I'd use a double ?: or an if/else if/else to select between
aDocument.characterSet and aReferrer.originCharset (or if you're feeling really
leet, aDocument && aDocument.characterSet || aReferrer &&
aReferrer.originCharset).
0
bugzilla
12/21/2005 5:03:26 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
771 Views

Similar Articles

[PageSpeed] 4
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #2
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ...

superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206517] Patch f
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206517: Patch for check-in https://bugzilla.mozilla.org/attachment.cgi?id=206517&action=edit ...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #3
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ...

superreview cancelled: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] Patch
Christian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 201159: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit ------- Additional Comments from Christian Biesinger (:bi) (reviews slower than usual) &l...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] Patch
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 201159: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> This fix this bug. aDocum...

superreview granted: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) https://bugzilla.mozilla.org/show_bug.cgi?id=284276 Attachment 177385: patch https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Seems reasonable ...

superreview requested: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) https://bugzilla.mozilla.org/show_bug.cgi?id=284276 Attachment 177385: patch https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> might that ever change? if not, I'll remove the comment before checking in, then. ...

superreview granted: [Bug 290381] "Save Link As..." doubles the extension if the link contains an escaped hash/pound (#) sign encoded as %23 : [Attachment 191332] xpfe patch v1.4
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 290381: "Save Link As..." doubles the extension if the link contains an escaped hash/pound (#) sign encoded as %23 https://bugzilla.mozilla.org/show_bug.cgi?id=290381 Attachment 191332: xpfe patch v1.4 https://bugzilla.mozilla.org/attachment.cgi?id=191332&action=edit ...

superreview granted: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 176098] Simpler patch
Mike Pinkerton <pinkerton@aol.net> has granted Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 281648: "Download Link Target" results in bad download for large MP3 file. https://bugzilla.mozilla.org/show_bug.cgi?id=281648 Attachment 176098: Simpler patch https://bugzilla.mozilla.org/attachment.cgi?id=176098&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink also fixes the bug where you save the html at www.google.com and instead of saving html we'd get garbage (the gzip'd contentes). ...

superreview cancelled: [Bug 290381] "Save Link As..." doubles the extension if the link contains an escaped hash/pound (#) sign encoded as %23 : [Attachment 191332] xpfe patch v1.4
Christian Biesinger (:bi) <cbiesinger@gmx.at> has cancelled Caleb <bugs.caleb@gmail.com>'s request for superreview: Bug 290381: "Save Link As..." doubles the extension if the link contains an escaped hash/pound (#) sign encoded as %23 https://bugzilla.mozilla.org/show_bug.cgi?id=290381 Attachment 191332: xpfe patch v1.4 https://bugzilla.mozilla.org/attachment.cgi?id=191332&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> sorry, I'm not a super-reviewer... ...

superreview requested: [Bug 290381] "Save Link As..." doubles the extension if the link contains an escaped hash/pound (#) sign encoded as %23 : [Attachment 191332] xpfe patch v1.4
Caleb <bugs.caleb@gmail.com> has asked Christian Biesinger (:bi) <cbiesinger@gmx.at> for superreview: Bug 290381: "Save Link As..." doubles the extension if the link contains an escaped hash/pound (#) sign encoded as %23 https://bugzilla.mozilla.org/show_bug.cgi?id=290381 Attachment 191332: xpfe patch v1.4 https://bugzilla.mozilla.org/attachment.cgi?id=191332&action=edit ...

superreview granted: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 175670] Patch: consult nsIExternalHelperAppService before setting PERSIST_FLAGS_NO_C
Darin Fisher <darin@meer.net> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 281648: "Download Link Target" results in bad download for large MP3 file. https://bugzilla.mozilla.org/show_bug.cgi?id=281648 Attachment 175670: Patch: consult nsIExternalHelperAppService before setting PERSIST_FLAGS_NO_CONVERSION https://bugzilla.mozilla.org/attachment.cgi?id=175670&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> This seems right to me, sr=darin ...

superreview granted: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 153467] set the attachment name as the leaf name of the file
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 242953: an Imported eudora attached file is always named "Attached File" instead of its real name http://bugzilla.mozilla.org/show_bug.cgi?id=242953 Attachment 153467: set the attachment name as the leaf name of the file http://bugzilla.mozilla.org/attachment.cgi?id=153467&action=edit ...

superreview granted: [Bug 261929] Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) : [Attachment 169230] v2 patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 261929: Consider sending urls in UTF-8 by default (images/links with non-ASCII chacters not displayed) https://bugzilla.mozilla.org/show_bug.cgi?id=261929 Attachment 169230: v2 patch https://bugzilla.mozilla.org/attachment.cgi?id=169230&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky ...

Web resources about - superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch r - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 11/24/2015 9:52:36 PM