superreview requested: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control r
Mark Mentovai <mark@moxienet.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> By the time the validate happens, it's too late for us to really care. Might as well leave the re...

superreview granted: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank las
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This will cause me dataloss, because I...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
Asaf Romano <bugs.mano@mail-central.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from Asaf Romano <bugs.mano@mail-central.com> requesting r/sr for your patch. ...

superreview denied: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
jag (Peter Annema) <jag@tty.nl> has denied Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Erh, you shouldn't have to check the autohide pref, if that is set to true, with onl...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank l
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Same as the Firefox imple...

superreview granted: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way
Mike Connor <mconnor@mozilla.com> has granted Seth Spitzer [:ss] <sspitzer@mozilla.com>'s request for superreview: Bug 342105: Close button not shown if there is only one tab https://bugzilla.mozilla.org/show_bug.cgi?id=342105 Attachment 229158: don't treat a single tab in a special way https://bugzilla.mozilla.org/attachment.cgi?id=229158&action=edit ------- Additional Comments from Mike Connor <mconnor@mozilla.com> So, I don't know what error either, and this might be a legacy piece from where I relocated a bunch of that code, but without knowing...

superreview granted: [Bug 243379] mozilla hangs when doing Shift+Tab over an input field : [Attachment 149381] Don't mess with focus changes done by the page when tabbing around.
Brian Ryner (IBM) <bryner@brianryner.com> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 243379: mozilla hangs when doing Shift+Tab over an input field http://bugzilla.mozilla.org/show_bug.cgi?id=243379 Attachment 149381: Don't mess with focus changes done by the page when tabbing around. http://bugzilla.mozilla.org/attachment.cgi?id=149381&action=edit ...

superreview cancelled: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content area
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Simon B�nzli <zeniko@gmail.com>'s request for superreview: Bug 342432: After Undo Close Tab, content area of newly-opened page isn't focused https://bugzilla.mozilla.org/show_bug.cgi?id=342432 Attachment 236968: always focus the reopened tab's content area https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> I can't do superreviews and anyway you don't need them for chrome. You need a toolkit...

superreview requested: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content area
Simon B�nzli <zeniko@gmail.com> has asked Aaron Leventhal <aaronleventhal@moonset.net> for superreview: Bug 342432: After Undo Close Tab, content area of newly-opened page isn't focused https://bugzilla.mozilla.org/show_bug.cgi?id=342432 Attachment 236968: always focus the reopened tab's content area https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit ------- Additional Comments from Simon B�nzli <zeniko@gmail.com> Like this? ...

superreview granted: [Bug 285445] bottom of vertical scroll bar is cut when opening a second tab (new tab causes tab bar to shift page down) : [Attachment 190893] patch
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted David Baron <dbaron@mozillafoundation.org>'s request for superreview: Bug 285445: bottom of vertical scroll bar is cut when opening a second tab (new tab causes tab bar to shift page down) https://bugzilla.mozilla.org/show_bug.cgi?id=285445 Attachment 190893: patch https://bugzilla.mozilla.org/attachment.cgi?id=190893&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> that is correct. ...

superreview granted: [Bug 120148] Tabs don't remember which element [frame, textfield, etc] was focused when switching tabs : [Attachment 132485] Remember where focus is when switching tabs (updated
Brian Ryner <bryner@brianryner.com> has granted hn <tryandguessit@yahoo.com>'s request for superreview: Bug 120148: Tabs don't remember which element [frame, textfield, etc] was focused when switching tabs http://bugzilla.mozilla.org/show_bug.cgi?id=120148 Attachment 132485: Remember where focus is when switching tabs (updated) http://bugzilla.mozilla.org/attachment.cgi?id=132485&action=edit ...

superreview granted: [Bug 356805] Undo close tab doesn't turn the tab bar on : [Attachment 247137] seems to work
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 356805: Undo close tab doesn't turn the tab bar on https://bugzilla.mozilla.org/show_bug.cgi?id=356805 Attachment 247137: seems to work https://bugzilla.mozilla.org/attachment.cgi?id=247137&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ this.removeTab(this.mTabs[0]); // if there's only one tab, it's selected anyway Nit: long line >+ else { Nit: t...

superreview requested: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way
Seth Spitzer [:ss] <sspitzer@mozilla.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 342105: Close button not shown if there is only one tab https://bugzilla.mozilla.org/show_bug.cgi?id=342105 Attachment 229158: don't treat a single tab in a special way https://bugzilla.mozilla.org/attachment.cgi?id=229158&action=edit ------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com> r=sspitzer, seeking sr= from mconnor. ...

superreview granted: [Bug 267188] [MSAA] Expose tab number out of number of tabs in tab description : [Attachment 167693] Don't count on parent being cached. It often isn't.
Brian Ryner (IBM) <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 267188: [MSAA] Expose tab number out of number of tabs in tab description https://bugzilla.mozilla.org/show_bug.cgi?id=267188 Attachment 167693: Don't count on parent being cached. It often isn't. https://bugzilla.mozilla.org/attachment.cgi?id=167693&action=edit ...