superreview requested: [Bug 299838] BiDi: Caret disappears outside the end of lines that end with spaces (when such lines are part of an overflowing paragraph) : [Attachment 188448] patchUri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell)
<roc@ocallahan.org> for superreview:
Bug 299838: BiDi: Caret disappears outside the end of lines that end with
spaces (when such lines are part of an overflowing paragraph)
https://bugzilla.mozilla.org/show_bug.cgi?id=299838
Attachment 188448: patch
https://bugzilla.mozilla.org/attachment.cgi?id=188448&action=edit
------- Additional Comments from Uri Bernstein <uriber@gmail.com>
Handle the RTL case similarly to the way the LTR case is handled. This should
have been included in the fix f...
superreview granted: [Bug 299622] BiDi: Pressing End in a blank line moves the caret back, to the end of the previous line : [Attachment 193559] patchRobert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein
<uriber@gmail.com>'s request for superreview:
Bug 299622: BiDi: Pressing End in a blank line moves the caret back, to the end
of the previous line
https://bugzilla.mozilla.org/show_bug.cgi?id=299622
Attachment 193559: patch
https://bugzilla.mozilla.org/attachment.cgi?id=193559&action=edit
...
superreview granted: [Bug 330461] Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text :Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein
<uriber@gmail.com>'s request for superreview:
Bug 330461: Bidi: In a line ending with reverse-direction text, "End" does not
move the caret to the visual end of the line, if the next line starts with
reverse-direction text
https://bugzilla.mozilla.org/show_bug.cgi?id=330461
Attachment 232681: patch v2
https://bugzilla.mozilla.org/attachment.cgi?id=232681&action=edit
...
superreview requested: [Bug 299622] BiDi: Pressing End in a blank line moves the caret back, to the end of the previous line : [Attachment 193559] patchUri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell)
<roc@ocallahan.org> for superreview:
Bug 299622: BiDi: Pressing End in a blank line moves the caret back, to the end
of the previous line
https://bugzilla.mozilla.org/show_bug.cgi?id=299622
Attachment 193559: patch
https://bugzilla.mozilla.org/attachment.cgi?id=193559&action=edit
------- Additional Comments from Uri Bernstein <uriber@gmail.com>
ROC - this is a bit of code removal which makes things look neater and work
better. Don't worry - I won't ask for this to go into the br...
superreview granted: [Bug 305083] [regression] When using ctrl+right-arrow on last word in a wrapping line, caret moves to end of line instead of to beginning of next line : [Attachment 193151] patchRobert O'Callahan (Novell) <roc@ocallahan.org> has granted Eyal Rozenberg
<eyalroz@technion.ac.il>'s request for superreview:
Bug 305083: [regression] When using ctrl+right-arrow on last word in a wrapping
line, caret moves to end of line instead of to beginning of next line
https://bugzilla.mozilla.org/show_bug.cgi?id=305083
Attachment 193151: patch
https://bugzilla.mozilla.org/attachment.cgi?id=193151&action=edit
------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org>
alright. Let's do it. But if the going gets tough, ...
superreview cancelled: [Bug 330461] Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction textUri Bernstein <uriber@gmail.com> has cancelled Uri Bernstein
<uriber@gmail.com>'s request for superreview:
Bug 330461: Bidi: In a line ending with reverse-direction text, "End" does not
move the caret to the visual end of the line, if the next line starts with
reverse-direction text
https://bugzilla.mozilla.org/show_bug.cgi?id=330461
Attachment 218353: patch
https://bugzilla.mozilla.org/attachment.cgi?id=218353&action=edit
------- Additional Comments from Uri Bernstein <uriber@gmail.com>
Actually, upon further consideration, I don't think th...
superreview requested: [Bug 330461] Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text #3Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell)
<roc@ocallahan.org> for superreview:
Bug 330461: Bidi: In a line ending with reverse-direction text, "End" does not
move the caret to the visual end of the line, if the next line starts with
reverse-direction text
https://bugzilla.mozilla.org/show_bug.cgi?id=330461
Attachment 218353: patch
https://bugzilla.mozilla.org/attachment.cgi?id=218353&action=edit
...
superreview requested: [Bug 330461] Bidi: In a line ending with reverse-direction text, "End" does not move the caret to the visual end of the line, if the next line starts with reverse-direction text #2Uri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell)
<roc@ocallahan.org> for superreview:
Bug 330461: Bidi: In a line ending with reverse-direction text, "End" does not
move the caret to the visual end of the line, if the next line starts with
reverse-direction text
https://bugzilla.mozilla.org/show_bug.cgi?id=330461
Attachment 232681: patch v2
https://bugzilla.mozilla.org/attachment.cgi?id=232681&action=edit
...
superreview granted: [Bug 143996] in caret browsing, home/end must go to start/end of line : [Attachment 169886] patch v2 (whitespace cleanup)neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Ginn Chen
<ginn.chen@sun.com>'s request for superreview:
Bug 143996: in caret browsing, home/end must go to start/end of line
https://bugzilla.mozilla.org/show_bug.cgi?id=143996
Attachment 169886: patch v2 (whitespace cleanup)
https://bugzilla.mozilla.org/attachment.cgi?id=169886&action=edit
...
superreview granted: [Bug 336590] Caret can not be placed after [space] at the end of a wrapped line in textarea, using the mouse : [Attachment 221091] patchRobert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein
<uriber@gmail.com>'s request for superreview:
Bug 336590: Caret can not be placed after [space] at the end of a wrapped line
in textarea, using the mouse
https://bugzilla.mozilla.org/show_bug.cgi?id=336590
Attachment 221091: patch
https://bugzilla.mozilla.org/attachment.cgi?id=221091&action=edit
...
superreview requested: [Bug 143996] in caret browsing, home/end must go to start/end of line : [Attachment 169886] patch v2 (whitespace cleanup)Ginn Chen <ginn.chen@sun.com> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 143996: in caret browsing, home/end must go to start/end of line
https://bugzilla.mozilla.org/show_bug.cgi?id=143996
Attachment 169886: patch v2 (whitespace cleanup)
https://bugzilla.mozilla.org/attachment.cgi?id=169886&action=edit
...
superreview granted: [Bug 302051] Bidi: "Home" on line containing only text in reverse direction causes caret to be displayed on different line : [Attachment 229877] patch?!Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Uri Bernstein
<uriber@gmail.com>'s request for superreview:
Bug 302051: Bidi: "Home" on line containing only text in reverse direction
causes caret to be displayed on different line
https://bugzilla.mozilla.org/show_bug.cgi?id=302051
Attachment 229877: patch?!
https://bugzilla.mozilla.org/attachment.cgi?id=229877&action=edit
------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org>
+ if ((embeddingLevel & 1) && !lineIsRTL || !(embeddingLevel &...
superreview granted: [Bug 275672] Right-most character (that means end of line) should not have extra space for justify : [Attachment 170720] Patch rv1.1Robert O'Callahan (out of action until mid-January) <roc@ocallahan.org> has
granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for
superreview:
Bug 275672: Right-most character (that means end of line) should not have extra
space for justify
https://bugzilla.mozilla.org/show_bug.cgi?id=275672
Attachment 170720: Patch rv1.1
https://bugzilla.mozilla.org/attachment.cgi?id=170720&action=edit
------- Additional Comments from Robert O'Callahan (out of action until
mid-January) <roc@ocallahan.org>
GREAT! Thanks.
When this gets ...
superreview requested: [Bug 336590] Caret can not be placed after [space] at the end of a wrapped line in textarea, using the mouse : [Attachment 221091] patchUri Bernstein <uriber@gmail.com> has asked Robert O'Callahan (Novell)
<roc@ocallahan.org> for superreview:
Bug 336590: Caret can not be placed after [space] at the end of a wrapped line
in textarea, using the mouse
https://bugzilla.mozilla.org/show_bug.cgi?id=336590
Attachment 221091: patch
https://bugzilla.mozilla.org/attachment.cgi?id=221091&action=edit
------- Additional Comments from Uri Bernstein <uriber@gmail.com>
nsTypedSelection::setAnchorFocusRange() turned out not to be the right place
for fixing bug 334256. The click case reaches this method vi...