superreview granted: [Bug 298807] nsIBookmarksService::ResolveKeyword can make a better use of strings : [Attachment 188012] patch (use AString)

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jungshik
Shin <jshin1987@gmail.com>'s request for superreview:
Bug 298807: nsIBookmarksService::ResolveKeyword can make a better use of
strings
https://bugzilla.mozilla.org/show_bug.cgi?id=298807

Attachment 188012: patch (use AString)
https://bugzilla.mozilla.org/attachment.cgi?id=188012&action=edit

------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
>-	      nsDependentString postDataStr(postDataVal);
>-	      *aPostData = ToNewUnicode(postDataStr);
>+	      aPostData = postDataVal;
I note that the original author of the code failed to follow XPCOM rules and
only set aPostData when they felt like it...
0
bugzilla
7/2/2005 9:26:04 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
635 Views

Similar Articles

[PageSpeed] 57
Get it on Google Play
Get it on Apple App Store

Reply: