superreview requested: [Bug 296520] Mails incorrectly deleted when using "Delete messages more than xx days" : [Attachment 185269] fix
David Bienvenu <bienvenu@nventure.com> has asked Seth Spitzer (not reading bugmail) <sspitzer@mozilla.org> for superreview: Bug 296520: Mails incorrectly deleted when using "Delete messages more than xx days" https://bugzilla.mozilla.org/show_bug.cgi?id=296520 Attachment 185269: fix https://bugzilla.mozilla.org/attachment.cgi?id=185269&action=edit ...

superreview cancelled: [Bug 323109] deleted attachment: "Deleted: " vs "Deleted:", not localizable : [Attachment 210044] proposed fix
Magnus Melin <mkmelin+mozilla@iki.fi> has cancelled David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 323109: deleted attachment: "Deleted: " vs "Deleted:", not localizable https://bugzilla.mozilla.org/show_bug.cgi?id=323109 Attachment 210044: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=210044&action=edit ...

superreview granted: [Bug 217299] "Delete Mail marked as Junk in Folder" very slow with large number of messages : [Attachment 130552] speed up post delete processing
Scott MacGregor <scott@scott-macgregor.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 217299: "Delete Mail marked as Junk in Folder" very slow with large number of messages http://bugzilla.mozilla.org/show_bug.cgi?id=217299 Attachment 130552: speed up post delete processing http://bugzilla.mozilla.org/attachment.cgi?id=130552&action=edit ...

superreview granted: [Bug 339116] account Junk settings: can't change "automatically delete messages older than 14 days" : [Attachment 223195] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 339116: account Junk settings: can't change "automatically delete messages older than 14 days" https://bugzilla.mozilla.org/show_bug.cgi?id=339116 Attachment 223195: the fix https://bugzilla.mozilla.org/attachment.cgi?id=223195&action=edit ...

superreview granted: [Bug 242744] Junk mail preference delete junk after x days doesn't work if "Junk Purge" is enabled for multiple accounts : [Attachment 167263] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 242744: Junk mail preference delete junk after x days doesn't work if "Junk Purge" is enabled for multiple accounts https://bugzilla.mozilla.org/show_bug.cgi?id=242744 Attachment 167263: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=167263&action=edit ...

superreview granted: [Bug 242600] "Edit" message filter after "Run Message Filter" causes Mozilla crash
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 242600: "Edit" message filter after "Run Message Filter" causes Mozilla crash - Trunk TB11a1 [@ nsMsgFilter::GetFilterList] https://bugzilla.mozilla.org/show_bug.cgi?id=242600 Attachment 186159: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=186159&action=edit ...

superreview granted: [Bug 239349] Junk Filter incorrectly marks mails as junk, no junk icon in summary pane, junk icon in header pane (IMAP only?). "Delete mail marked as junk" deletes legitimate e-ma
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 239349: Junk Filter incorrectly marks mails as junk, no junk icon in summary pane, junk icon in header pane (IMAP only?). "Delete mail marked as junk" deletes legitimate e-mail (Dataloss) http://bugzilla.mozilla.org/show_bug.cgi?id=239349 Attachment 145365: the fix (add some missing break statements) http://bugzilla.mozilla.org/attachment.cgi?id=145365&action=edit ...

superreview granted: [Bug 257338] "Delete Host" and "Delete Domain" features of the History Window do not work : [Attachment 157336] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 257338: "Delete Host" and "Delete Domain" features of the History Window do not work http://bugzilla.mozilla.org/show_bug.cgi?id=257338 Attachment 157336: Patch http://bugzilla.mozilla.org/attachment.cgi?id=157336&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> sr=me assuming bsmedberg confirms that this is the correct solut...

superreview granted: [Bug 350242] "delete 0x11.x" decompiles incorrectly : [Attachment 235535] fix
Mike Shaver <shaver@mozilla.org> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 350242: "delete 0x11.x" decompiles incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=350242 Attachment 235535: fix https://bugzilla.mozilla.org/attachment.cgi?id=235535&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> sr=shaver ...

superreview granted: [Bug 303786] "Delete Message" filter action missing for IMAP and Newsgroups : [Attachment 192001] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 303786: "Delete Message" filter action missing for IMAP and Newsgroups https://bugzilla.mozilla.org/show_bug.cgi?id=303786 Attachment 192001: the fix https://bugzilla.mozilla.org/attachment.cgi?id=192001&action=edit ...

superreview granted: [Bug 217299] "Delete Mail marked as Junk in Folder" crashes MailNews : [Attachment 130475] proposed fix
Scott MacGregor <scott@scott-macgregor.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 217299: "Delete Mail marked as Junk in Folder" crashes MailNews http://bugzilla.mozilla.org/show_bug.cgi?id=217299 Attachment 130475: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=130475&action=edit ...

superreview granted: [Bug 257990] Integrate Junk Mail settings into "Options" and "Account Settings" : [Attachment 220151] updated fix with review comments
Scott MacGregor <mscott@mozilla.org> has granted superreview: Bug 257990: Integrate Junk Mail settings into "Options" and "Account Settings" https://bugzilla.mozilla.org/show_bug.cgi?id=257990 Attachment 220151: updated fix with review comments https://bugzilla.mozilla.org/attachment.cgi?id=220151&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward david's sr and neil's r. ...

superreview granted: [Bug 448558] Deleting multiple mails from Junk ends in "The current command did not succeed" (IMAP) : [Attachment 331801] possible fix
neil@parkwaycc.co.uk <neil@httl.net> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 448558: Deleting multiple mails from Junk ends in "The current command did not succeed" (IMAP) https://bugzilla.mozilla.org/show_bug.cgi?id=448558 Attachment 331801: possible fix https://bugzilla.mozilla.org/attachment.cgi?id=331801&action=edit ...

superreview granted: [Bug 230108] Deleting Account gives incorrect error message "Failed to remove this account." : [Attachment 138486] Includes my other two nits
David Bienvenu <bienvenu@nventure.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 230108: Deleting Account gives incorrect error message "Failed to remove this account." http://bugzilla.mozilla.org/show_bug.cgi?id=230108 Attachment 138486: Includes my other two nits http://bugzilla.mozilla.org/attachment.cgi?id=138486&action=edit ...