superreview granted: [Bug 293350] Allow dynamic changes of notification callbacks (was: Don't show download status in status bar (since it shows in the DL manager)) : [Attachment 194557] v1 patch

Boris Zbarsky <bzbarsky@mit.edu> has granted Darin Fisher <darin@meer.net>'s
request for superreview:
Bug 293350: Allow dynamic changes of notification callbacks (was: Don't show
download status in status bar (since it shows in the DL manager))
https://bugzilla.mozilla.org/show_bug.cgi?id=293350

Attachment 194557: v1 patch
https://bugzilla.mozilla.org/attachment.cgi?id=194557&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
>Index: netwerk/base/public/nsIChannel.idl
>+     * listener as it becomes available.  The stream listener's methods are
>+     * called via an event dispatched through the event queue service on the
>+     * same thread that called asyncOpen.

How about just:

  The stream listener's methods are called on the thread that
  asyncOpen was called on.

because if a channel runs entirely on one thread there is no pressing need for
it to call these methods via an event, really...

Unless you're trying to emphasize that asyncOpen will return before
OnStartRequest is called, in which case we should perhaps just state that
explicitly.

The rest looks great.  sr=bzbarsky.
0
bugzilla
9/2/2005 2:21:02 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
738 Views

Similar Articles

[PageSpeed] 32
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 293350] Don't show download status in status bar (since it shows in the DL manager) : [Attachment 194557] v1 patch
Darin Fisher <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 293350: Don't show download status in status bar (since it shows in the DL manager) https://bugzilla.mozilla.org/show_bug.cgi?id=293350 Attachment 194557: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=194557&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Fixes most channels. I left out changes to nsMsgProtocol and nsLDAPChannel because 1) they don't apply to this bug and 2) it isn't obvious how to fix them or if it ...

superreview granted: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true; " --> status bar doesn't show url for links)
Boris Zbarsky <bzbarsky@mit.edu> has granted Florian Qu=C3=A8ze <f.qu@queze= ..net>'s request for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar emp= ty for links (onmouseover=3D"return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=3D40838 Attachment 262459: patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=3D262459&action=3Dedit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: base/src/nsGenericElement.cpp=...

superreview denied: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) : [Attachment 19605
Boris Zbarsky <bzbarsky@mit.edu> has denied Florian QUEZE <f.qu@laposte.net>'s request for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=40838 Attachment 196055: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=196055&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Fair enough. Let's do that, then. I like that better t...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) : [Attachment 19
Florian QUEZE <f.qu@laposte.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=40838 Attachment 196055: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=196055&action=edit ...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) : [Attachment 20 #3
Florian Qu�ze <f.qu@queze.net> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=40838 Attachment 201286: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=201286&action=edit ...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) : [Attachment 20 #2
Florian Qu�ze <f.qu@queze.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=40838 Attachment 201286: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=201286&action=edit ------- Additional Comments from Florian Qu�ze <f.qu@queze.net> New patch following the idea "set the status bar text before the event is ...

superreview cancelled: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true; " --> status bar doesn't show url for links)
Florian Qu=C3=A8ze <f.qu@queze.net> has cancelled Florian Qu=C3=A8ze <f.qu@= queze.net>'s request for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar emp= ty for links (onmouseover=3D"return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=3D40838 Attachment 201286: patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=3D201286&action=3Dedit= ...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true; " --> status bar doesn't show url for links)
Florian Qu=C3=A8ze <f.qu@queze.net> has asked Boris Zbarsky <bzbarsky@mit.e= du> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar emp= ty for links (onmouseover=3D"return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=3D40838 Attachment 262435: patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D262435&action=3Dedit= ...

superreview denied: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true; " --> status bar doesn't show url for links)
Boris Zbarsky <bzbarsky@mit.edu> has denied Florian Qu=C3=A8ze <f.qu@queze.= net>'s request for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar emp= ty for links (onmouseover=3D"return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=3D40838 Attachment 262435: patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D262435&action=3Dedit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> For future reference, please use more conte...

superreview requested: [Bug 40838] disallowing "change status bar text" often leaves status bar empty for links (onmouseover="return true; " --> status bar doesn't show url for links) #2
Florian Qu=C3=A8ze <f.qu@queze.net> has asked Boris Zbarsky <bzbarsky@mit.e= du> for superreview: Bug 40838: disallowing "change status bar text" often leaves status bar emp= ty for links (onmouseover=3D"return true;" --> status bar doesn't show url for links) https://bugzilla.mozilla.org/show_bug.cgi?id=3D40838 Attachment 262459: patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=3D262459&action=3Dedit= ...

superreview denied: [Bug 271621] Dark line at top of status bar doesn't show. : [Attachment 176522] stab v1.0
Simon Fraser <sfraser_bugs@smfr.org> has denied Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 271621: Dark line at top of status bar doesn't show. https://bugzilla.mozilla.org/show_bug.cgi?id=271621 Attachment 176522: stab v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=176522&action=edit ------- Additional Comments from Simon Fraser <sfraser_bugs@smfr.org> You need to specify a color. ...

superreview requested: [Bug 271621] Dark line at top of status bar doesn't show. : [Attachment 176522] stab v1.0
Josh Aas <joshmoz@gmail.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 271621: Dark line at top of status bar doesn't show. https://bugzilla.mozilla.org/show_bug.cgi?id=271621 Attachment 176522: stab v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=176522&action=edit ------- Additional Comments from Josh Aas <joshmoz@gmail.com> I think "stab v1.0" is actually the right thing to do. We should probably have the status bar draw its own separator if for no other reason than that it makes hiding the status bar in the fut...

superreview denied: [Bug 271621] Dark line at top of status bar doesn't show. : [Attachment 176522] stab v1.0 #2
Josh Aas <joshmoz@gmail.com> has denied Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 271621: Dark line at top of status bar doesn't show. https://bugzilla.mozilla.org/show_bug.cgi?id=271621 Attachment 176522: stab v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=176522&action=edit ------- Additional Comments from Josh Aas <joshmoz@gmail.com> arg - cancelled the wrong review ...

superreview granted: [Bug 412360] Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite : [Attachment 306041] v1
Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak) <edilee@gmail.com>'s request for superreview: Bug 412360: Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite https://bugzilla.mozilla.org/show_bug.cgi?id=3D412360 Attachment 306041: v1 https://bugzilla.mozilla.org/attachment.cgi?id=3D306041&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> + SendErrorStatusChange(PR_TRUE, rv, nsnull, aFile);=0D =0D hmm... why not pass the channel here instead o...

Web resources about - superreview granted: [Bug 293350] Allow dynamic changes of notification callbacks (was: Don't show download status in status bar (since it shows in the DL manager)) : [Attachment 194557] v1 patch - netscape.mozilla.reviewers

Fire alarm notification appliance - Wikipedia, the free encyclopedia
A fire alarm notification appliance is an active fire protection component. A notification appliance may use audible, visible, or other stimuli ...

Facebook To Allow Users To Opt Out Of Notifications Directly Via Drop-Down Menu
Facebook continues to give its users more and easier controls over the notifications they receive, announcing Wednesday that it will implement ...

Delayed Australian data breach notification bill lands
Australians will be informed of certain breaches of their personal information under new laws being proposed by the Turnbull government, but ...

Chrome 47 released to stable channel, removes rarely used notification center
The stable channel for Chrome has been updated to version 47 on Windows, Mac, and Linux. The update contains the usual fixes and improvements, ...

Facebook Introduces Notify, a News App Designed to Make Your Other Notifications Obsolete
... Notify, which will alert users with information from media companies including CNN, The Weather Channel, Fox Sports and Fandango. Its notifications ...

Facebook Really Doesn’t Want You to Miss a Post or Notification
Facebook is apparently testing new ways to get you to read content you may have missed . Some users are seeing notifications (right) of group ...

Facebook launches Notify: a notifications app for news you care about
... network, has brought another new application to the App Store. This time, Zuckerberg et al. are looking to solve the problem of news notifications ...

Apple invention lets users control time-sensitive notifications with their eyes
... so-called "gaze detection" technology, particularly as a means to control certain user interface events like autocorrect pop-ups, app notifications ...

How to use your iPhone’s camera flash as a notification light
... was plenty to love about BlackBerry phones back then, but there was one feature in particular that people hated to love: the flashing LED notification ...

Apple's new patent wants you to control notifications with your eyes
Notifications on your iPhone might one day respond to your gaze. Apple has been granted a patent for the "delay of display event based on user ...

Resources last updated: 12/9/2015 9:48:40 AM