superreview requested: [Bug 288532] OOM crash [@ XPCConvert::JSErrorToXPCException] : [Attachment 179228] don't leak and don't crash
timeless@myrealbox.com (working) <timeless@bemail.org> has asked rbs@maths.uq.edu.au for superreview: Bug 288532: OOM crash [@ XPCConvert::JSErrorToXPCException] https://bugzilla.mozilla.org/show_bug.cgi?id=288532 Attachment 179228: don't leak and don't crash https://bugzilla.mozilla.org/attachment.cgi?id=179228&action=edit ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview granted: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to cre
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview granted: [Bug 333579] Firefox crash with Window-Eyes and DHTML/AJAX : [Attachment 228812] Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree,
neil@parkwaycc.co.uk <neil@httl.net> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 333579: Firefox crash with Window-Eyes and DHTML/AJAX https://bugzilla.mozilla.org/show_bug.cgi?id=333579 Attachment 228812: Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree, 2) Don't refer to |this| in area constructor, Init() from outside as other accessibles do https://bugzilla.mozilla.org/attachment.cgi?id=228812&action=edit ------- Additional Comments from neil@parkwaycc.co....

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #3
Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #2
Aaron Leventhal (vacation: mostly gone until Oct 17) <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...

superreview granted: [Bug 302724] nsHostRecord and nsHostResolver are refcounted but don't log : [Attachment 203288] don't put negative numbers into the leak stats
Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron <dbaron@mozilla.com>'s request for superreview: Bug 302724: nsHostRecord and nsHostResolver are refcounted but don't log https://bugzilla.mozilla.org/show_bug.cgi?id=302724 Attachment 203288: don't put negative numbers into the leak stats https://bugzilla.mozilla.org/attachment.cgi?id=203288&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Doh. Thanks for catching this! ...

superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
Johnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

superreview granted: [Bug 313347] Flash plugin crashes browser on Intel Mac OS X : [Attachment 201379] Don't free TVector glue that wasn't allocated
Simon Fraser <sfraser_bugs@smfr.org> has granted Simon Fraser <sfraser_bugs@smfr.org>'s request for superreview: Bug 313347: Flash plugin crashes browser on Intel Mac OS X https://bugzilla.mozilla.org/show_bug.cgi?id=313347 Attachment 201379: Don't free TVector glue that wasn't allocated https://bugzilla.mozilla.org/attachment.cgi?id=201379&action=edit ...

superreview requested: [Bug 333579] Firefox crash with Window-Eyes and DHTML/AJAX : [Attachment 228812] Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tre
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 333579: Firefox crash with Window-Eyes and DHTML/AJAX https://bugzilla.mozilla.org/show_bug.cgi?id=333579 Attachment 228812: Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree, 2) Don't refer to |this| in area constructor, Init() from outside as other accessibles do https://bugzilla.mozilla.org/attachment.cgi?id=228812&action=edit ...

superreview granted: [Bug 258386] Crash hitting 'b' when on the first message in a mailbox : [Attachment 158171] Don't access array item at index -1
Scott MacGregor <mscott@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 258386: Crash hitting 'b' when on the first message in a mailbox http://bugzilla.mozilla.org/show_bug.cgi?id=258386 Attachment 158171: Don't access array item at index -1 http://bugzilla.mozilla.org/attachment.cgi?id=158171&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Thanks for taking the time to file this and even better, fix it Johnny. ...

superreview granted: [Bug 248442] Crash in form autocomplete (64-bit arch only) : [Attachment 151580] Pass in the correct size, and don't waste time sorting n' allocing when there's nothing to sort..
David Baron <dbaron@dbaron.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 248442: Crash in form autocomplete (64-bit arch only) http://bugzilla.mozilla.org/show_bug.cgi?id=248442 Attachment 151580: Pass in the correct size, and don't waste time sorting n' allocing when there's nothing to sort... (diff -w) http://bugzilla.mozilla.org/attachment.cgi?id=151580&action=edit ...