superreview requested: [Bug 287979] Infinite loop caused by the way we expose native objects as IAccessibles : [Attachment 178763] 1) The child of the Mozilla plugin window container is the window owAaron Leventhal <aaronleventhal@moonset.net> has asked Johnny Stenback
<jst@mozilla.org> for superreview:
Bug 287979: Infinite loop caused by the way we expose native objects as
IAccessibles
https://bugzilla.mozilla.org/show_bug.cgi?id=287979
Attachment 178763: 1) The child of the Mozilla plugin window container is the
window owning the plugin, 2) Null plugins are no longer native objects, and
this solves the infinite loop in a more generic way anyway
https://bugzilla.mozilla.org/attachment.cgi?id=178763&action=edit
...
superreview granted: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173746] patchT Rowley (IBM) <tor@acm.org> has granted Christian Biesinger (:bi)
<cbiesinger@gmx.at>'s request for superreview:
Bug 250936: Non distributed image formats opens many mozilla windows until
crashed (infinite/eternal window opening loop)
https://bugzilla.mozilla.org/show_bug.cgi?id=250936
Attachment 173746: patch
https://bugzilla.mozilla.org/attachment.cgi?id=173746&action=edit
...
superreview granted: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173795] equivalent for firefoxDarin Fisher <darin@meer.net> has granted T Rowley (IBM) <tor@acm.org>'s
request for superreview:
Bug 250936: Non distributed image formats opens many mozilla windows until
crashed (infinite/eternal window opening loop)
https://bugzilla.mozilla.org/show_bug.cgi?id=250936
Attachment 173795: equivalent for firefox
https://bugzilla.mozilla.org/attachment.cgi?id=173795&action=edit
------- Additional Comments from Darin Fisher <darin@meer.net>
>Index: nsBrowserContentHandler.js
> const nsIPrefBranch = Components.interfaces.nsIPrefBranch;
> c...
superreview granted: [Bug 29856] *nix only : Window Class the same for all mozilla windows : [Attachment 183281] Combined earlier patches for 1.7.7/8Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview:
Bug 29856: *nix only : Window Class the same for all mozilla windows
https://bugzilla.mozilla.org/show_bug.cgi?id=29856
Attachment 183281: Combined earlier patches for 1.7.7/8
https://bugzilla.mozilla.org/attachment.cgi?id=183281&action=edit
------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org>
r+sr on the gtk2 changes. I will check this in, GTK2 only.
...
superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173746] patchChristian Biesinger (:bi) <cbiesinger@gmx.at> has asked T Rowley (IBM)
<tor@acm.org> for superreview:
Bug 250936: Non distributed image formats opens many mozilla windows until
crashed (infinite/eternal window opening loop)
https://bugzilla.mozilla.org/show_bug.cgi?id=250936
Attachment 173746: patch
https://bugzilla.mozilla.org/attachment.cgi?id=173746&action=edit
...
superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173795] equivalent for firefoxT Rowley (IBM) <tor@acm.org> has asked Darin Fisher <darin@meer.net> for
superreview:
Bug 250936: Non distributed image formats opens many mozilla windows until
crashed (infinite/eternal window opening loop)
https://bugzilla.mozilla.org/show_bug.cgi?id=250936
Attachment 173795: equivalent for firefox
https://bugzilla.mozilla.org/attachment.cgi?id=173795&action=edit
...
superreview granted: [Bug 207742] Mozilla crash after closing blank window created when exiting screensaver : [Attachment 127214] invisible window cannot be made visible (Windows OS)Brian Ryner <bryner@netscape.com> has granted danm@netscape.com's request for
superreview:
Bug 207742: Mozilla crash after closing blank window created when exiting
screensaver
http://bugzilla.mozilla.org/show_bug.cgi?id=207742
Attachment 127214: invisible window cannot be made visible (Windows OS)
http://bugzilla.mozilla.org/attachment.cgi?id=127214&action=edit
------- Additional Comments from Brian Ryner <bryner@netscape.com>
Looks ok. sr=bryner.
...
superreview granted: [Bug 196670] JNG images crash Mozilla on Windows[@ mng_add_chunk ] : [Attachment 129051] Patch to work around Microsoft compiler bug that causes JNG crash <rbs@maths.uq.edu.au> has granted Glenn Randers-Pehrson (pls fix bug#196670)
<glennrp@imagemagick.org>'s request for superreview:
Bug 196670: JNG images crash Mozilla on Windows[@ mng_add_chunk ]
http://bugzilla.mozilla.org/show_bug.cgi?id=196670
Attachment 129051: Patch to work around Microsoft compiler bug that causes JNG crash
http://bugzilla.mozilla.org/attachment.cgi?id=129051&action=edit
------- Additional Comments from <rbs@maths.uq.edu.au>
sr=rbs
...
superreview granted: [Bug 234046] Mozilla 1.6 search plugin for mozilla.org points to a non-existent search page : [Attachment 145494] trying againT Rowley (IBM) <tor@acm.org> has granted Matti (Matthias "hating marquee"
Versen) <matti@mversen.de>'s request for superreview:
Bug 234046: Mozilla 1.6 search plugin for mozilla.org points to a non-existent
search page
http://bugzilla.mozilla.org/show_bug.cgi?id=234046
Attachment 145494: trying again
http://bugzilla.mozilla.org/attachment.cgi?id=145494&action=edit
...
superreview granted: [Bug 283342] Many windows don't set window classes : [Attachment 197950] Patch to add a window class to the Default Plugin's windowJohnny Stenback (:jst) <jst@mozilla.org> has granted superreview:
Bug 283342: Many windows don't set window classes
https://bugzilla.mozilla.org/show_bug.cgi?id=283342
Attachment 197950: Patch to add a window class to the Default Plugin's window
https://bugzilla.mozilla.org/attachment.cgi?id=197950&action=edit
...
superreview granted: [Bug 284661] JavaScript-based extension opens chrome window -- window looks strange then Mozilla crashes [@ nsFontMetricsXft::FindFont] : [Attachment 179023] fixChristopher Blizzard <blizzard@mozilla.org> has granted Robert O'Callahan
(Novell) <roc@ocallahan.org>'s request for superreview:
Bug 284661: JavaScript-based extension opens chrome window -- window looks
strange then Mozilla crashes [@ nsFontMetricsXft::FindFont]
https://bugzilla.mozilla.org/show_bug.cgi?id=284661
Attachment 179023: fix
https://bugzilla.mozilla.org/attachment.cgi?id=179023&action=edit
...
superreview requested: [Bug 244193] Giving out the wrong IAccessible for top Mozilla content and UI windows : [Attachment 148957] This patch makes us work with Window-Eyes, at least partiallyAaron Leventhal <aaronleventhal@moonset.net> has asked Robert O'Callahan
<roc@ocallahan.org> for superreview:
Bug 244193: Giving out the wrong IAccessible for top Mozilla content and UI
windows
http://bugzilla.mozilla.org/show_bug.cgi?id=244193
Attachment 148957: This patch makes us work with Window-Eyes, at least
partially
http://bugzilla.mozilla.org/attachment.cgi?id=148957&action=edit
------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net>
This is a followup to the mousepad scroll bug that also fixes screen reader
support.
...
superreview cancelled: [Bug 244193] Giving out the wrong IAccessible for top Mozilla content and UI windows : [Attachment 148957] This patch makes us work with Window-Eyes, at least partiallyAaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 244193: Giving out the wrong IAccessible for top Mozilla content and UI
windows
http://bugzilla.mozilla.org/show_bug.cgi?id=244193
Attachment 148957: This patch makes us work with Window-Eyes, at least
partially
http://bugzilla.mozilla.org/attachment.cgi?id=148957&action=edit
...
superreview requested: [Bug 291077] get_accParent() jumps to top level window object too soon, and loops, causing crashes : [Attachment 192733] Change get_accParent() algorithm to get window accessibAaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky (gone till
Aug 14) <bzbarsky@mit.edu> for superreview:
Bug 291077: get_accParent() jumps to top level window object too soon, and
loops, causing crashes
https://bugzilla.mozilla.org/show_bug.cgi?id=291077
Attachment 192733: Change get_accParent() algorithm to get window accessible
when the current frame has a window. Get the parent window with the scrollbars
if there are two windows used.
https://bugzilla.mozilla.org/attachment.cgi?id=192733&action=edit
------- Additional Comments from Aaron Leven...