superreview granted: [Bug 216705] Mozilla crashes after trying to open another message : [Attachment 130152] proposed fix
Scott MacGregor <scott@scott-macgregor.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 216705: Mozilla crashes after trying to open another message http://bugzilla.mozilla.org/show_bug.cgi?id=216705 Attachment 130152: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=130152&action=edit ...

superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Johnny Stenback <jst@mozilla.jstenback.com> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> I wasn't able to test this or run with it, but the change looks good. Hopefully someone else is able to ve...

superreview granted: [Bug 280901] Mozilla build fails when trying to build in mozilla/extensions/spellcheck/myspell/src directory. : [Attachment 173252] Suggested fix
Scott MacGregor <mscott@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 280901: Mozilla build fails when trying to build in mozilla/extensions/spellcheck/myspell/src directory. https://bugzilla.mozilla.org/show_bug.cgi?id=280901 Attachment 173252: Suggested fix https://bugzilla.mozilla.org/attachment.cgi?id=173252&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> These files are direct copies from the Open Office.org CVS repository which hosts the myspell engine that we also use. We ...

superreview granted: [Bug 265135] Can't install extensions from update.mozilla.org (whitelist) : [Attachment 163106] Fix null-referrer crash
Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz <dveditz@cruzio.com>'s request for superreview: Bug 265135: Can't install extensions from update.mozilla.org (whitelist) https://bugzilla.mozilla.org/show_bug.cgi?id=265135 Attachment 163106: Fix null-referrer crash https://bugzilla.mozilla.org/attachment.cgi?id=163106&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> Carrying over sr/a ...

superreview granted: [Bug 425253] stack overflow Marquee testcase from bug 239840 is crashing [@ ntdll.dll] Mozilla again : [Attachment 314446] fix
David Baron [:dbaron] <dbaron@mozilla.com> has granted Robert O'Callahan (:= roc) (reduced activity March 18 to April 9) <roc@ocallahan.org>'s request for superreview: Bug 425253: stack overflow Marquee testcase from bug 239840 is crashing [@ ntdll.dll] Mozilla again https://bugzilla.mozilla.org/show_bug.cgi?id=3D425253 Attachment 314446: fix https://bugzilla.mozilla.org/attachment.cgi?id=3D314446&action=3Dedit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> + virtual nsMargin GetDesiredScrollbarSizes(nsPresContext* aPres...

superreview granted: [Bug 232095] [FIX]JS syntax error in XBL binding used twice crashes Mozilla : [Attachment 139958] Possible fix
Brian Ryner <bryner@brianryner.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 232095: [FIX]JS syntax error in XBL binding used twice crashes Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=232095 Attachment 139958: Possible fix http://bugzilla.mozilla.org/attachment.cgi?id=139958&action=edit ...

superreview granted: [Bug 255366] File picker calls crash mozilla (open file, file attach, file browser, etc) : [Attachment 159629] Make our prototype for _gtk_file_chooser_dialog_new_fn() match real
Johnny Stenback <jst@mozilla.jstenback.com> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 255366: File picker calls crash mozilla (open file, file attach, file browser, etc) https://bugzilla.mozilla.org/show_bug.cgi?id=255366 Attachment 159629: Make our prototype for _gtk_file_chooser_dialog_new_fn() match reality (patch by bryner) https://bugzilla.mozilla.org/attachment.cgi?id=159629&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> Chris, was this done this way intentionally...

superreview granted: [Bug 247323] <iframe src="javascript:1"/> partially hoses Mozilla : [Attachment 159975] Bandaid on a bandaid on a bandaid. A real fix for bug 93105 would be preferable.
Brian Ryner (IBM) <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 247323: <iframe src="javascript:1"/> partially hoses Mozilla https://bugzilla.mozilla.org/show_bug.cgi?id=247323 Attachment 159975: Bandaid on a bandaid on a bandaid. A real fix for bug 93105 would be preferable. https://bugzilla.mozilla.org/attachment.cgi?id=159975&action=edit ------- Additional Comments from Brian Ryner (IBM) <bryner@brianryner.com> Yeah, we don't want to leave an extra focus suppression ha...

superreview granted: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246930] Fix one more arithmetic bug
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246930: Fix one more arithmetic bug https://bugzilla.mozilla.org/attachment.cgi?id=246930&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Would be nice to have this in cairo as well. Someone else's problem I guess. ...

superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ js_CloseTokenStream] : [Attachment 131712] proposed fix
Mike Shaver <shaver@mozilla.org> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 215798: Running Venkman crashes Mozilla [@ js_CloseTokenStream] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131712: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=131712&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> sr=shaver (But why doesn't that bite us all the time? Just lucky, and helped by the mostly-single-threaded engine use?) ...

superreview granted: [Bug 240414] Copying to the clipboard sometimes crashes Mozilla : [Attachment 146022] Fix for problem
Michael Kaply (IBM) <mkaply@us.ibm.com> has granted Michael Kaply (IBM) <mkaply@us.ibm.com>'s request for superreview: Bug 240414: Copying to the clipboard sometimes crashes Mozilla http://bugzilla.mozilla.org/show_bug.cgi?id=240414 Attachment 146022: Fix for problem http://bugzilla.mozilla.org/attachment.cgi?id=146022&action=edit ------- Additional Comments from Michael Kaply (IBM) <mkaply@us.ibm.com> sr=blizzard (platform specific) a=mkaply (OS/2 only) ...

superreview requested: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Brendan Eich <brendan@mozilla.org> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ...

superreview requested: [Bug 280901] Mozilla build fails when trying to build in mozilla/extensions/spellcheck/myspell/src directory. : [Attachment 173252] Suggested fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 280901: Mozilla build fails when trying to build in mozilla/extensions/spellcheck/myspell/src directory. https://bugzilla.mozilla.org/show_bug.cgi?id=280901 Attachment 173252: Suggested fix https://bugzilla.mozilla.org/attachment.cgi?id=173252&action=edit ...

superreview granted: [Bug 286806] Package mailnews chrome files directly from mozilla\mail : [Attachment 177932] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 286806: Package mailnews chrome files directly from mozilla\mail https://bugzilla.mozilla.org/show_bug.cgi?id=286806 Attachment 177932: the fix https://bugzilla.mozilla.org/attachment.cgi?id=177932&action=edit ...

superreview requested: [Bug 216705] Mozilla crashes after trying to open another message : [Attachment 130152] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <scott@scott-macgregor.org> for superreview: Bug 216705: Mozilla crashes after trying to open another message http://bugzilla.mozilla.org/show_bug.cgi?id=216705 Attachment 130152: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=130152&action=edit ...