superreview requested: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) https://bugzilla.mozilla.org/show_bug.cgi?id=284276 Attachment 177385: patch https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> might that ever change? if not, I'll remove the comment before checking in, then. ...

superreview granted: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1
Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak) <edilee@gmail.com>'s request for superreview: Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't show completion https://bugzilla.mozilla.org/show_bug.cgi?id=418961 Attachment 305432: v1 https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit ...

superreview requested: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1
Edward Lee (Mardak) <edilee@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't show completion https://bugzilla.mozilla.org/show_bug.cgi?id=418961 Attachment 305432: v1 https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit ------- Additional Comments from Edward Lee (Mardak) <edilee@gmail.com> Similar to what we needed to do for exthandler.. set the NETWORK bit. All places in webbrowserpersist that have a STATE_START ...

superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch r
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> > v...

superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206517] Patch f
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206517: Patch for check-in https://bugzilla.mozilla.org/attachment.cgi?id=206517&action=edit ...

superreview granted: [Bug 342321] nsIncrementalDownload doesn't create 0-sized file when downloading a 0-sized file : [Attachment 226514] Always create/truncate the dest. file during the channel's onS
Darin Fisher (Google) <darin@meer.net> has granted Jeff Walden (remove +bmo to email) <jwalden+bmo@mit.edu>'s request for superreview: Bug 342321: nsIncrementalDownload doesn't create 0-sized file when downloading a 0-sized file https://bugzilla.mozilla.org/show_bug.cgi?id=342321 Attachment 226514: Always create/truncate the dest. file during the channel's onStartRequest https://bugzilla.mozilla.org/attachment.cgi?id=226514&action=edit ...

superreview granted: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patch
Darin Fisher (IBM) <darin@meer.net> has granted Christian Biesinger <cbiesinger@gmx.at>'s request for superreview: Bug 241209: "Show File Location" and "Launch File" buttons (on download progress dialog) don't work http://bugzilla.mozilla.org/show_bug.cgi?id=241209 Attachment 147465: patch http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> sr=darin ...

superreview granted: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@dbaron.org>'s request for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> d'oh! I should have caught that. Leave the debug code in. ...

superreview granted: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 176098] Simpler patch
Mike Pinkerton <pinkerton@aol.net> has granted Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 281648: "Download Link Target" results in bad download for large MP3 file. https://bugzilla.mozilla.org/show_bug.cgi?id=281648 Attachment 176098: Simpler patch https://bugzilla.mozilla.org/attachment.cgi?id=176098&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink also fixes the bug where you save the html at www.google.com and instead of saving html we'd get garbage (the gzip'd contentes). ...

superreview granted: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 175670] Patch: consult nsIExternalHelperAppService before setting PERSIST_FLAGS_NO_C
Darin Fisher <darin@meer.net> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 281648: "Download Link Target" results in bad download for large MP3 file. https://bugzilla.mozilla.org/show_bug.cgi?id=281648 Attachment 175670: Patch: consult nsIExternalHelperAppService before setting PERSIST_FLAGS_NO_CONVERSION https://bugzilla.mozilla.org/attachment.cgi?id=175670&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> This seems right to me, sr=darin ...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] Patch
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 201159: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> This fix this bug. aDocum...

superreview cancelled: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] Patch
Christian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 201159: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit ------- Additional Comments from Christian Biesinger (:bi) (reviews slower than usual) &l...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #2
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #3
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ...