superreview requested: [Bug 283703] Focus events not being fired for radio buttons : [Attachment 175603] Fix regression. Send focus events to selected item, but don't do it for menulist which is handAaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 283703: Focus events not being fired for radio buttons
https://bugzilla.mozilla.org/show_bug.cgi?id=283703
Attachment 175603: Fix regression. Send focus events to selected item, but
don't do it for menulist which is handled separately.
https://bugzilla.mozilla.org/attachment.cgi?id=175603&action=edit
...
superreview granted: [Bug 297927] Extra MSAA focus event fired on top level window : [Attachment 186490] Don't fire MSAA events for top level window, because they are automatically handled by MSAAT Rowley (IBM) <tor@acm.org> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 297927: Extra MSAA focus event fired on top level window
https://bugzilla.mozilla.org/show_bug.cgi?id=297927
Attachment 186490: Don't fire MSAA events for top level window, because they
are automatically handled by MSAA
https://bugzilla.mozilla.org/attachment.cgi?id=186490&action=edit
...
superreview requested: [Bug 245931] Problems with accessibility API focus events : [Attachment 150306] 1) Make sure STATE_FOCUSED is set on objects focus event indicates are focused, 2) Don't fire evAaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner (IBM)
<bryner@brianryner.com> for superreview:
Bug 245931: Problems with accessibility API focus events
http://bugzilla.mozilla.org/show_bug.cgi?id=245931
Attachment 150306: 1) Make sure STATE_FOCUSED is set on objects focus event
indicates are focused, 2) Don't fire events using ExplicitOriginalTarget unless
the current target has a binding parent
http://bugzilla.mozilla.org/attachment.cgi?id=150306&action=edit
...
superreview cancelled: [Bug 245931] Problems with accessibility API focus events : [Attachment 150306] 1) Make sure STATE_FOCUSED is set on objects focus event indicates are focused, 2) Don't fire evAaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 245931: Problems with accessibility API focus events
http://bugzilla.mozilla.org/show_bug.cgi?id=245931
Attachment 150306: 1) Make sure STATE_FOCUSED is set on objects focus event
indicates are focused, 2) Don't fire events using ExplicitOriginalTarget unless
the current target has a binding parent
http://bugzilla.mozilla.org/attachment.cgi?id=150306&action=edit
...
superreview requested: [Bug 297927] Extra MSAA focus event fired on top level window : [Attachment 186490] Don't fire MSAA events for top level window, because they are automatically handled by MSAA #2Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky (gone June
3 -- June 30) <bzbarsky@mit.edu> for superreview:
Bug 297927: Extra MSAA focus event fired on top level window
https://bugzilla.mozilla.org/show_bug.cgi?id=297927
Attachment 186490: Don't fire MSAA events for top level window, because they
are automatically handled by MSAA
https://bugzilla.mozilla.org/attachment.cgi?id=186490&action=edit
...
superreview requested: [Bug 297927] Extra MSAA focus event fired on top level window : [Attachment 186490] Don't fire MSAA events for top level window, because they are automatically handled by MSAA #3Aaron Leventhal <aaronleventhal@moonset.net> has asked T Rowley (IBM)
<tor@acm.org> for superreview:
Bug 297927: Extra MSAA focus event fired on top level window
https://bugzilla.mozilla.org/show_bug.cgi?id=297927
Attachment 186490: Don't fire MSAA events for top level window, because they
are automatically handled by MSAA
https://bugzilla.mozilla.org/attachment.cgi?id=186490&action=edit
...
superreview granted: [Bug 245365] Current tree item not being spoken when tree view gets focus : [Attachment 149852] Make sure that tree focus events lead to tree item focus/selection eventsDarin Fisher (IBM) <darin@meer.net> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 245365: Current tree item not being spoken when tree view gets focus
http://bugzilla.mozilla.org/show_bug.cgi?id=245365
Attachment 149852: Make sure that tree focus events lead to tree item
focus/selection events
http://bugzilla.mozilla.org/attachment.cgi?id=149852&action=edit
------- Additional Comments from Darin Fisher (IBM) <darin@meer.net>
rs=darin
i really know nothing of accessibility or focus events. you might want to ask
...
superreview granted: [Bug 307172] Focus never returns when a link having focus is hidden : [Attachment 197141] Don't get current event content if current event frame is null. Patch for trunk and MOZIBrian Ryner <bryner@brianryner.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 307172: Focus never returns when a link having focus is hidden
https://bugzilla.mozilla.org/show_bug.cgi?id=307172
Attachment 197141: Don't get current event content if current event frame is
null. Patch for trunk and MOZILLA_1_8_BRANCH .... patch for 1.7 would be
similar
https://bugzilla.mozilla.org/attachment.cgi?id=197141&action=edit
------- Additional Comments from Brian Ryner <bryner@brianryner.com>
This should be ok, and I...
superreview granted: [Bug 252955] List items returning strange states : [Attachment 154258] Fire correct focus events, make sure focused state is set on list item event targets for themDarin Fisher (IBM) <darin@meer.net> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 252955: List items returning strange states
http://bugzilla.mozilla.org/show_bug.cgi?id=252955
Attachment 154258: Fire correct focus events, make sure focused state is set on
list item event targets for them
http://bugzilla.mozilla.org/attachment.cgi?id=154258&action=edit
------- Additional Comments from Darin Fisher (IBM) <darin@meer.net>
Technically, you should really find a non-IBMer to provide SR because it is
"verboten"...
superreview granted: [Bug 260846] Incorrect tree item focus events fired while typing in autocomplete text field : [Attachment 159619] Only fire select events for autocomplete when there is a selectineil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron
Leventhal <aaronleventhal@moonset.net>'s request for superreview:
Bug 260846: Incorrect tree item focus events fired while typing in autocomplete
text field
https://bugzilla.mozilla.org/show_bug.cgi?id=260846
Attachment 159619: Only fire select events for autocomplete when there is a
selection being made (not being cleared)
https://bugzilla.mozilla.org/attachment.cgi?id=159619&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
s...
superreview granted: [Bug 245931] Problems with accessibility API focus events : [Attachment 150319] Fixes pkw's comments and also fixes focused tree items to show STATE_FOCUSABLEBrian Ryner (IBM) <bryner@brianryner.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 245931: Problems with accessibility API focus events
http://bugzilla.mozilla.org/show_bug.cgi?id=245931
Attachment 150319: Fixes pkw's comments and also fixes focused tree items to
show STATE_FOCUSABLE
http://bugzilla.mozilla.org/attachment.cgi?id=150319&action=edit
------- Additional Comments from Brian Ryner (IBM) <bryner@brianryner.com>
sr=bryner
...
superreview granted: [Bug 127118] Pressing access key for radio button doesn't focus radio group or show focus on radio button : [Attachment 150359] New patch setting focusedItem not selectedItemBrian Ryner (IBM) <bryner@brianryner.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 127118: Pressing access key for radio button doesn't focus radio group or
show focus on radio button
http://bugzilla.mozilla.org/show_bug.cgi?id=127118
Attachment 150359: New patch setting focusedItem not selectedItem
http://bugzilla.mozilla.org/attachment.cgi?id=150359&action=edit
------- Additional Comments from Brian Ryner (IBM) <bryner@brianryner.com>
sr=bryner
...
superreview requested: [Bug 245365] Current tree item not being spoken when tree view gets focus : [Attachment 149852] Make sure that tree focus events lead to tree item focus/selection eventsAaron Leventhal <aaronleventhal@moonset.net> has asked Darin Fisher (IBM)
<darin@meer.net> for superreview:
Bug 245365: Current tree item not being spoken when tree view gets focus
http://bugzilla.mozilla.org/show_bug.cgi?id=245365
Attachment 149852: Make sure that tree focus events lead to tree item
focus/selection events
http://bugzilla.mozilla.org/attachment.cgi?id=149852&action=edit
------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net>
Darin, another small patch for your sr=.
...
superreview granted: [Bug 300779] Support multiple selection for xul:tree : [Attachment 190476] Expose via a11y events. We don't need DOMItemSelected after all, they aren't fired for tree. We'll go Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 300779: Support multiple selection for xul:tree
https://bugzilla.mozilla.org/show_bug.cgi?id=300779
Attachment 190476: Expose via a11y events. We don't need DOMItemSelected after
all, they aren't fired for tree. We'll go off of "select" DOM events later for
the add/remove a11y events.
https://bugzilla.mozilla.org/attachment.cgi?id=190476&action=edit
...