superreview requested: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 176098] Simpler patchSimon Fraser <sfraser_bugs@smfr.org> has asked Darin Fisher <darin@meer.net>
for superreview:
Bug 281648: "Download Link Target" results in bad download for large MP3 file.
https://bugzilla.mozilla.org/show_bug.cgi?id=281648
Attachment 176098: Simpler patch
https://bugzilla.mozilla.org/attachment.cgi?id=176098&action=edit
...
superreview requested: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 176098] Simpler patch #2Josh Aas <joshmoz@gmail.com> has asked Mike Pinkerton <pinkerton@aol.net> for
superreview:
Bug 281648: "Download Link Target" results in bad download for large MP3 file.
https://bugzilla.mozilla.org/show_bug.cgi?id=281648
Attachment 176098: Simpler patch
https://bugzilla.mozilla.org/attachment.cgi?id=176098&action=edit
...
superreview granted: [Bug 281648] "Download Link Target" results in bad download for large MP3 file. : [Attachment 175670] Patch: consult nsIExternalHelperAppService before setting PERSIST_FLAGS_NO_CDarin Fisher <darin@meer.net> has granted Darin Fisher <darin@meer.net>'s
request for superreview:
Bug 281648: "Download Link Target" results in bad download for large MP3 file.
https://bugzilla.mozilla.org/show_bug.cgi?id=281648
Attachment 175670: Patch: consult nsIExternalHelperAppService before setting
PERSIST_FLAGS_NO_CONVERSION
https://bugzilla.mozilla.org/attachment.cgi?id=175670&action=edit
------- Additional Comments from Darin Fisher <darin@meer.net>
This seems right to me, sr=darin
...
superreview granted: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patchBoris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi)
<cbiesinger@gmx.at>'s request for superreview:
Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the
link itself displays file size on download (FTP)
https://bugzilla.mozilla.org/show_bug.cgi?id=284276
Attachment 177385: patch
https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
Seems reasonable
...
superreview requested: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patchChristian Biesinger (:bi) <cbiesinger@gmx.at> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the
link itself displays file size on download (FTP)
https://bugzilla.mozilla.org/show_bug.cgi?id=284276
Attachment 177385: patch
https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit
------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at>
might that ever change? if not, I'll remove the comment before checking in,
then.
...
superreview granted: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patchDarin Fisher (IBM) <darin@meer.net> has granted Christian Biesinger
<cbiesinger@gmx.at>'s request for superreview:
Bug 241209: "Show File Location" and "Launch File" buttons (on download
progress dialog) don't work
http://bugzilla.mozilla.org/show_bug.cgi?id=241209
Attachment 147465: patch
http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit
------- Additional Comments from Darin Fisher (IBM) <darin@meer.net>
sr=darin
...
superreview cancelled: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 180129] Cleaned up patch, moving review requestsMike Pinkerton <pinkerton@aol.net> has cancelled Torben
<torben@despammed.com>'s request for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 180129: Cleaned up patch, moving review requests
https://bugzilla.mozilla.org/attachment.cgi?id=180129&action=edit
...
superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 180129] Cleaned up patch, moving review requestsTorben <torben@despammed.com> has asked Simon Fraser <sfraser_bugs@smfr.org>
for superreview:
Bug 90918: RFE: Add url in "comments" field of the "get info" window when
download file.
https://bugzilla.mozilla.org/show_bug.cgi?id=90918
Attachment 180129: Cleaned up patch, moving review requests
https://bugzilla.mozilla.org/attachment.cgi?id=180129&action=edit
...
superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206517] Patch fMasayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted Masayuki
Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206517: Patch for check-in
https://bugzilla.mozilla.org/attachment.cgi?id=206517&action=edit
...
superreview granted: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch rneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted Masayuki
Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8,
the default file name is always escaped at "Save Link Target As..."
https://bugzilla.mozilla.org/show_bug.cgi?id=314231
Attachment 206229: Patch rv2.0
https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@bluebottle.com>
> v...
superreview granted: [Bug 149237] Transferred value is incorrect/wrong ("1KB of 1KB") after downloading file with unknown size : [Attachment 177328] Checked in after review/superreview.neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Andreas
Kies <andikies@t-online.de>'s request for superreview:
Bug 149237: Transferred value is incorrect/wrong ("1KB of 1KB") after
downloading file with unknown size
https://bugzilla.mozilla.org/show_bug.cgi?id=149237
Attachment 177328: Checked in after review/superreview.
https://bugzilla.mozilla.org/attachment.cgi?id=177328&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
>- mPercentComplete = 100;
This line appear...
superreview granted: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak)
<edilee@gmail.com>'s request for superreview:
Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't
show completion
https://bugzilla.mozilla.org/show_bug.cgi?id=418961
Attachment 305432: v1
https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit
...
superreview requested: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patchChristian Biesinger <cbiesinger@gmx.at> has asked Darin Fisher (IBM)
<darin@meer.net> for superreview:
Bug 241209: "Show File Location" and "Launch File" buttons (on download
progress dialog) don't work
http://bugzilla.mozilla.org/show_bug.cgi?id=241209
Attachment 147465: patch
http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit
...
superreview granted: [Bug 397935] Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachment 3 #3Mike Connor <mconnor@mozilla.com> has granted Shawn Wilsher (sdwilsh)
<sdwilsh@forerunnerdesigns.com>'s request for superreview:
Bug 397935: Download Manager ("Downloads") window doesn't stay open when
clicking on download-complete alert notification with auto-close pref ("close
when done")
https://bugzilla.mozilla.org/show_bug.cgi?id=397935
Attachment 312112: v1.1
https://bugzilla.mozilla.org/attachment.cgi?id=312112&action=edit
------- Additional Comments from Mike Connor <mconnor@mozilla.com>
sr=mconnor, I would probably explici...