superreview granted: [Bug 278433] setvalue element doesn't use @value as context : [Attachment 171298] fix with smaug's comments

Darin Fisher (IBM) <darin@meer.net> has granted aaronr@us.ibm.com's request for
superreview:
Bug 278433: setvalue element doesn't use @value as context
https://bugzilla.mozilla.org/show_bug.cgi?id=278433

Attachment 171298: fix with smaug's comments
https://bugzilla.mozilla.org/attachment.cgi?id=171298&action=edit

------- Additional Comments from Darin Fisher (IBM) <darin@meer.net>
"valueAttr" over "valueattr" is generally preferred in mozilla code.
0
bugzilla
1/15/2005 12:17:02 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
512 Views

Similar Articles

[PageSpeed] 34

Reply:

Similar Artilces:

superreview requested: [Bug 278433] setvalue element doesn't use @value as context : [Attachment 171298] fix with smaug's comments
aaronr@us.ibm.com has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 278433: setvalue element doesn't use @value as context https://bugzilla.mozilla.org/show_bug.cgi?id=278433 Attachment 171298: fix with smaug's comments https://bugzilla.mozilla.org/attachment.cgi?id=171298&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview cancelled: [Bug 278433] setvalue element doesn't use @value as context : [Attachment 171289] proposed fix
aaronr@us.ibm.com has cancelled aaronr@us.ibm.com's request for superreview: Bug 278433: setvalue element doesn't use @value as context https://bugzilla.mozilla.org/show_bug.cgi?id=278433 Attachment 171289: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=171289&action=edit ...

superreview requested: [Bug 278433] setvalue element doesn't use @value as context : [Attachment 171289] proposed fix
aaronr@us.ibm.com has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 278433: setvalue element doesn't use @value as context https://bugzilla.mozilla.org/show_bug.cgi?id=278433 Attachment 171289: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=171289&action=edit ------- Additional Comments from aaronr@us.ibm.com Note: I changed around HandleAction to be more efficient (I hope) now that we need to know single node binding before we figure out the value to set when there is a non-empty value attribute. ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview granted: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 162166] fix review comments
Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz <dveditz@cruzio.com>'s request for superreview: Bug 263366: execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case https://bugzilla.mozilla.org/show_bug.cgi?id=263366 Attachment 162166: fix review comments https://bugzilla.mozilla.org/attachment.cgi?id=162166&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> Carrying over r/sr, seeking branch approval. jst wants this for the plugin finder ...

superreview granted: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179753] fix based on daniel's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285138: Spellchecker doesn't skip quoted text in plain text editor https://bugzilla.mozilla.org/show_bug.cgi?id=285138 Attachment 179753: fix based on daniel's review comment https://bugzilla.mozilla.org/attachment.cgi?id=179753&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but it sounds like some cleanup of incremental vs final chunk is in order.... ...

superreview granted: [Bug 215567] Absolute positioned element doesn't paint correctly when 'clip' changes : [Attachment 142730] fix
Boris Zbarsky <bzbarsky@mit.edu> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 215567: Absolute positioned element doesn't paint correctly when 'clip' changes http://bugzilla.mozilla.org/show_bug.cgi?id=215567 Attachment 142730: fix http://bugzilla.mozilla.org/attachment.cgi?id=142730&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: content/shared/public/nsStyleStruct.h >+ nsClipRect mClip; // [reset] offsets from upper-left border edge; >+ // not a...

superreview granted: [Bug 215567] Absolute positioned element doesn't paint correctly when 'clip' changes : [Attachment 142805] fix #2
Boris Zbarsky <bzbarsky@mit.edu> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 215567: Absolute positioned element doesn't paint correctly when 'clip' changes http://bugzilla.mozilla.org/show_bug.cgi?id=215567 Attachment 142805: fix #2 http://bugzilla.mozilla.org/attachment.cgi?id=142805&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

superreview granted: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 163330] corrects neil's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jean-Marc Desperrier <jmdesp@alussinan.org>'s request for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 163330: corrects neil's comments https://bugzilla.mozilla.org/attachment.cgi?id=163330&action=edit ...

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview granted: [Bug 322207] merging two paragraphs using backspace/delete key leaves an unwanted BR element : [Attachment 237094] in answer to bz's comments with scott's approval for email
Boris Zbarsky <bzbarsky@mit.edu> has granted Daniel Glazman <daniel@glazman.org>'s request for superreview: Bug 322207: merging two paragraphs using backspace/delete key leaves an unwanted BR element https://bugzilla.mozilla.org/show_bug.cgi?id=322207 Attachment 237094: in answer to bz's comments with scott's approval for email https://bugzilla.mozilla.org/attachment.cgi?id=237094&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: nsHTMLEditRules.cpp >+ if (nsHTMLEditUtils::IsList(aNodeLeft) >+ || mHTM...

Web resources about - superreview granted: [Bug 278433] setvalue element doesn't use @value as context : [Attachment 171298] fix with smaug's comments - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/3/2016 7:47:34 PM