superreview granted: [Bug 269581] NSS calls C_GetAttributeValue unnecessarily when token is logged in : [Attachment 175370] fixes integrating Bob and Wan-Teh's review comments. Also fix bogus logic

Robert Relyea <rrelyea@redhat.com> has granted Julien Pierre
<julien.pierre.bugs@sun.com>'s request for superreview:
Bug 269581: NSS calls C_GetAttributeValue unnecessarily when token is logged in
https://bugzilla.mozilla.org/show_bug.cgi?id=269581

Attachment 175370: fixes integrating Bob and Wan-Teh's review comments. Also
fix bogus logic
https://bugzilla.mozilla.org/attachment.cgi?id=175370&action=edit

------- Additional Comments from Robert Relyea <rrelyea@redhat.com>
looks good!

bob
0
bugzilla
2/23/2005 11:09:27 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
690 Views

Similar Articles

[PageSpeed] 30
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 269581] NSS calls C_GetAttributeValue unnecessarily when token is logged in : [Attachment 175370] fixes integrating Bob and Wan-Teh's review comments. Also fix bogus logic
Julien Pierre <julien.pierre.bugs@sun.com> has asked Robert Relyea <rrelyea@redhat.com> for superreview: Bug 269581: NSS calls C_GetAttributeValue unnecessarily when token is logged in https://bugzilla.mozilla.org/show_bug.cgi?id=269581 Attachment 175370: fixes integrating Bob and Wan-Teh's review comments. Also fix bogus logic https://bugzilla.mozilla.org/attachment.cgi?id=175370&action=edit ...

superreview granted: [Bug 157566] Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension : [Attachment 147290] trunk version of the fix with david's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 157566: Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension http://bugzilla.mozilla.org/show_bug.cgi?id=157566 Attachment 147290: trunk version of the fix with david's review comment http://bugzilla.mozilla.org/attachment.cgi?id=147290&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying over david's sr ...

superreview granted: [Bug 263366] execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case : [Attachment 162166] fix review comments
Daniel Veditz <dveditz@cruzio.com> has granted Daniel Veditz <dveditz@cruzio.com>'s request for superreview: Bug 263366: execute() doesn't check if exection succeeded or not, and claims it did even if that's not the case https://bugzilla.mozilla.org/show_bug.cgi?id=263366 Attachment 162166: fix review comments https://bugzilla.mozilla.org/attachment.cgi?id=162166&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> Carrying over r/sr, seeking branch approval. jst wants this for the plugin finder ...

superreview granted: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179753] fix based on daniel's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285138: Spellchecker doesn't skip quoted text in plain text editor https://bugzilla.mozilla.org/show_bug.cgi?id=285138 Attachment 179753: fix based on daniel's review comment https://bugzilla.mozilla.org/attachment.cgi?id=179753&action=edit ...

superreview granted: [Bug 245931] Problems with accessibility API focus events : [Attachment 150319] Fixes pkw's comments and also fixes focused tree items to show STATE_FOCUSABLE
Brian Ryner (IBM) <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 245931: Problems with accessibility API focus events http://bugzilla.mozilla.org/show_bug.cgi?id=245931 Attachment 150319: Fixes pkw's comments and also fixes focused tree items to show STATE_FOCUSABLE http://bugzilla.mozilla.org/attachment.cgi?id=150319&action=edit ------- Additional Comments from Brian Ryner (IBM) <bryner@brianryner.com> sr=bryner ...

superreview granted: [Bug 330682] [FIX] Radial gradients are broken when fx, fy is on or outside the circumference defined by cx, cy and r : [Attachment 215425] address scooter's review comments
T Rowley (IBM) <tor@acm.org> has granted Jonathan Watt <jwatt@jwatt.org>'s request for superreview: Bug 330682: [FIX] Radial gradients are broken when fx,fy is on or outside the circumference defined by cx, cy and r https://bugzilla.mozilla.org/show_bug.cgi?id=330682 Attachment 215425: address scooter's review comments https://bugzilla.mozilla.org/attachment.cgi?id=215425&action=edit ...

superreview granted: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Brendan Eich <brendan@mozilla.org> has granted Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> rs=me, I'm trusting you guys, patch looks ok from the context di...

superreview requested: [Bug 302865] In cookies exceptions list, should also have option for session cookies only, not just allow/deny : [Attachment 209319] fixed per stuart's comments, also fixes bro
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked for superreview: Bug 302865: In cookies exceptions list, should also have option for session cookies only, not just allow/deny https://bugzilla.mozilla.org/show_bug.cgi?id=302865 Attachment 209319: fixed per stuart's comments, also fixes broken search on policy column https://bugzilla.mozilla.org/attachment.cgi?id=209319&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Looks good--and yes pink, I even tested aol.com ;) r=me ...

superreview granted: [Bug 282615] DOMSerializer's security checks don't take capabilities into account. : [Attachment 174606] Fix (diff -w for reviews)
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 282615: DOMSerializer's security checks don't take capabilities into account. https://bugzilla.mozilla.org/show_bug.cgi?id=282615 Attachment 174606: Fix (diff -w for reviews) https://bugzilla.mozilla.org/attachment.cgi?id=174606&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview granted: [Bug 331880] [FIX]nsStackLayout::Layout(..) 's redraw logic is not entirely correct. : [Attachment 220076] Fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 331880: [FIX]nsStackLayout::Layout(..) 's redraw logic is not entirely correct. https://bugzilla.mozilla.org/show_bug.cgi?id=331880 Attachment 220076: Fix https://bugzilla.mozilla.org/attachment.cgi?id=220076&action=edit ...

superreview denied: [Bug 274083] nsXFormsSchemaValidator : [Attachment 168647] shim with darin's review comments fixed.
Darin Fisher (IBM) <darin@meer.net> has denied Doron Rosenberg (IBM) <doronr@gmail.com>'s request for superreview: Bug 274083: nsXFormsSchemaValidator https://bugzilla.mozilla.org/show_bug.cgi?id=274083 Attachment 168647: shim with darin's review comments fixed. https://bugzilla.mozilla.org/attachment.cgi?id=168647&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> >+nsXFormsSchemaValidator::nsXFormsSchemaValidator() >+{ >+ mSchemaValidator = do_GetService(NS_SCHEMAVALIDATOR_CONTRACTID); >+} >+ >+nsr...

superreview denied: [Bug 269581] NSS calls C_GetAttributeValue unnecessarily when token is logged in : [Attachment 165767] patch for the tip
Robert Relyea <rrelyea0264@aol.com> has denied Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 269581: NSS calls C_GetAttributeValue unnecessarily when token is logged in https://bugzilla.mozilla.org/show_bug.cgi?id=269581 Attachment 165767: patch for the tip https://bugzilla.mozilla.org/attachment.cgi?id=165767&action=edit ------- Additional Comments from Robert Relyea <rrelyea0264@aol.com> The change to pk11akey.c is fine, but the changes in pk11obj.c and pk11skey.c change the semantics of NSS. PK11_HandlePasswordCheck may requi...

superreview requested: [Bug 274083] nsXFormsSchemaValidator : [Attachment 168647] shim with darin's review comments fixed.
Doron Rosenberg (IBM) <doronr@gmail.com> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 274083: nsXFormsSchemaValidator https://bugzilla.mozilla.org/show_bug.cgi?id=274083 Attachment 168647: shim with darin's review comments fixed. https://bugzilla.mozilla.org/attachment.cgi?id=168647&action=edit ...