superreview granted: [Bug 262095] Crash if View/Messages/All is reenabled after message list was emptied by move message [@ nsTreeSelection::SetCurrentIndex] : [Attachment 175227] look before leaping

Boris Zbarsky <bzbarsky@mit.edu> has granted timeless@myrealbox.com (working)
<timeless@bemail.org>'s request for superreview:
Bug 262095: Crash if View/Messages/All is reenabled after message list was
emptied by move message [@ nsTreeSelection::SetCurrentIndex]
https://bugzilla.mozilla.org/show_bug.cgi?id=262095

Attachment 175227: look before leaping into mTree and after trying to alloc
https://bugzilla.mozilla.org/attachment.cgi?id=175227&action=edit

------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
sr=bzbarsky if you make those NS_ERROR_NOT_INITIALIZED returns use
NS_ENSURE_TRUE -- I think having a warning there instead of silently bailing is
a good idea.
0
bugzilla
4/2/2005 5:33:27 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
753 Views

Similar Articles

[PageSpeed] 55
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 262095] Crash if View/Messages/All is reenabled after message list was emptied by move message : [Attachment 175227] look before leaping into mTree and after trying to all
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 262095: Crash if View/Messages/All is reenabled after message list was emptied by move message https://bugzilla.mozilla.org/show_bug.cgi?id=262095 Attachment 175227: look before leaping into mTree and after trying to alloc https://bugzilla.mozilla.org/attachment.cgi?id=175227&action=edit ...

superreview granted: [Bug 244722] Message truncated in headers stops mail from automatically moving all junk messages : [Attachment 149844] patch that fixes the crash in bug 245233
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 244722: Message truncated in headers stops mail from automatically moving all junk messages http://bugzilla.mozilla.org/show_bug.cgi?id=244722 Attachment 149844: patch that fixes the crash in bug 245233 http://bugzilla.mozilla.org/attachment.cgi?id=149844&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I'll check this in ...

superreview granted: [Bug 242600] "Edit" message filter after "Run Message Filter" causes Mozilla crash
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 242600: "Edit" message filter after "Run Message Filter" causes Mozilla crash - Trunk TB11a1 [@ nsMsgFilter::GetFilterList] https://bugzilla.mozilla.org/show_bug.cgi?id=242600 Attachment 186159: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=186159&action=edit ...

superreview granted: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 200351] support reply/forward (as attachment and inline)
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 204350: (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) https://bugzilla.mozilla.org/show_bug.cgi?id=204350 Attachment 200351: support reply/forward (as attachment and inline) for message/rfc822 attachments https://bugzilla.mozilla.org/attachment.cgi?id=200351&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> + rv = NS_NewURI(getter_AddRefs(uri), messageURI...

superreview granted: [Bug 182627] Message body is not displayed for some messages if view attachments inline is false : [Attachment 206280] proposed fix
Scott MacGregor (out of town December 10th-17th) <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 182627: Message body is not displayed for some messages if view attachments inline is false https://bugzilla.mozilla.org/show_bug.cgi?id=182627 Attachment 206280: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=206280&action=edit ...

superreview granted: [Bug 203570] [message/rfc822] opening a fwd local message has original messages's attachments : [Attachment 199818] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 203570: [message/rfc822] opening a fwd local message has original messages's attachments https://bugzilla.mozilla.org/show_bug.cgi?id=203570 Attachment 199818: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=199818&action=edit ...

superreview granted: [Bug 204350] (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) : [Attachment 201005] front end part
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 204350: (message/rfc822) Attached email message window glitches (forward, reply, view source disabled) https://bugzilla.mozilla.org/show_bug.cgi?id=204350 Attachment 201005: front end part https://bugzilla.mozilla.org/attachment.cgi?id=201005&action=edit ...

superreview granted: [Bug 258113] a number of my emails have lost their correct message and have in the message area text from other messages, a few of the messages are now blank
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 258113: a number of my emails have lost their correct message and have in the message area text from other messages, a few of the messages are now blank - correct messages were present when they arrived https://bugzilla.mozilla.org/show_bug.cgi?id=258113 Attachment 181310: potential fix for case where new msg quarantining pref is set https://bugzilla.mozilla.org/attachment.cgi?id=181310&action=edit ...

superreview granted: [Bug 362990] Customize Message Views dialog's selection should not affect View menu selection : [Attachment 248134] make view list manipulation asynchronous
Scott MacGregor <mscott@mozilla.org> has granted Karsten D´┐Żsterloh <mnyromyr@tprac.de>'s request for superreview: Bug 362990: Customize Message Views dialog's selection should not affect View menu selection https://bugzilla.mozilla.org/show_bug.cgi?id=362990 Attachment 248134: make view list manipulation asynchronous https://bugzilla.mozilla.org/attachment.cgi?id=248134&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> approving for the branch too. I also marked this dependent on 362741 since that bug fixes the 2nd i...

superreview granted: [Bug 292568] Message-Edit Message As New then File-Save (template or draft): deletes original message : [Attachment 195749] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 292568: Message-Edit Message As New then File-Save (template or draft): deletes original message https://bugzilla.mozilla.org/show_bug.cgi?id=292568 Attachment 195749: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=195749&action=edit ...

superreview granted: [Bug 226604] crash closing message compose window (with UI button)/message filter dialog : [Attachment 136218] supplemental patch -uw30
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 226604: crash closing message compose window (with UI button)/message filter dialog http://bugzilla.mozilla.org/show_bug.cgi?id=226604 Attachment 136218: supplemental patch -uw30 http://bugzilla.mozilla.org/attachment.cgi?id=136218&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> sr=mscott ...

superreview granted: [Bug 238614] TB09 crashed after cancelling message send operation [@ nsQueryInterface::operator()] : [Attachment 185251] do not update progress bar after message has been cancell
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 238614: TB09 crashed after cancelling message send operation [@ nsQueryInterface::operator()] https://bugzilla.mozilla.org/show_bug.cgi?id=238614 Attachment 185251: do not update progress bar after message has been cancelled https://bugzilla.mozilla.org/attachment.cgi?id=185251&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> you're right, it only seems to be used by smtp. I've verified this in th...

superreview granted: [Bug 265007] Crash over message without Message-ID header when collecting with POP3 [@ PL_HashString] : [Attachment 165453] Patch (diff -uwp 11)
Dan Mosedale <dmose@mozilla.org> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 265007: Crash over message without Message-ID header when collecting with POP3 [@ PL_HashString] https://bugzilla.mozilla.org/show_bug.cgi?id=265007 Attachment 165453: Patch (diff -uwp 11) https://bugzilla.mozilla.org/attachment.cgi?id=165453&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> sr=dmose ...

superreview granted: [Bug 293832] label lost when moving message from IMAP to local folder : [Attachment 183459] patch to copy label when message is copied from server
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 293832: label lost when moving message from IMAP to local folder https://bugzilla.mozilla.org/show_bug.cgi?id=293832 Attachment 183459: patch to copy label when message is copied from server https://bugzilla.mozilla.org/attachment.cgi?id=183459&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> good job, thx. I'll try to shepard this in. ...

Web resources about - superreview granted: [Bug 262095] Crash if View/Messages/All is reenabled after message list was emptied by move message [@ nsTreeSelection::SetCurrentIndex] : [Attachment 175227] look before leaping - netscape.mozilla.reviewers

Resources last updated: 1/22/2016 2:46:39 PM