superreview granted: [Bug 258833] [FIX]Bug 230816 fix changed scope chain for XBL constructors/destructors : [Attachment 158516] This should fix the scope chain

Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky (no tree
till Sept 10) <bzbarsky@mit.edu>'s request for superreview:
Bug 258833: [FIX]Bug 230816 fix changed scope chain for XBL
constructors/destructors
http://bugzilla.mozilla.org/show_bug.cgi?id=258833

Attachment 158516: This should fix the scope chain
http://bugzilla.mozilla.org/attachment.cgi?id=158516&action=edit

------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
sr=jst
0
bugzilla
9/11/2004 5:23:35 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
646 Views

Similar Articles

[PageSpeed] 12

Reply:

Similar Artilces:

superreview requested: [Bug 258833] [FIX]Bug 230816 fix changed scope chain for XBL constructors/destructors : [Attachment 158516] This should fix the scope chain
Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 258833: [FIX]Bug 230816 fix changed scope chain for XBL constructors/destructors http://bugzilla.mozilla.org/show_bug.cgi?id=258833 Attachment 158516: This should fix the scope chain http://bugzilla.mozilla.org/attachment.cgi?id=158516&action=edit ------- Additional Comments from Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> shaver, could you sr? ...

superreview requested: [Bug 258833] Bug 230816 fix changed scope chain for XBL constructors/destructors : [Attachment 158516] This should fix the scope chain
Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 258833: Bug 230816 fix changed scope chain for XBL constructors/destructors http://bugzilla.mozilla.org/show_bug.cgi?id=258833 Attachment 158516: This should fix the scope chain http://bugzilla.mozilla.org/attachment.cgi?id=158516&action=edit ------- Additional Comments from Boris Zbarsky (no tree till Sept 10) <bzbarsky@mit.edu> This should fix that bug with the autocomplete dropdown you were seeing in Firefox, Brian... ...

superreview granted: [Bug 344959] Functions may lose part or all of their scope chain after an exception : [Attachment 233115] fix including patch for bug 347674
Brendan Eich <brendan@mozilla.org> has granted superreview: Bug 344959: Functions may lose part or all of their scope chain after an exception https://bugzilla.mozilla.org/show_bug.cgi?id=344959 Attachment 233115: fix including patch for bug 347674 https://bugzilla.mozilla.org/attachment.cgi?id=233115&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> I'm checking this in -- it would be wrong not to fix bug 347674, since the patch for this bug contains the regression (by way of bug 343765). /be ...

superreview granted: [Bug 344959] Functions may lose part or all of their scope chain after an exception : [Attachment 233116] fix including patch for bug 347674
Brendan Eich <brendan@mozilla.org> has granted superreview: Bug 344959: Functions may lose part or all of their scope chain after an exception https://bugzilla.mozilla.org/show_bug.cgi?id=344959 Attachment 233116: fix including patch for bug 347674 https://bugzilla.mozilla.org/attachment.cgi?id=233116&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Oops, copied wrong patch to staging directory. /be ...

superreview granted: [Bug 317478] leaks due to global scope polluter being removed from not enough (?) prototype chains : [Attachment 204020] jst's preferred approach for fixing the bug
Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron <dbaron@mozilla.com>'s request for superreview: Bug 317478: leaks due to global scope polluter being removed from not enough (?) prototype chains https://bugzilla.mozilla.org/show_bug.cgi?id=317478 Attachment 204020: jst's preferred approach for fixing the bug https://bugzilla.mozilla.org/attachment.cgi?id=204020&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but please add a comment saying that InstallGlobalScopePolluter needs to be called after we...

superreview granted: [Bug 245066] [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) : [Attachment 156344] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 245066: [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) http://bugzilla.mozilla.org/show_bug.cgi?id=245066 Attachment 156344: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=156344&action=edit ...

superreview granted: [Bug 344959] Functions lose their scope chain after an exception : [Attachment 229551] fix
Mike Shaver <shaver@mozilla.org> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 344959: Functions lose their scope chain after an exception https://bugzilla.mozilla.org/show_bug.cgi?id=344959 Attachment 229551: fix https://bugzilla.mozilla.org/attachment.cgi?id=229551&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> sr=shaver. ...

superreview granted: [Bug 226593] [FIX]Dynamic changes to rules attribute do not work : [Attachment 136213] This does fix the bug...
David Baron <dbaron@dbaron.org> has granted Boris Zbarsky (not really reading bugmail) <bz-vacation@mit.edu>'s request for superreview: Bug 226593: [FIX]Dynamic changes to rules attribute do not work http://bugzilla.mozilla.org/show_bug.cgi?id=226593 Attachment 136213: This does fix the bug... http://bugzilla.mozilla.org/attachment.cgi?id=136213&action=edit ...

superreview requested: [Bug 317478] leaks due to global scope polluter being removed from not enough (?) prototype chains : [Attachment 204020] jst's preferred approach for fixing the bug
David Baron <dbaron@mozilla.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 317478: leaks due to global scope polluter being removed from not enough (?) prototype chains https://bugzilla.mozilla.org/show_bug.cgi?id=317478 Attachment 204020: jst's preferred approach for fixing the bug https://bugzilla.mozilla.org/attachment.cgi?id=204020&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> I'll take the liberty of requesting reviews on jst's behalf. I don't feel like a qualified reviewer for this. ...

superreview granted: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246930] Fix one more arithmetic bug
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246930: Fix one more arithmetic bug https://bugzilla.mozilla.org/attachment.cgi?id=246930&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Would be nice to have this in cairo as well. Someone else's problem I guess. ...

superreview granted: [Bug 360579] [FIX]Fix for bug 326009 doesn't work quite right with more than 2 tabs : [Attachment 245463] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 360579: [FIX]Fix for bug 326009 doesn't work quite right with more than 2 tabs https://bugzilla.mozilla.org/show_bug.cgi?id=360579 Attachment 245463: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245463&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> Yeah, this is obviously the right thing to do. r+sr=jst ...

superreview granted: [Bug 299741] [FIX]JS exceptions in XBL constructors not always reported immediately : [Attachment 188329] Proposed fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 299741: [FIX]JS exceptions in XBL constructors not always reported immediately https://bugzilla.mozilla.org/show_bug.cgi?id=299741 Attachment 188329: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=188329&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst, but yeah, I'd rather see this code shared in nsContentUtils (r+sr still applies if you move NotifyXPCIfExceptionPending()). ...

superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Johnny Stenback <jst@mozilla.jstenback.com> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> I wasn't able to test this or run with it, but the change looks good. Hopefully someone else is able to ve...

superreview granted: [Bug 263406] [FIX]abs/fixed pos handling (placeholder, etc) needs consolidation : [Attachment 163244] Patch without changes from bug 263846
Robert O'Callahan <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 263406: [FIX]abs/fixed pos handling (placeholder, etc) needs consolidation https://bugzilla.mozilla.org/show_bug.cgi?id=263406 Attachment 163244: Patch without changes from bug 263846 https://bugzilla.mozilla.org/attachment.cgi?id=163244&action=edit ...

Web resources about - superreview granted: [Bug 258833] [FIX]Bug 230816 fix changed scope chain for XBL constructors/destructors : [Attachment 158516] This should fix the scope chain - netscape.mozilla.reviewers

Von Neumann universal constructor - Wikipedia, the free encyclopedia
Three generations of machine are shown: the second has nearly finished constructing the third. The lines running to the right are the tapes of ...

Bridge Constructor Playground on the App Store on iTunes
Get Bridge Constructor Playground on the App Store. See screenshots and ratings, and read customer reviews.

Lewis Hamilton wins inaugural Russian Formula One Grand Prix as Mercedes take constructors' title
... Russian Formula One Grand Prix and extended his championship lead on Sunday in a Mercedes one-two that clinched the team's first constructors' ...

Observation wheel constructor vows to fight court writ
The construction company being sued for $6 million by the owner of the troubled Melbourne Star Observation Wheel has vowed to vigorously contest ...

Bill Shorten denies Winslow Constructors union payment deal disadvantaged workers after royal commission ...
Opposition Leader Bill denies lucrative deal he oversaw while union leader disadvantaged workers.

Chinese constructor resumes work after security assurance
Chinese constructor resumes work after security assurance People's Daily Online MOYALE, Kenya, Dec. 16 A Chinese roads construction firm, Wu ...

Colleagues Remember ‘Master Crossword Constructor’ Merl Reagle
Colleagues Remember ‘Master Crossword Constructor’ Merl Reagle

Apps of the Week: Hurricane, Bridge Constructor Medieval, Origami Live Wallpaper and more!
It's the last edition of Apps of the Week for the month of May, and we've pulled together a great list of apps from the folks here at Android ...

A Chance To Win Bridge Constructor For iPhone And iPad
... has teamed up with Headup Games , our latest AppAdvice Daily podcast sponsor, in order to offer you a chance to win a copy of Bridge Constructor ...

Price Drop: Monster Constructor
Monster Constructor 1.0 Device: iOS Universal Category: Games Price: Free, Version: 1.0 ( iTunes ) Description: Monster Constructor lets you ...

Resources last updated: 12/20/2015 3:44:50 AM