superreview granted: [Bug 448281] font-size sometimes gets calculated wrong : [Attachment 332497] patch 1: don't rebuild rule cascades if they're aren't currently anyBoris Zbarsky (todo: 200+ items) <bzbarsky@mit.edu> has granted David Baron
[:dbaron] <dbaron@mozilla.com>'s request for superreview:
Bug 448281: font-size sometimes gets calculated wrong
https://bugzilla.mozilla.org/show_bug.cgi?id=448281
Attachment 332497: patch 1: don't rebuild rule cascades if they're aren't
currently any
https://bugzilla.mozilla.org/attachment.cgi?id=332497&action=edit
------- Additional Comments from Boris Zbarsky (todo: 200+ items)
<bzbarsky@mit.edu>
>+ // early (e.g., before whether we know if the quirk style sheet...
superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Masayuki Nakano
(Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview:
Bug 430650: '^' and '=C2=A8' chars don't work in password fields
https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650
Attachment 317954: Patch v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit
------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.or=
g>
+ if (aState =3D=3D mIMEData->mEnabled) {=0D
mIMEData->mEnabled =3D aState;=0D
=0D...
superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 318391] Patch v1.1Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted=20
superreview:
Bug 430650: '^' and '=C2=A8' chars don't work in password fields
https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650
Attachment 318391: Patch v1.1
https://bugzilla.mozilla.org/attachment.cgi?id=3D318391&action=3Dedit
------- Additional Comments from Masayuki Nakano (Mozilla Japan)
<masayuki@d-toybox.com>
Thank you, Roc and Katakai-san.=
...
superreview granted: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patchRobert O'Callahan <roc@ocallahan.org> has granted David Baron
<dbaron@dbaron.org>'s request for superreview:
Bug 248606: "arrow" doesn't change to hand over links, links don't get bold
font-weight inside frame
http://bugzilla.mozilla.org/show_bug.cgi?id=248606
Attachment 151705: patch
http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit
------- Additional Comments from Robert O'Callahan <roc@ocallahan.org>
d'oh! I should have caught that. Leave the debug code in.
...
superreview granted: [Bug 307788] if Kerberos tickets don't exist when launching T-Bird, get Krb Ticket Manager to prompt for them : [Attachment 200634] a one line patch...David Bienvenu <bienvenu@nventure.com> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 307788: if Kerberos tickets don't exist when launching T-Bird, get Krb
Ticket Manager to prompt for them
https://bugzilla.mozilla.org/show_bug.cgi?id=307788
Attachment 200634: a one line patch...
https://bugzilla.mozilla.org/attachment.cgi?id=200634&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
retroactively marking reviewed,and carrying over cneberg's r=. This was checked
into the trunk.
...
superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 264442: plugin finder can't find anything for windows media.
https://bugzilla.mozilla.org/show_bug.cgi?id=264442
Attachment 162212: Don't assume we don't have a plugin before getting a
responce from the network.
https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
r+sr=bzbarsky, I guess..
Is ther a reason mIsBrokenPlugin is write-only?
...
superreview granted: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the selneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron
Leventhal <aaronleventhal@moonset.net>'s request for superreview:
Bug 269318: TAB doesn't start from selection text after mouse click
https://bugzilla.mozilla.org/show_bug.cgi?id=269318
Attachment 166255: If element gets focused, move selection to focus if focus
isn't already inside the selection. mLastFocusedWith is no longer needed for
making tab not move relative to selection after a mouse click
https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit
------- Addition...
superreview requested: [Bug 448281] font-size sometimes gets calculated wrong : [Attachment 332497] patch 1: don't rebuild rule cascades if they're aren't currently anyDavid Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky (todo: 200+
items) <bzbarsky@mit.edu> for superreview:
Bug 448281: font-size sometimes gets calculated wrong
https://bugzilla.mozilla.org/show_bug.cgi?id=448281
Attachment 332497: patch 1: don't rebuild rule cascades if they're aren't
currently any
https://bugzilla.mozilla.org/attachment.cgi?id=332497&action=edit
...
superreview granted: [Bug 271955] "empty" table cells don't include borders in size even when 'empty-cells: show' : [Attachment 167169] patchRobert O'Callahan <roc@ocallahan.org> has granted David Baron
<dbaron@mozilla.org>'s request for superreview:
Bug 271955: "empty" table cells don't include borders in size even when
'empty-cells: show'
https://bugzilla.mozilla.org/show_bug.cgi?id=271955
Attachment 167169: patch
https://bugzilla.mozilla.org/attachment.cgi?id=167169&action=edit
...
superreview granted: [Bug 261707] Links with empty href don't get a focus outline when they are focused : [Attachment 160598] Proposed patchJohnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 261707: Links with empty href don't get a focus outline when they are
focused
https://bugzilla.mozilla.org/show_bug.cgi?id=261707
Attachment 160598: Proposed patch
https://bugzilla.mozilla.org/attachment.cgi?id=160598&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
sr=jst
...
superreview granted: [Bug 299839] If I use the option 'reset camino' it removes downloaded files out of my download location. : [Attachment 189206] Alternative patch, don't cancel finnished downloadsMike Pinkerton <pinkerton@aol.net> has granted Mike Pinkerton
<pinkerton@aol.net>'s request for superreview:
Bug 299839: If I use the option 'reset camino' it removes downloaded files out
of my download location.
https://bugzilla.mozilla.org/show_bug.cgi?id=299839
Attachment 189206: Alternative patch, don't cancel finnished downloads
https://bugzilla.mozilla.org/attachment.cgi?id=189206&action=edit
------- Additional Comments from Mike Pinkerton <pinkerton@aol.net>
sr=pink. i prefer this as well.
...
superreview granted: [Bug 190974] [IMAP] Can't manage mail by 'deleted' flag : [Attachment 326750] Fix for bad path info and missing suite change in last patchDale Wiggins <dwiggins@qualcomm.com> has granted superreview:
Bug 190974: [IMAP] Can't manage mail by 'deleted' flag
https://bugzilla.mozilla.org/show_bug.cgi?id=190974
Attachment 326750: Fix for bad path info and missing suite change in last patch
https://bugzilla.mozilla.org/attachment.cgi?id=326750&action=edit
------- Additional Comments from Dale Wiggins <dwiggins@qualcomm.com>
Fixed bad path references and missing suite file. continuing r=mnyromyr
sr=bienvenu
...
superreview granted: [Bug 190974] [IMAP] Can't manage mail by 'deleted' flag : [Attachment 326750] Fix for bad path info and missing suite change in last patch #2David Bienvenu <bienvenu@nventure.com> has granted Karsten D=C3=BCsterloh
<mnyromyr@tprac.de>'s request for superreview:
Bug 190974: [IMAP] Can't manage mail by 'deleted' flag
https://bugzilla.mozilla.org/show_bug.cgi?id=3D190974
Attachment 326750: Fix for bad path info and missing suite change in last p=
atch
https://bugzilla.mozilla.org/attachment.cgi?id=3D326750&action=3Dedit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
this looks ok to me=
...
superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky
<bz-vacation@mit.edu>'s request for superreview:
Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and
height not set)
http://bugzilla.mozilla.org/show_bug.cgi?id=122238
Attachment 139545: Same as jkeiser's patch, really...
http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
+ if (!name.IsEmpty()) {
+ aFormSubmission->AddNameValuePair(thi...
superreview granted: [Bug 139568] [FIX]ASSERT: nsFrameManager::GenerateStateKey didn't find content by type!: 'index > -1', file nsFrameManager.cpp, line 2261 : [Attachment 172218] PatchJohnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 139568: [FIX]ASSERT: nsFrameManager::GenerateStateKey didn't find content
by type!: 'index > -1', file nsFrameManager.cpp, line 2261
https://bugzilla.mozilla.org/show_bug.cgi?id=139568
Attachment 172218: Patch
https://bugzilla.mozilla.org/attachment.cgi?id=172218&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
nsCOMPtr<nsIHTMLDocument>
htmlDocument(do_QueryInterface(aConten...