superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...

superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
Johnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ------- Additional Comments from Johnny Stenback <jst@netscape.com> sr=jst ...

superreview granted: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the sel
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 269318: TAB doesn't start from selection text after mouse click https://bugzilla.mozilla.org/show_bug.cgi?id=269318 Attachment 166255: If element gets focused, move selection to focus if focus isn't already inside the selection. mLastFocusedWith is no longer needed for making tab not move relative to selection after a mouse click https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit ------- Addition...

superreview granted: [Bug 448281] font-size sometimes gets calculated wrong : [Attachment 332497] patch 1: don't rebuild rule cascades if they're aren't currently any
Boris Zbarsky (todo: 200+ items) <bzbarsky@mit.edu> has granted David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 448281: font-size sometimes gets calculated wrong https://bugzilla.mozilla.org/show_bug.cgi?id=448281 Attachment 332497: patch 1: don't rebuild rule cascades if they're aren't currently any https://bugzilla.mozilla.org/attachment.cgi?id=332497&action=edit ------- Additional Comments from Boris Zbarsky (todo: 200+ items) <bzbarsky@mit.edu> >+ // early (e.g., before whether we know if the quirk style sheet...

superreview granted: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to cre
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview granted: [Bug 300779] Support multiple selection for xul:tree : [Attachment 190476] Expose via a11y events. We don't need DOMItemSelected after all, they aren't fired for tree. We'll go
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 300779: Support multiple selection for xul:tree https://bugzilla.mozilla.org/show_bug.cgi?id=300779 Attachment 190476: Expose via a11y events. We don't need DOMItemSelected after all, they aren't fired for tree. We'll go off of "select" DOM events later for the add/remove a11y events. https://bugzilla.mozilla.org/attachment.cgi?id=190476&action=edit ...

superreview granted: [Bug 288532] OOM crash [@ XPCConvert::JSErrorToXPCException] : [Attachment 179228] don't leak and don't crash
rbs@maths.uq.edu.au has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 288532: OOM crash [@ XPCConvert::JSErrorToXPCException] https://bugzilla.mozilla.org/show_bug.cgi?id=288532 Attachment 179228: don't leak and don't crash https://bugzilla.mozilla.org/attachment.cgi?id=179228&action=edit ------- Additional Comments from rbs@maths.uq.edu.au sr=rbs ...

superreview requested: [Bug 359392] Very slow rendering of the top bar on mozilla.org : [Attachment 246745] Don't tile when we don't have to
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 359392: Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246745: Don't tile when we don't have to https://bugzilla.mozilla.org/attachment.cgi?id=246745&action=edit ...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...

superreview denied: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246745] Don't tile when we don't have to
Boris Zbarsky <bzbarsky@mit.edu> has denied Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246745: Don't tile when we don't have to https://bugzilla.mozilla.org/attachment.cgi?id=246745&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Actually, that uses the wrong offset in the case when there's more than one tile... I'll update the patch. ...

superreview cancelled: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246745] Don't tile when we don't have to
Boris Zbarsky <bzbarsky@mit.edu> has cancelled Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246745: Don't tile when we don't have to https://bugzilla.mozilla.org/attachment.cgi?id=246745&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Actually, that uses the wrong offset in the case when there's more than one tile... I'll update the patch. ...

superreview granted: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -w
David Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 180304: Same as diff -w https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit ...