superreview granted: [Bug 250386] Camino should look for user defined earchURLList.plist first before using the default list. : [Attachment 163203] Updated patch addressing review comments

Mike Pinkerton <pinkerton@aol.net> has granted Ludovic Hirlimann
<qa-mozilla@hirlimann.net>'s request for superreview:
Bug 250386: Camino should look for user defined earchURLList.plist first before
using the default list.
https://bugzilla.mozilla.org/show_bug.cgi?id=250386

Attachment 163203: Updated patch addressing review comments
https://bugzilla.mozilla.org/attachment.cgi?id=163203&action=edit

------- Additional Comments from Mike Pinkerton <pinkerton@aol.net>
+	 NSString *defaultSearchEngineList = [[NSBundle mainBundle]
pathForResource:@"SearchURLList" ofType:@"plist"];

rather than do this twice, pull this declaration out of the if statement so
that it is scoped to the entire method.

just attach another quick patch and it'll get sr.
0
bugzilla
11/2/2004 5:59:18 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
670 Views

Similar Articles

[PageSpeed] 22
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 250386] Camino should look for user defined earchURLList.plist first before using the default list. : [Attachment 163203] Updated patch addressing review comments
Ludovic Hirlimann <qa-mozilla@hirlimann.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 250386: Camino should look for user defined earchURLList.plist first before using the default list. https://bugzilla.mozilla.org/show_bug.cgi?id=250386 Attachment 163203: Updated patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=163203&action=edit ------- Additional Comments from Ludovic Hirlimann <qa-mozilla@hirlimann.net> asking for sr ...

superreview granted: [Bug 250386] Camino should look for user defined earchURLList.plist first before using the default list. : [Attachment 164337] Updated patch addressing pinkerton's sr comments
Mike Pinkerton <pinkerton@aol.net> has granted Ludovic Hirlimann <qa-mozilla@hirlimann.net>'s request for superreview: Bug 250386: Camino should look for user defined earchURLList.plist first before using the default list. https://bugzilla.mozilla.org/show_bug.cgi?id=250386 Attachment 164337: Updated patch addressing pinkerton's sr comments https://bugzilla.mozilla.org/attachment.cgi?id=164337&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink, but i re-did the patch with some tweaks, attaching new patch. ...

superreview requested: [Bug 250386] Camino should look for user defined earchURLList.plist first before using the default list. : [Attachment 164337] Updated patch addressing pinkerton's sr comments
Ludovic Hirlimann <qa-mozilla@hirlimann.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 250386: Camino should look for user defined earchURLList.plist first before using the default list. https://bugzilla.mozilla.org/show_bug.cgi?id=250386 Attachment 164337: Updated patch addressing pinkerton's sr comments https://bugzilla.mozilla.org/attachment.cgi?id=164337&action=edit ...

superreview granted: [Bug 361901] Save Page menuitem label missing from File menu when DM is open : [Attachment 247269] Updated patch that addresses review comments (and not using strres.js)
Stefan <stefanh@bluebottle.com> has granted superreview: Bug 361901: Save Page menuitem label missing from File menu when DM is open https://bugzilla.mozilla.org/show_bug.cgi?id=361901 Attachment 247269: Updated patch that addresses review comments (and not using strres.js) https://bugzilla.mozilla.org/attachment.cgi?id=247269&action=edit ------- Additional Comments from Stefan <stefanh@bluebottle.com> This fixes the review comments and is without strres.js. I think we should do this for trunk as well - I'll try to fix the rest of the issues in the 1.9. Anyw...

superreview granted: [Bug 418206] Some SVG files that appear to hang Mozilla : [Attachment 304500] patch addressing review comments
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Jonathan Watt <jwatt@jwatt.org>'s request for superreview: Bug 418206: Some SVG files that appear to hang Mozilla https://bugzilla.mozilla.org/show_bug.cgi?id=418206 Attachment 304500: patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=304500&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Can we have a mochitest for this? ...

superreview granted: [Bug 123315] Search plugins [engines] should be installed in the user's profile directory : [Attachment 187603] patch addressing review comments
Mike Shaver <shaver@mozilla.org> has granted Mike Connor <mconnor@steelgryphon.com>'s request for superreview: Bug 123315: Search plugins [engines] should be installed in the user's profile directory https://bugzilla.mozilla.org/show_bug.cgi?id=123315 Attachment 187603: patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=187603&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> >+ else if (nsCRT::strcmp(prop, NS_APP_USER_SEARCH_DIR) == 0) >+ { >+ rv = NS_GetSpecialDirectory(NS_AP...

superreview granted: [Bug 265903] Camino crashes when starting a download if download folder not specified in IC preferences (e.g. a fresh user account) : [Attachment 171918] Patch addressing review
Mike Pinkerton <pinkerton@aol.net> has granted Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 265903: Camino crashes when starting a download if download folder not specified in IC preferences (e.g. a fresh user account) https://bugzilla.mozilla.org/show_bug.cgi?id=265903 Attachment 171918: Patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=171918&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink has a bug been filed with apple? someone should do that before it's forgott...

superreview granted: [Bug 348455] [FIX]Review comments in bug 285727 never got addressed : [Attachment 233863] Patch
David Baron <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 348455: [FIX]Review comments in bug 285727 never got addressed https://bugzilla.mozilla.org/show_bug.cgi?id=348455 Attachment 233863: Patch https://bugzilla.mozilla.org/attachment.cgi?id=233863&action=edit ...

superreview granted: [Bug 230466] Saving an attachment does not bring up a stand alone progress window : [Attachment 139947] updated patch with review comments
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 230466: Saving an attachment does not bring up a stand alone progress window http://bugzilla.mozilla.org/show_bug.cgi?id=230466 Attachment 139947: updated patch with review comments http://bugzilla.mozilla.org/attachment.cgi?id=139947&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward the sr ...

superreview granted: [Bug 294137] Mozilla accepts illegal syntax on transform attribute : [Attachment 238311] address review comments
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 294137: Mozilla accepts illegal syntax on transform attribute https://bugzilla.mozilla.org/show_bug.cgi?id=294137 Attachment 238311: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=238311&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> nice ...

superreview granted: [Bug 176637] Custom link colors not rendered correctly : [Attachment 139312] patch with review comments addressed
Boris Zbarsky <bz-vacation@mit.edu> has granted Andreas Kunz <durbacher@gmx.de>'s request for superreview: Bug 176637: Custom link colors not rendered correctly http://bugzilla.mozilla.org/show_bug.cgi?id=176637 Attachment 139312: patch with review comments addressed http://bugzilla.mozilla.org/attachment.cgi?id=139312&action=edit ------- Additional Comments from Boris Zbarsky <bz-vacation@mit.edu> sr=me. I assume you need this checked in too? ...

superreview denied: [Bug 130728] messageBody.css should use namespaces correctly : [Attachment 159996] Patch to address review comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has denied Justin Wood (Callek on irc) <116057@bacon.qcc.mass.edu>'s request for superreview: Bug 130728: messageBody.css should use namespaces correctly https://bugzilla.mozilla.org/show_bug.cgi?id=130728 Attachment 159996: Patch to address review comments https://bugzilla.mozilla.org/attachment.cgi?id=159996&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> window isn't used at all; mailattachcount, header and headerdisplayname are not XUL,...

superreview granted: [Bug 44863] UI for multiple identities per account : [Attachment 148338] updated patch with review comments
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 44863: UI for multiple identities per account http://bugzilla.mozilla.org/show_bug.cgi?id=44863 Attachment 148338: updated patch with review comments http://bugzilla.mozilla.org/attachment.cgi?id=148338&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying forward the sr ...

superreview requested: [Bug 418206] Some SVG files that appear to hang Mozilla : [Attachment 304500] patch addressing review comments
Jonathan Watt <jwatt@jwatt.org> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 418206: Some SVG files that appear to hang Mozilla https://bugzilla.mozilla.org/show_bug.cgi?id=418206 Attachment 304500: patch addressing review comments https://bugzilla.mozilla.org/attachment.cgi?id=304500&action=edit ------- Additional Comments from Jonathan Watt <jwatt@jwatt.org> I should get an editor with a built-in spell checker. :-) ...

Web resources about - superreview granted: [Bug 250386] Camino should look for user defined earchURLList.plist first before using the default list. : [Attachment 163203] Updated patch addressing review comments - netscape.mozilla.reviewers

Resources last updated: 11/22/2015 4:32:41 AM