superreview granted: [Bug 279496] can't copy or paste in <input> and <textarea> : [Attachment 172323] 1) Keep -moz-user-focus: ignore entries, they affect blur supression 2) Modify nsXULPopupListenBoris Zbarsky <bzbarsky@mit.edu> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 279496: can't copy or paste in <input> and <textarea>
https://bugzilla.mozilla.org/show_bug.cgi?id=279496
Attachment 172323: 1) Keep -moz-user-focus: ignore entries, they affect blur
supression 2) Modify nsXULPopupListener to use isFocusable()
https://bugzilla.mozilla.org/attachment.cgi?id=172323&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
sr=bzbarsky
...
superreview granted: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the selneil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron
Leventhal <aaronleventhal@moonset.net>'s request for superreview:
Bug 269318: TAB doesn't start from selection text after mouse click
https://bugzilla.mozilla.org/show_bug.cgi?id=269318
Attachment 166255: If element gets focused, move selection to focus if focus
isn't already inside the selection. mLastFocusedWith is no longer needed for
making tab not move relative to selection after a mouse click
https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit
------- Addition...
superreview requested: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the sAaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com> for superreview:
Bug 269318: TAB doesn't start from selection text after mouse click
https://bugzilla.mozilla.org/show_bug.cgi?id=269318
Attachment 166255: If element gets focused, move selection to focus if focus
isn't already inside the selection. mLastFocusedWith is no longer needed for
making tab not move relative to selection after a mouse click
https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit
...
superreview requested: [Bug 279496] can't copy or paste in <input> and <textarea> : [Attachment 172323] 1) Keep -moz-user-focus: ignore entries, they affect blur supression 2) Modify nsXULPopupListAaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 279496: can't copy or paste in <input> and <textarea>
https://bugzilla.mozilla.org/show_bug.cgi?id=279496
Attachment 172323: 1) Keep -moz-user-focus: ignore entries, they affect blur
supression 2) Modify nsXULPopupListener to use isFocusable()
https://bugzilla.mozilla.org/attachment.cgi?id=172323&action=edit
...
superreview requested: [Bug 303730] <textarea>s in other tabs mess up focus in current 'tab' : [Attachment 191835] proposed fixChristian Persch <chpe@gnome.org> has asked Peter Van der Beken
<peterv@propagandism.org> for superreview:
Bug 303730: <textarea>s in other tabs mess up focus in current 'tab'
https://bugzilla.mozilla.org/show_bug.cgi?id=303730
Attachment 191835: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=191835&action=edit
------- Additional Comments from Christian Persch <chpe@gnome.org>
Let's request r/sr... (I hope I picked the right ones)
...
superreview cancelled: [Bug 303730] <textarea>s in other tabs mess up focus in current 'tab' : [Attachment 191835] proposed fixChristian Persch <chpe@gnome.org> has cancelled Peter Van der Beken
<peterv@propagandism.org>'s request for superreview:
Bug 303730: <textarea>s in other tabs mess up focus in current 'tab'
https://bugzilla.mozilla.org/show_bug.cgi?id=303730
Attachment 191835: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=191835&action=edit
...
superreview requested: [Bug 303730] <textarea>s in other tabs mess up focus in current 'tab' : [Attachment 200072] trunk patchChristian Persch <chpe@gnome.org> has asked Brian Ryner <bryner@brianryner.com>
for superreview:
Bug 303730: <textarea>s in other tabs mess up focus in current 'tab'
https://bugzilla.mozilla.org/show_bug.cgi?id=303730
Attachment 200072: trunk patch
https://bugzilla.mozilla.org/attachment.cgi?id=200072&action=edit
...
superreview requested: [Bug 303730] <textarea>s in other tabs mess up focus in current 'tab' : [Attachment 191835] proposed fix #2Peter Van der Beken <peterv@propagandism.org> has asked Brian Ryner
<bryner@brianryner.com> for superreview:
Bug 303730: <textarea>s in other tabs mess up focus in current 'tab'
https://bugzilla.mozilla.org/show_bug.cgi?id=303730
Attachment 191835: proposed fix
https://bugzilla.mozilla.org/attachment.cgi?id=191835&action=edit
------- Additional Comments from Peter Van der Beken <peterv@propagandism.org>
Looks good to me, but I'd prefer someone who knows focus to take a look.
...
superreview granted: [Bug 303620] Focus rectangle drawn at <select> when focus is actually on <input> : [Attachment 193586] Correct patch (applies to trunk only)Brian Ryner <bryner@brianryner.com> has granted Brian Ryner
<bryner@brianryner.com>'s request for superreview:
Bug 303620: Focus rectangle drawn at <select> when focus is actually on <input>
https://bugzilla.mozilla.org/show_bug.cgi?id=303620
Attachment 193586: Correct patch (applies to trunk only)
https://bugzilla.mozilla.org/attachment.cgi?id=193586&action=edit
------- Additional Comments from Brian Ryner <bryner@brianryner.com>
>--- content/events/src/nsEventStateManager.h 16 Aug 2005 17:54:28 -0000
1.138
>+++ content/events/src/...
superreview granted: [Bug 261707] Links with empty href don't get a focus outline when they are focused : [Attachment 160598] Proposed patchJohnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 261707: Links with empty href don't get a focus outline when they are
focused
https://bugzilla.mozilla.org/show_bug.cgi?id=261707
Attachment 160598: Proposed patch
https://bugzilla.mozilla.org/attachment.cgi?id=160598&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com>
sr=jst
...
superreview granted: [Bug 277724] [FIX]<select> and <textarea> don't restore disabled state : [Attachment 245370] FixJohnny Stenback <jst@mozilla.org> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 277724: [FIX]<select> and <textarea> don't restore disabled state
https://bugzilla.mozilla.org/show_bug.cgi?id=277724
Attachment 245370: Fix
https://bugzilla.mozilla.org/attachment.cgi?id=245370&action=edit
------- Additional Comments from Johnny Stenback <jst@mozilla.org>
- In nsHTMLTextAreaElement::BeforeSetAttr():
+ if (aNotify && aNameSpaceID == kNameSpaceID_None &&
+ aName == nsHTMLAtoms::disabled) {
+...
superreview granted: [Bug 303620] Focus rectangle drawn at <select> when focus is actually on <input> : [Attachment 192375] Very sensible change -- same exact thing for button, select, input and textBrian Ryner <bryner@brianryner.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 303620: Focus rectangle drawn at <select> when focus is actually on <input>
https://bugzilla.mozilla.org/show_bug.cgi?id=303620
Attachment 192375: Very sensible change -- same exact thing for button, select,
input and textarea. Don't assume that focus stays what you set it to after a
SetContentState(NS_EVENT_STATE_FOCUS)
https://bugzilla.mozilla.org/attachment.cgi?id=192375&action=edit
...
superreview granted: [Bug 287990] <plaintext></plaintext>doesn't works well in Mozilla 1.8b1 as before : [Attachment 179355] brings back plaintextDavid Baron <dbaron@mozillafoundation.org> has granted Blake Kaplan
<mrbkap@gmail.com>'s request for superreview:
Bug 287990: <plaintext></plaintext>doesn't works well in Mozilla 1.8b1 as
before
https://bugzilla.mozilla.org/show_bug.cgi?id=287990
Attachment 179355: brings back plaintext
https://bugzilla.mozilla.org/attachment.cgi?id=179355&action=edit
------- Additional Comments from David Baron <dbaron@mozillafoundation.org>
>-// Currently there are 107 HTML tags. eHTMLTag_text = 109.
>+// Currently there are 108 HTML tags. eHTMLTag...
superreview granted: [Bug 282217] SVG <title> doesn't have the same effect as <html:title> : [Attachment 194778] patch v3Boris Zbarsky <bzbarsky@mit.edu> has granted Jonathan Watt
<jonathan.watt@strath.ac.uk>'s request for superreview:
Bug 282217: SVG <title> doesn't have the same effect as <html:title>
https://bugzilla.mozilla.org/show_bug.cgi?id=282217
Attachment 194778: patch v3 - now really checking parent is the document
element
https://bugzilla.mozilla.org/attachment.cgi?id=194778&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
>Index: mozilla/content/xml/document/src/nsXMLContentSink.cpp
>+ nsCOMPtr<nsIContent...