superreview requested: [Bug 242346] "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts : [Attachment 147494] Patch
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 242346: "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts http://bugzilla.mozilla.org/show_bug.cgi?id=242346 Attachment 147494: Patch http://bugzilla.mozilla.org/attachment.cgi?id=147494&action=edit ------- Additional Comments from Stefan Borggraefe <Stefan.Borggraefe@gmx.de> I can change the order of the attributes before the checkin. ...

superreview requested: [Bug 242346] "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts : [Attachment 147494] Patch #2
Stefan Borggraefe <Stefan.Borggraefe@gmx.de> has asked Alec Flett <alecf@flett.org> for superreview: Bug 242346: "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts http://bugzilla.mozilla.org/show_bug.cgi?id=242346 Attachment 147494: Patch http://bugzilla.mozilla.org/attachment.cgi?id=147494&action=edit ...

superreview granted: [Bug 220451] Popup Manager's "Allowed Sites" dialog doesn't persist size and position : [Attachment 132310] Patch
Alec Flett <alecf@flett.org> has granted Stefan Borggraefe <borggraefe@despammed.com>'s request for superreview: Bug 220451: Popup Manager's "Allowed Sites" dialog doesn't persist size and position http://bugzilla.mozilla.org/show_bug.cgi?id=220451 Attachment 132310: Patch http://bugzilla.mozilla.org/attachment.cgi?id=132310&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf ...

superreview granted: [Bug 217147] [pwd-mngr] "View Saved Passwords..." window doesn't remember its size and position : [Attachment 131839] patch to fix bug 205176 as well
Brian Ryner <bryner@brianryner.com> has granted Steffen Wilberg <steffen.wilberg@web.de>'s request for superreview: Bug 217147: [pwd-mngr] "View Saved Passwords..." window doesn't remember its size and position http://bugzilla.mozilla.org/show_bug.cgi?id=217147 Attachment 131839: patch to fix bug 205176 as well http://bugzilla.mozilla.org/attachment.cgi?id=131839&action=edit ------- Additional Comments from Brian Ryner <bryner@brianryner.com> r+sr=bryner ...

superreview granted: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Scott MacGregor <mscott@mozilla.org> has granted Simon Montagu <smontagu@smontagu.org>'s request for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> this needs a toolkit module owner review so I'll ask Benjamin for that. David's on vacation, i'll do the sr. ...

superreview requested: [Bug 220451] Popup Manager's "Allowed Sites" dialog doesn't persist size and position : [Attachment 132310] Patch
Stefan Borggraefe <borggraefe@despammed.com> has asked Alec Flett <alecf@flett.org> for superreview: Bug 220451: Popup Manager's "Allowed Sites" dialog doesn't persist size and position http://bugzilla.mozilla.org/show_bug.cgi?id=220451 Attachment 132310: Patch http://bugzilla.mozilla.org/attachment.cgi?id=132310&action=edit ...

superreview requested: [Bug 217147] "View Saved Passwords..." window doesn't remember its size and position : [Attachment 131839] patch to fix bug 205176 as well
Steffen Wilberg <steffen.wilberg@web.de> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 217147: "View Saved Passwords..." window doesn't remember its size and position http://bugzilla.mozilla.org/show_bug.cgi?id=217147 Attachment 131839: patch to fix bug 205176 as well http://bugzilla.mozilla.org/attachment.cgi?id=131839&action=edit ------- Additional Comments from Steffen Wilberg <steffen.wilberg@web.de> Brian, I just realized that you've got the full cvs blame for both files. Can you review this please? ...

superreview requested: [Bug 350693] "Character Encoding" in "View Source" window doesn't work : [Attachment 236818] Patch
Simon Montagu <smontagu@smontagu.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 350693: "Character Encoding" in "View Source" window doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=350693 Attachment 236818: Patch https://bugzilla.mozilla.org/attachment.cgi?id=236818&action=edit ------- Additional Comments from Simon Montagu <smontagu@smontagu.org> This is a port of Neil's patch to xpfe in bug 252317. It had r=doron, sr=bzbarsky over there, so I guess rs should be enough to apply it to toolkit. ...

superreview granted: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
Robert O'Callahan <roc@ocallahan.org> has granted David Baron <dbaron@dbaron.org>'s request for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> d'oh! I should have caught that. Leave the debug code in. ...

superreview granted: [Bug 237712] Gecko (? Firefox & Camino) doesn't interpret "macintosh" encoding as "x-mac-roman" : [Attachment 171486] patch (alias)
Boris Zbarsky <bzbarsky@mit.edu> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 237712: Gecko (? Firefox & Camino) doesn't interpret "macintosh" encoding as "x-mac-roman" https://bugzilla.mozilla.org/show_bug.cgi?id=237712 Attachment 171486: patch (alias) https://bugzilla.mozilla.org/attachment.cgi?id=171486&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Sure. sr=bzbarsky ...

superreview granted: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 144546] patch
Brian Ryner (IBM) <bryner@brianryner.com> has granted Andrew Schultz <ajschult@mindspring.com>'s request for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 144546: patch http://bugzilla.mozilla.org/attachment.cgi?id=144546&action=edit ...

superreview granted: [Bug 422511] "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" : [Attachment 312549] Patch
Christian :Biesinger <cbiesinger@gmail.com> has granted H=C3=A5kan Waara <hwaara@gmail.com>'s request for superreview: Bug 422511: "Open with 'TextEditor.app'" Should be "Open with 'TextEditor'" https://bugzilla.mozilla.org/show_bug.cgi?id=3D422511 Attachment 312549: Patch https://bugzilla.mozilla.org/attachment.cgi?id=3D312549&action=3Dedit= ...

superreview granted: [Bug 49487] If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" : [Attachment 147374] fix error dialog
Brian Ryner (IBM) <bryner@brianryner.com> has granted Andrew Schultz <ajschult@verizon.net>'s request for superreview: Bug 49487: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next" http://bugzilla.mozilla.org/show_bug.cgi?id=49487 Attachment 147374: fix error dialog http://bugzilla.mozilla.org/attachment.cgi?id=147374&action=edit ...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...