superreview requested: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patchChristian Biesinger <cbiesinger@gmx.at> has asked Darin Fisher (IBM)
<darin@meer.net> for superreview:
Bug 241209: "Show File Location" and "Launch File" buttons (on download
progress dialog) don't work
http://bugzilla.mozilla.org/show_bug.cgi?id=241209
Attachment 147465: patch
http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit
...
superreview granted: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak)
<edilee@gmail.com>'s request for superreview:
Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't
show completion
https://bugzilla.mozilla.org/show_bug.cgi?id=418961
Attachment 305432: v1
https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit
...
superreview granted: [Bug 383545] "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" : [Attachment 294627] Don 't Quit, now with better capsMark Mentovai <mark@moxienet.com> has granted Chris Lawson (cl-bugs)
<cl-bugs@chrislawson.net>'s request for superreview:
Bug 383545: "Are you sure you want to quit?" dialog dismissal button should
read "Don't Quit"
https://bugzilla.mozilla.org/show_bug.cgi?id=383545
Attachment 294627: Don't Quit, now with better caps
https://bugzilla.mozilla.org/attachment.cgi?id=294627&action=edit
...
superreview requested: [Bug 418961] "Save Page As" "Text Files" saves file but Downloads window doesn't show completion : [Attachment 305432] v1Edward Lee (Mardak) <edilee@gmail.com> has asked Christian :Biesinger
<cbiesinger@gmx.at> for superreview:
Bug 418961: "Save Page As" "Text Files" saves file but Downloads window doesn't
show completion
https://bugzilla.mozilla.org/show_bug.cgi?id=418961
Attachment 305432: v1
https://bugzilla.mozilla.org/attachment.cgi?id=305432&action=edit
------- Additional Comments from Edward Lee (Mardak) <edilee@gmail.com>
Similar to what we needed to do for exthandler.. set the NETWORK bit. All
places in webbrowserpersist that have a STATE_START ...
superreview granted: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 227622] Add a "Do this automatically from now on" checkbox, v3Scott MacGregor <mscott@mozilla.org> has granted Jens Bannmann
<jens.b@web.de>'s request for superreview:
Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me
again" checkbox
https://bugzilla.mozilla.org/show_bug.cgi?id=198936
Attachment 227622: Add a "Do this automatically from now on" checkbox, v3
https://bugzilla.mozilla.org/attachment.cgi?id=227622&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
+pref("mail.askBeforePurge", true);
I'd probably...
superreview granted: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 227798] Add a "Do this automatically from now on" checkbox, v4Jens Bannmann <jens.b@web.de> has granted superreview:
Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me
again" checkbox
https://bugzilla.mozilla.org/show_bug.cgi?id=198936
Attachment 227798: Add a "Do this automatically from now on" checkbox, v4
https://bugzilla.mozilla.org/attachment.cgi?id=227798&action=edit
------- Additional Comments from Jens Bannmann <jens.b@web.de>
Carrying over r=bienvenu, sr=mscott.
Renamed the pref to mail.purge.ask and fixed Scott's nits.
...
superreview requested: [Bug 383545] "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" : [Attachment 294627] Don 't Quit, now with better capsChris Lawson (cl-bugs) <cl-bugs@chrislawson.net> has asked Mark Mentovai
<mark@moxienet.com> for superreview:
Bug 383545: "Are you sure you want to quit?" dialog dismissal button should
read "Don't Quit"
https://bugzilla.mozilla.org/show_bug.cgi?id=383545
Attachment 294627: Don't Quit, now with better caps
https://bugzilla.mozilla.org/attachment.cgi?id=294627&action=edit
------- Additional Comments from Chris Lawson (cl-bugs)
<cl-bugs@chrislawson.net>
r=me. Thanks for fixing the code as well.
...
superreview requested: [Bug 193698] "attachment" content shows a checkbox for "don't ask" : [Attachment 126870] patchChristian Biesinger <cbiesinger@web.de> has asked Darin Fisher
<darin@netscape.com> for superreview:
Bug 193698: "attachment" content shows a checkbox for "don't ask"
http://bugzilla.mozilla.org/show_bug.cgi?id=193698
Attachment 126870: patch
http://bugzilla.mozilla.org/attachment.cgi?id=126870&action=edit
...
superreview granted: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fixMike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> has granted Stuart
Morgan <stuart.morgan@alumni.case.edu>'s request for superreview:
Bug 416063: "Save this password?" dialog has "Never Save" focused instead of
"Don't Save" with FKA on (again!)
https://bugzilla.mozilla.org/show_bug.cgi?id=416063
Attachment 304041: fix
https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit
------- Additional Comments from Mike Pinkerton (not reading bugmail)
<mikepinkerton@mac.com>
sr=pink
...
superreview cancelled: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 226713] Add a "Do this automatically from now on" checkboxJens Bannmann <jens.b@web.de> has cancelled Jens Bannmann <jens.b@web.de>'s
request for superreview:
Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me
again" checkbox
https://bugzilla.mozilla.org/show_bug.cgi?id=198936
Attachment 226713: Add a "Do this automatically from now on" checkbox
https://bugzilla.mozilla.org/attachment.cgi?id=226713&action=edit
------- Additional Comments from Jens Bannmann <jens.b@web.de>
Changed the dialog title to "Compact Folders" per bug 116215 comment 8 by
...
superreview granted: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 136628] <xpistatus.*> patch v3neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Serge
GAUTHERIE <gautheri@noos.fr>'s request for superreview:
Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to
<dialog>
http://bugzilla.mozilla.org/show_bug.cgi?id=226958
Attachment 136628: <xpistatus.*> patch v3
http://bugzilla.mozilla.org/attachment.cgi?id=136628&action=edit
------- Additional Comments from neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>
I checked in the patch with ben's changes.
...
superreview granted: [Bug 284276] "Save Link (Target) As" doesn't display file size, clicking the link itself displays file size on download (FTP) : [Attachment 177385] patchBoris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi)
<cbiesinger@gmx.at>'s request for superreview:
Bug 284276: "Save Link (Target) As" doesn't display file size, clicking the
link itself displays file size on download (FTP)
https://bugzilla.mozilla.org/show_bug.cgi?id=284276
Attachment 177385: patch
https://bugzilla.mozilla.org/attachment.cgi?id=177385&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
Seems reasonable
...
superreview requested: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 226965] Add a "Do this automatically from now on" checkbox, v2Jens Bannmann <jens.b@web.de> has asked Scott MacGregor <mscott@mozilla.org>
for superreview:
Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me
again" checkbox
https://bugzilla.mozilla.org/show_bug.cgi?id=198936
Attachment 226965: Add a "Do this automatically from now on" checkbox, v2
https://bugzilla.mozilla.org/attachment.cgi?id=226965&action=edit
------- Additional Comments from Jens Bannmann <jens.b@web.de>
Changed the dialog title to "Compact Folders" per bug 116215 comment 8 by
beltzn...
superreview cancelled: [Bug 198936] [patch] "Do you wish to compact..." dialog has no "don't ask me again" checkbox : [Attachment 226965] Add a "Do this automatically from now on" checkbox, v2Jens Bannmann <jens.b@web.de> has cancelled Jens Bannmann <jens.b@web.de>'s
request for superreview:
Bug 198936: [patch] "Do you wish to compact..." dialog has no "don't ask me
again" checkbox
https://bugzilla.mozilla.org/show_bug.cgi?id=198936
Attachment 226965: Add a "Do this automatically from now on" checkbox, v2
https://bugzilla.mozilla.org/attachment.cgi?id=226965&action=edit
------- Additional Comments from Jens Bannmann <jens.b@web.de>
Fixed the brace.
...