superreview granted: [Bug 240775] RSA operations take 2x as long with gcc build as they do with VACPP build ; assembler code isn't in use : [Attachment 146339] Use mpi assembly code in gcc OS/2 build

Wan-Teh Chang <wchang0222@aol.com> has granted Julien Pierre
<julien.pierre.bugs@sun.com>'s request for superreview:
Bug 240775: RSA operations take 2x as long with gcc build as they do with VACPP
build ; assembler code isn't in use
http://bugzilla.mozilla.org/show_bug.cgi?id=240775

Attachment 146339: Use mpi assembly code in gcc OS/2 build
http://bugzilla.mozilla.org/attachment.cgi?id=146339&action=edit

------- Additional Comments from Wan-Teh Chang <wchang0222@aol.com>
r=wtc.	You guys need to decide whether
you want to use ALP as the assembler for
NSS GCC build.

> # Override suffix in suffix.mk
> LIB_SUFFIX  = lib
> DLL_SUFFIX  = dll
> PROG_SUFFIX = .exe
> 
>+# assembler settings
>+ASM_SUFFIX  = .asm
>+AS = alp.exe
>+ifdef BUILD_OPT
>+ASFLAGS = -Od
>+else
>+ASFLAGS = +Od
>+endif

It may look nicer to move ASM_SUFFIX = .asm
to the previous section (Override suffix in
suffix.mk).

>+ASFLAGS += -Feo:.o
> CCC			= gcc
> LINK			= gcc
> AR			  = emxomfar r $@

It looks nicer to use tabs after "ASFLAGS"
to align "+=" with the "=" in the next line.
0
bugzilla
4/17/2004 5:26:37 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
855 Views

Similar Articles

[PageSpeed] 40
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 240775] RSA operations take 2x as long with gcc build as they do with VACPP build ; assembler code isn't in use : [Attachment 146339] Use mpi assembly code in gcc OS/2 bui
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wchang0222@aol.com> for superreview: Bug 240775: RSA operations take 2x as long with gcc build as they do with VACPP build ; assembler code isn't in use http://bugzilla.mozilla.org/show_bug.cgi?id=240775 Attachment 146339: Use mpi assembly code in gcc OS/2 build http://bugzilla.mozilla.org/attachment.cgi?id=146339&action=edit ...

superreview denied: [Bug 240775] RSA operations take 2x as long with gcc build as they do with VACPP build ; assembler code isn't in use : [Attachment 146847] patch
Julien Pierre <julien.pierre.bugs@sun.com> has denied Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 240775: RSA operations take 2x as long with gcc build as they do with VACPP build ; assembler code isn't in use http://bugzilla.mozilla.org/show_bug.cgi?id=240775 Attachment 146847: patch http://bugzilla.mozilla.org/attachment.cgi?id=146847&action=edit ...

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183652] Phase 2, v2: Allow SDK-ful builds on 10.4
Brian Ryner <bryner@brianryner.com> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183652: Phase 2, v2: Allow SDK-ful builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183652&action=edit ...

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183648] Phase 1a: SDK-less builds on 10.4, config/build portion
Brian Ryner <bryner@brianryner.com> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183648: Phase 1a: SDK-less builds on 10.4, config/build portion https://bugzilla.mozilla.org/attachment.cgi?id=183648&action=edit ...

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183870] Phase 2, v3: changes inspired by wtc's review of ph3
Brian Ryner <bryner@brianryner.com> has granted Mark Mentovai (limited availability May 19-25) <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183870: Phase 2, v3: changes inspired by wtc's review of ph3 https://bugzilla.mozilla.org/attachment.cgi?id=183870&action=edit ...

superreview granted: [Bug 245430] Investigate static build version of thunderbird : [Attachment 150467] fix static build crash on OS X. Don't use global static string objects
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 245430: Investigate static build version of thunderbird http://bugzilla.mozilla.org/show_bug.cgi?id=245430 Attachment 150467: fix static build crash on OS X. Don't use global static string objects http://bugzilla.mozilla.org/attachment.cgi?id=150467&action=edit ...

superreview cancelled: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183237] Phase 2: Allow SDK-ful builds on 10.4
Chris Seawood <cls@seawood.org> has cancelled Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183237: Phase 2: Allow SDK-ful builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183237&action=edit ------- Additional Comments from Chris Seawood <cls@seawood.org> For the Makefile changes, you should use $(shell) rather than the backticks. Since you are rearranging that section anyway,...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183237] Phase 2: Allow SDK-ful builds on 10.4
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183237: Phase 2: Allow SDK-ful builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183237&action=edit ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183652] Phase 2, v2: Allow SDK-ful builds on 10.4
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183652: Phase 2, v2: Allow SDK-ful builds on 10.4 https://bugzilla.mozilla.org/attachment.cgi?id=183652&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> (In reply to comment #97) > For the Makefile changes, you should use $(shell) rather than the backticks. Done. > Since y...

superreview granted: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183649] Phase 1b: SDK-less builds on 10.4, Mac-specific implementation portion
Mike Shaver <shaver@mozilla.org> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183649: Phase 1b: SDK-less builds on 10.4, Mac-specific implementation portion https://bugzilla.mozilla.org/attachment.cgi?id=183649&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> sr=shaver. ...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183648] Phase 1a: SDK-less builds on 10.4, config/build portion
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183648: Phase 1a: SDK-less builds on 10.4, config/build portion https://bugzilla.mozilla.org/attachment.cgi?id=183648&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Splitting phase 1 into a configure/build half and a Mac-specific implementation half per comment 96. Chris, I do AC_PA...

superreview requested: [Bug 292530] Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) : [Attachment 183870] Phase 2, v3: changes inspired by wtc's review of ph3
Mark Mentovai <mark@moxienet.com> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 292530: Build on Mac OS X "Tiger" (10.4) (don't ask about gcc 4 here) https://bugzilla.mozilla.org/show_bug.cgi?id=292530 Attachment 183870: Phase 2, v3: changes inspired by wtc's review of ph3 https://bugzilla.mozilla.org/attachment.cgi?id=183870&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Changes since ph2v2 and ph2v3: - SDK_C_INCLUDE needs to use GCC_VERSION_FULL in lib for gcc4 - use ${target_os} inste...

superreview granted: [Bug 351246] Load some of Mozilla into Highmem on OS/2 : [Attachment 248681] 248072: Changes to SQLite build and OS/2 code, updated
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Peter Weilbacher <mozilla@Weilbacher.org>'s request for superreview: Bug 351246: Load some of Mozilla into Highmem on OS/2 https://bugzilla.mozilla.org/show_bug.cgi?id=351246 Attachment 248681: 248072: Changes to SQLite build and OS/2 code, updated https://bugzilla.mozilla.org/attachment.cgi?id=248681&action=edit ...

superreview granted: [Bug 285932] Need faster SHA1 implementation, especially for AMD64 : [Attachment 192554] Compiled sha_fast.c to assembler with gcc -O3; use this only on Solaris AMD64 builds with
Wan-Teh Chang <wtchang@redhat.com> has granted Saul Edwards <saul.edwards.bugs@sun.com>'s request for superreview: Bug 285932: Need faster SHA1 implementation, especially for AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=285932 Attachment 192554: Compiled sha_fast.c to assembler with gcc -O3; use this only on Solaris AMD64 builds with Sun Studio. https://bugzilla.mozilla.org/attachment.cgi?id=192554&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> r=wtc. The information on how the sha-fast-amd64-sun.s was generated shou...

Web resources about - superreview granted: [Bug 240775] RSA operations take 2x as long with gcc build as they do with VACPP build ; assembler code isn't in use : [Attachment 146339] Use mpi assembly code in gcc OS/2 build - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/28/2015 2:00:35 PM